You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by "Ivan Andika (Jira)" <ji...@apache.org> on 2024/06/05 05:33:00 UTC
[jira] [Updated] (RATIS-2109) RaftLogBase#updateCommitIndex should return true only if commitIndex is increased
[ https://issues.apache.org/jira/browse/RATIS-2109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Andika updated RATIS-2109:
-------------------------------
Summary: RaftLogBase#updateCommitIndex should return true only if commitIndex is increased (was: RaftLogBase#updateCommitIndex should return true only if commitIndex is updated)
> RaftLogBase#updateCommitIndex should return true only if commitIndex is increased
> ---------------------------------------------------------------------------------
>
> Key: RATIS-2109
> URL: https://issues.apache.org/jira/browse/RATIS-2109
> Project: Ratis
> Issue Type: Improvement
> Reporter: Ivan Andika
> Assignee: Ivan Andika
> Priority: Minor
>
> RaftLogBase#updateCommitIndex returns true regardless whether commit index is actually increased (RaftLogIndex#updateIncreasingly returns true). This can cause unnecessary StateMachineUpdater notification
> We can change it so that RaftLogBase#updateCommitIndex only returns true if commit index is actually increased.
> Note: For leader ServerState#updateCommitIndex is called only if there are entries to commit (i.e. majority > oldLasCommitted), so RaftLogBase#updateCommitIndex should increase the commit index of leader.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)