You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuscany.apache.org by Raymond Feng <cy...@gmail.com> on 2010/12/08 01:14:53 UTC
Adding http client dependencies to host-http
Hi,
I'm making some changes to the HTTP reference bindings (such as binding-atom and binding-jsonrpc) to use Apache HTTP components HTTP client. The project coming into my mind to contain the common code for HTTPClient is host-http. But it will add a few more dependencies into the "base-runtime" and fails two test cases that check the number of dependencies. Any objections to add the HTTPClient dependency?
________________________________________________________________
Raymond Feng
rfeng@apache.org
Apache Tuscany PMC member and committer: tuscany.apache.org
Co-author of Tuscany SCA In Action book: www.tuscanyinaction.com
Personal Web Site: www.enjoyjava.com
________________________________________________________________
Re: Adding http client dependencies to host-http
Posted by Luciano Resende <lu...@gmail.com>.
On Tue, Dec 7, 2010 at 4:23 PM, Raymond Feng <cy...@gmail.com> wrote:
> Good point :-). The json-rpc reference binding already uses the HTTPClient.
> For the binding-atom, I just upgraded from commons httpclient to
> httpcomponents httpclient.
The last time I checked (apachecon timeframe) I believe we were still
using Jabsorb which internally uses java.net.HttpURLConnection which
is on the GAE white list. Maybe an easy way to check would be to
deploy one of the Nuvem apps (using your updated code) and see if that
still works :)
--
Luciano Resende
http://people.apache.org/~lresende
http://twitter.com/lresende1975
http://lresende.blogspot.com/
Re: Adding http client dependencies to host-http
Posted by Raymond Feng <cy...@gmail.com>.
Good point :-). The json-rpc reference binding already uses the HTTPClient. For the binding-atom, I just upgraded from commons httpclient to httpcomponents httpclient.
Thanks,
Raymond
________________________________________________________________
Raymond Feng
rfeng@apache.org
Apache Tuscany PMC member and committer: tuscany.apache.org
Co-author of Tuscany SCA In Action book: www.tuscanyinaction.com
Personal Web Site: www.enjoyjava.com
________________________________________________________________
On Dec 7, 2010, at 4:16 PM, Luciano Resende wrote:
> On Tue, Dec 7, 2010 at 4:14 PM, Raymond Feng <cy...@gmail.com> wrote:
>> Hi,
>> I'm making some changes to the HTTP reference bindings (such as binding-atom
>> and binding-jsonrpc) to use Apache HTTP components HTTP client. The project
>> coming into my mind to contain the common code for HTTPClient is host-http.
>> But it will add a few more dependencies into the "base-runtime" and fails
>> two test cases that check the number of dependencies. Any objections to add
>> the HTTPClient dependency?
>
> Can you please make sure this does not break GAE support.
>
> --
> Luciano Resende
> http://people.apache.org/~lresende
> http://twitter.com/lresende1975
> http://lresende.blogspot.com/
Re: Adding http client dependencies to host-http
Posted by Luciano Resende <lu...@gmail.com>.
On Tue, Dec 7, 2010 at 4:14 PM, Raymond Feng <cy...@gmail.com> wrote:
> Hi,
> I'm making some changes to the HTTP reference bindings (such as binding-atom
> and binding-jsonrpc) to use Apache HTTP components HTTP client. The project
> coming into my mind to contain the common code for HTTPClient is host-http.
> But it will add a few more dependencies into the "base-runtime" and fails
> two test cases that check the number of dependencies. Any objections to add
> the HTTPClient dependency?
Can you please make sure this does not break GAE support.
--
Luciano Resende
http://people.apache.org/~lresende
http://twitter.com/lresende1975
http://lresende.blogspot.com/
Re: Adding http client dependencies to host-http
Posted by ant elder <an...@gmail.com>.
On Wed, Dec 8, 2010 at 12:14 AM, Raymond Feng <cy...@gmail.com> wrote:
> Hi,
>
> I'm making some changes to the HTTP reference bindings (such as
> binding-atom and binding-jsonrpc) to use Apache HTTP components HTTP client.
> The project coming into my mind to contain the common code for HTTPClient is
> host-http. But it will add a few more dependencies into the "base-runtime"
> and fails two test cases that check the number of dependencies. Any
> objections to add the HTTPClient dependency?
>
Users do care about required dependencies so trying to keep the list as
small is possible is worthwhile, therefore having the HTTP Client
dependencies always required doesn't seem ideal if its not actually used for
anything.
What about defining the dependency with a scope of optional in common-http
and then for the extension that do require it define it with a scope of
runtime?
...ant