You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/09/09 13:55:31 UTC

[GitHub] [camel] bvahdat opened a new pull request #4180: add missing documentation about SimpleUuidGenerator

bvahdat opened a new pull request #4180:
URL: https://github.com/apache/camel/pull/4180


   [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
   [ ] Each commit in the pull request should have a meaningful subject line and body.
   [ ] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
   [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   [ ] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
   Below are the contribution guidelines:
   https://github.com/apache/camel/blob/master/CONTRIBUTING.md


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] oscerd commented on a change in pull request #4180: add missing documentation about SimpleUuidGenerator

Posted by GitBox <gi...@apache.org>.
oscerd commented on a change in pull request #4180:
URL: https://github.com/apache/camel/pull/4180#discussion_r485635298



##########
File path: docs/user-manual/modules/ROOT/pages/uuidgenerator.adoc
##########
@@ -46,11 +46,15 @@ bean registry to find the bean of the type
 [[UuidGenerator-Providedimplementations]]
 == Provided implementations
 
-Camel comes with two implementations of
+Camel comes with three implementations of
 `org.apache.camel.spi.UuidGenerator`:
 
-* `org.apache.camel.support.SimpleUuidGenerator` - This implementation use
-internally a `java.util.concurrent.atomic.AtomicLong` and increase the
+* `org.apache.camel.support.SimpleUuidGenerator` - This implementation uses
+internally a `java.util.concurrent.atomic.AtomicLong` and increases the
 ID for every call by one. Starting with 1 as the first id.
 * `org.apache.camel.impl.engine.DefaultUuidGenerator` - This implementation
-use a fast unique UUID generation that is cluster safe (similar to uuid generator in ActiveMQ)
+uses a fast unique UUID generation that is cluster safe (similar to uuid
+generator in ActiveMQ). This is the default implementation in use by Camel.
+* `org.apache.camel.support.SimpleUuidGenerator` - This implementation

Review comment:
       This seems to be the same first implementation, I guess




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] oscerd commented on pull request #4180: add missing documentation about SimpleUuidGenerator

Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #4180:
URL: https://github.com/apache/camel/pull/4180#issuecomment-689590692


   Lgtm. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] bvahdat commented on pull request #4180: add missing documentation about SimpleUuidGenerator

Posted by GitBox <gi...@apache.org>.
bvahdat commented on pull request #4180:
URL: https://github.com/apache/camel/pull/4180#issuecomment-689586921


   Ah thanks, that was a typo. Should be fixed now.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] asfgit merged pull request #4180: add missing documentation about SimpleUuidGenerator

Posted by GitBox <gi...@apache.org>.
asfgit merged pull request #4180:
URL: https://github.com/apache/camel/pull/4180


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org