You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flex.apache.org by Erik de Bruin <er...@ixsoftware.nl> on 2014/11/25 09:24:28 UTC
[TLF] merge 'tables' into 'develop'
Harbs, Piotr, all,
I have put the 'tables' branch of TLF against my own apps, and have
not found any (obvious) issue with backwards compatibility. Everything
looked and behaved just fine.
I think we are now at a point where we merge 'tables' into 'develop'.
You continue work on the tests in 'develop' and we prepare for an SDK
release with the new TLF. The merge will result in many more eyes on
the code and it's side effects, thereby increasing the rate at which
issues are discovered and reported - and fixed.
I promise that I will extend the run up to the cutting of the release
branch for the SDK as long as is required to stabilize TLF.
EdB
--
Ix Multimedia Software
Jan Luykenstraat 27
3521 VB Utrecht
T. 06-51952295
I. www.ixsoftware.nl
Re: [TLF] merge 'tables' into 'develop'
Posted by piotrz <pi...@gmail.com>.
Hi Erik,
I know that we have now only one failing test class (FloatTest) in tables
branch. Once Harbs fix it I'm ok from my point of view to merge everything
into develop branch.
Piotr
-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/TLF-merge-tables-into-develop-tp42713p42716.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [TLF] merge 'tables' into 'develop'
Posted by Harbs <ha...@gmail.com>.
We can probably merge it into develop.
I’m about ready to use it in production, although I do know of one regressive TLF bug that I need to look into. Selecting all text and pressing enter causes the TextFlow to get in an unstable state. (I think — unless it’s a bug in my own app)
I have not had the chance to look into that yet.
There’s also the vertical position of floats that I need to work on.
I would feel more comfortable if we had more unit tests, but we can work on that later.
On Nov 25, 2014, at 10:24 AM, Erik de Bruin <er...@ixsoftware.nl> wrote:
> Harbs, Piotr, all,
>
> I have put the 'tables' branch of TLF against my own apps, and have
> not found any (obvious) issue with backwards compatibility. Everything
> looked and behaved just fine.
>
> I think we are now at a point where we merge 'tables' into 'develop'.
> You continue work on the tests in 'develop' and we prepare for an SDK
> release with the new TLF. The merge will result in many more eyes on
> the code and it's side effects, thereby increasing the rate at which
> issues are discovered and reported - and fixed.
>
> I promise that I will extend the run up to the cutting of the release
> branch for the SDK as long as is required to stabilize TLF.
>
> EdB
>
>
>
> --
> Ix Multimedia Software
>
> Jan Luykenstraat 27
> 3521 VB Utrecht
>
> T. 06-51952295
> I. www.ixsoftware.nl
Re: [TLF] merge 'tables' into 'develop'
Posted by piotrz <pi...@gmail.com>.
Thank you Harbs!
Just remember if you would like to check any specific test class you have to
add it to MinimalTestSuite.as and run minimal test mode.
Piotr
-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/TLF-merge-tables-into-develop-tp42713p42830.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [TLF] merge 'tables' into 'develop'
Posted by Harbs <ha...@gmail.com>.
I’m also pretty sure there’s a bug somewhere in at least some Operations. I’ll look at that as well…
On Nov 28, 2014, at 11:05 AM, Harbs <ha...@gmail.com> wrote:
> I will investigate early next week why we’re getting failures. I’ll start with the FloatTests and see what I come up with.
>
> On Nov 28, 2014, at 10:16 AM, piotrz <pi...@gmail.com> wrote:
>
>> I've merged everything from tables to develop branch.
>> I've removed from tests one class OpeationTest which causes freeze of our
>> test - Need to investigate why it's happened. Tests freezing in this class
>> quite random. :(
>>
>> It's not good that any tests failed and these errors also worrying me.
>>
>> Reports for failed tests FloatTest [1], FlowModelTest [2],
>> ContainerAttributeTest
>>
>> Because so many tests are failed I think something has to be broken in TLF
>> or these tests are not suit to current changed code.
>>
>> [1]
>> http://apacheflexbuild.cloudapp.net:8080/job/flex-tlf/ws/bin/apps/automation_apps/bin/TEST-UnitTest.Tests.FloatTest.xml
>> [2]
>> http://apacheflexbuild.cloudapp.net:8080/job/flex-tlf/ws/bin/apps/automation_apps/bin/TEST-UnitTest.Tests.FlowModelTest.xml
>> [3]
>> http://apacheflexbuild.cloudapp.net:8080/job/flex-tlf/ws/bin/apps/automation_apps/bin/TEST-UnitTest.Tests.ContainerAttributeTest.xml
>>
>> Piotr
>>
>>
>>
>> -----
>> Apache Flex PMC
>> piotrzarzycki21@gmail.com
>> --
>> View this message in context: http://apache-flex-development.2333347.n4.nabble.com/TLF-merge-tables-into-develop-tp42713p42826.html
>> Sent from the Apache Flex Development mailing list archive at Nabble.com.
>
Re: [TLF] merge 'tables' into 'develop'
Posted by Harbs <ha...@gmail.com>.
I will investigate early next week why we’re getting failures. I’ll start with the FloatTests and see what I come up with.
On Nov 28, 2014, at 10:16 AM, piotrz <pi...@gmail.com> wrote:
> I've merged everything from tables to develop branch.
> I've removed from tests one class OpeationTest which causes freeze of our
> test - Need to investigate why it's happened. Tests freezing in this class
> quite random. :(
>
> It's not good that any tests failed and these errors also worrying me.
>
> Reports for failed tests FloatTest [1], FlowModelTest [2],
> ContainerAttributeTest
>
> Because so many tests are failed I think something has to be broken in TLF
> or these tests are not suit to current changed code.
>
> [1]
> http://apacheflexbuild.cloudapp.net:8080/job/flex-tlf/ws/bin/apps/automation_apps/bin/TEST-UnitTest.Tests.FloatTest.xml
> [2]
> http://apacheflexbuild.cloudapp.net:8080/job/flex-tlf/ws/bin/apps/automation_apps/bin/TEST-UnitTest.Tests.FlowModelTest.xml
> [3]
> http://apacheflexbuild.cloudapp.net:8080/job/flex-tlf/ws/bin/apps/automation_apps/bin/TEST-UnitTest.Tests.ContainerAttributeTest.xml
>
> Piotr
>
>
>
> -----
> Apache Flex PMC
> piotrzarzycki21@gmail.com
> --
> View this message in context: http://apache-flex-development.2333347.n4.nabble.com/TLF-merge-tables-into-develop-tp42713p42826.html
> Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [TLF] merge 'tables' into 'develop'
Posted by piotrz <pi...@gmail.com>.
I've merged everything from tables to develop branch.
I've removed from tests one class OpeationTest which causes freeze of our
test - Need to investigate why it's happened. Tests freezing in this class
quite random. :(
It's not good that any tests failed and these errors also worrying me.
Reports for failed tests FloatTest [1], FlowModelTest [2],
ContainerAttributeTest
Because so many tests are failed I think something has to be broken in TLF
or these tests are not suit to current changed code.
[1]
http://apacheflexbuild.cloudapp.net:8080/job/flex-tlf/ws/bin/apps/automation_apps/bin/TEST-UnitTest.Tests.FloatTest.xml
[2]
http://apacheflexbuild.cloudapp.net:8080/job/flex-tlf/ws/bin/apps/automation_apps/bin/TEST-UnitTest.Tests.FlowModelTest.xml
[3]
http://apacheflexbuild.cloudapp.net:8080/job/flex-tlf/ws/bin/apps/automation_apps/bin/TEST-UnitTest.Tests.ContainerAttributeTest.xml
Piotr
-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/TLF-merge-tables-into-develop-tp42713p42826.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [TLF] merge 'tables' into 'develop'
Posted by Erik de Bruin <er...@ixsoftware.nl>.
Hi,
Good news: the test suite ('ant all') now runs to completion. This is
the summary:
[flexunit] Tests run: 381, Failures: 3, Errors: 11, Skipped: 39, Time
elapsed: 574.023 sec
Is that what you would expect? Or do you need more details?
EdB
On Thu, Nov 27, 2014 at 3:40 PM, piotrz <pi...@gmail.com> wrote:
> Many Thanks Erik for Helping with this!
>
>
>
> -----
> Apache Flex PMC
> piotrzarzycki21@gmail.com
> --
> View this message in context: http://apache-flex-development.2333347.n4.nabble.com/TLF-merge-tables-into-develop-tp42713p42803.html
> Sent from the Apache Flex Development mailing list archive at Nabble.com.
--
Ix Multimedia Software
Jan Luykenstraat 27
3521 VB Utrecht
T. 06-51952295
I. www.ixsoftware.nl
Re: [TLF] merge 'tables' into 'develop'
Posted by Erik de Bruin <er...@ixsoftware.nl>.
No worries. The 4.14 release will have my name - or rather, my
computer account name - all over any stack traces that a user might
see. Better make sure there are as few as possible ;-)
EdB
On Thu, Nov 27, 2014 at 3:40 PM, piotrz <pi...@gmail.com> wrote:
> Many Thanks Erik for Helping with this!
>
>
>
> -----
> Apache Flex PMC
> piotrzarzycki21@gmail.com
> --
> View this message in context: http://apache-flex-development.2333347.n4.nabble.com/TLF-merge-tables-into-develop-tp42713p42803.html
> Sent from the Apache Flex Development mailing list archive at Nabble.com.
--
Ix Multimedia Software
Jan Luykenstraat 27
3521 VB Utrecht
T. 06-51952295
I. www.ixsoftware.nl
Re: [TLF] merge 'tables' into 'develop'
Posted by piotrz <pi...@gmail.com>.
Many Thanks Erik for Helping with this!
-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/TLF-merge-tables-into-develop-tp42713p42803.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [TLF] merge 'tables' into 'develop'
Posted by Erik de Bruin <er...@ixsoftware.nl>.
With 'flexdebug = false', it stalls on test 168 ...
Have to quit for today, may be able to help out some more tomorrow.
EdB
On Thu, Nov 27, 2014 at 2:13 PM, Erik de Bruin <er...@ixsoftware.nl> wrote:
> It just sits there ... But just now I started messing with the UI,
> which is still responsive, and suddenly the app crashes (is gone,
> quits) and in the Terminal I see:
>
> [flexunit] FlexUnit test Uncaught Top Level Exception in suite
> org.flexunit.events.UnknownError had errors.
>
> EdB
>
>
>
> On Thu, Nov 27, 2014 at 2:02 PM, piotrz <pi...@gmail.com> wrote:
>> It's not normal. Usually it is stuck for some time but not so long.
>>
>> Piotr
>>
>>
>>
>> -----
>> Apache Flex PMC
>> piotrzarzycki21@gmail.com
>> --
>> View this message in context: http://apache-flex-development.2333347.n4.nabble.com/TLF-merge-tables-into-develop-tp42713p42800.html
>> Sent from the Apache Flex Development mailing list archive at Nabble.com.
>
>
>
> --
> Ix Multimedia Software
>
> Jan Luykenstraat 27
> 3521 VB Utrecht
>
> T. 06-51952295
> I. www.ixsoftware.nl
--
Ix Multimedia Software
Jan Luykenstraat 27
3521 VB Utrecht
T. 06-51952295
I. www.ixsoftware.nl
Re: [TLF] merge 'tables' into 'develop'
Posted by Erik de Bruin <er...@ixsoftware.nl>.
It just sits there ... But just now I started messing with the UI,
which is still responsive, and suddenly the app crashes (is gone,
quits) and in the Terminal I see:
[flexunit] FlexUnit test Uncaught Top Level Exception in suite
org.flexunit.events.UnknownError had errors.
EdB
On Thu, Nov 27, 2014 at 2:02 PM, piotrz <pi...@gmail.com> wrote:
> It's not normal. Usually it is stuck for some time but not so long.
>
> Piotr
>
>
>
> -----
> Apache Flex PMC
> piotrzarzycki21@gmail.com
> --
> View this message in context: http://apache-flex-development.2333347.n4.nabble.com/TLF-merge-tables-into-develop-tp42713p42800.html
> Sent from the Apache Flex Development mailing list archive at Nabble.com.
--
Ix Multimedia Software
Jan Luykenstraat 27
3521 VB Utrecht
T. 06-51952295
I. www.ixsoftware.nl
Re: [TLF] merge 'tables' into 'develop'
Posted by piotrz <pi...@gmail.com>.
It's not normal. Usually it is stuck for some time but not so long.
Piotr
-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/TLF-merge-tables-into-develop-tp42713p42800.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [TLF] merge 'tables' into 'develop'
Posted by Erik de Bruin <er...@ixsoftware.nl>.
I'm looking at test 178 now, and it's been running for > 20 min. I
hope that that's not normal?
I'm going to stop the run and try again ...
EdB
On Thu, Nov 27, 2014 at 1:11 PM, piotrz <pi...@gmail.com> wrote:
> Test failures is the essential, later errors.
>
> Errors it could be some null pointer exceptions and so on, but failures -
> happens when some tests condition/asserts is not fulfill.
> Erik go to the reports and you will see more details.
>
> I will run tests tomorrow morning my time and merge everything into develop.
>
> Piotr
>
>
>
> -----
> Apache Flex PMC
> piotrzarzycki21@gmail.com
> --
> View this message in context: http://apache-flex-development.2333347.n4.nabble.com/TLF-merge-tables-into-develop-tp42713p42798.html
> Sent from the Apache Flex Development mailing list archive at Nabble.com.
--
Ix Multimedia Software
Jan Luykenstraat 27
3521 VB Utrecht
T. 06-51952295
I. www.ixsoftware.nl
Re: [TLF] merge 'tables' into 'develop'
Posted by piotrz <pi...@gmail.com>.
Test failures is the essential, later errors.
Errors it could be some null pointer exceptions and so on, but failures -
happens when some tests condition/asserts is not fulfill.
Erik go to the reports and you will see more details.
I will run tests tomorrow morning my time and merge everything into develop.
Piotr
-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/TLF-merge-tables-into-develop-tp42713p42798.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [TLF] merge 'tables' into 'develop'
Posted by Erik de Bruin <er...@ixsoftware.nl>.
I'm running that now, see a total of 459 tests, currently it's
thinking about 177.
Will let you know the final outcome, but so far I see a dozen or so
ignored tests, and 2 failures.
EdB
On Thu, Nov 27, 2014 at 1:03 PM, Harbs <ha...@gmail.com> wrote:
> Yes. That’s what I most recently got.
>
> Switching minimalTests to false causes a whole slew or errors. I don’t know how many are problems, and how many are problematic tests.
>
> On Nov 27, 2014, at 2:00 PM, Erik de Bruin <er...@ixsoftware.nl> wrote:
>
>> When I run 'ant all' with 'minimalTests = true' in build.properties, I
>> see 56 tests being run, with this as a result:
>>
>> [flexunit] FlexUnit test atParagraphEnd in suite
>> UnitTest.Tests.FloatTest failed.
>> [flexunit] FlexUnit test contentWidthCheckLongFloat in suite
>> UnitTest.Tests.FloatTest was ignored.
>> ...
>>
>> [flexunit] Tests run: 56, Failures: 1, Errors: 0, Skipped: 1, Time
>> elapsed: 24.881 sec
>>
>> Is that expected?
>>
>> EdB
>>
>>
>>
>>
>> On Thu, Nov 27, 2014 at 12:42 PM, Harbs <ha...@gmail.com> wrote:
>>> I plan on spending some time early next week getting my head better wrapped around the tests.
>>>
>>> I committed the changes. Can you see what happens when you run the full tests?
>>>
>>> On Nov 27, 2014, at 12:15 PM, piotrz <pi...@gmail.com> wrote:
>>>
>>>> During my tests migration some of the test methods initially failed, so I
>>>> have marked them as [Ignore] and decided back to them later. - That is the
>>>> skipped tests.
>>>>
>>>> You can check details of errors in tests reports -
>>>> flex-tlf/bin/apps/automation_apps/bin/
>>>>
>>>> Some of the tests are quite heavy, so it takes some time - try to wait
>>>> longer.
>>>>
>>>> Piotr
>>>>
>>>>
>>>>
>>>> -----
>>>> Apache Flex PMC
>>>> piotrzarzycki21@gmail.com
>>>> --
>>>> View this message in context: http://apache-flex-development.2333347.n4.nabble.com/TLF-merge-tables-into-develop-tp42713p42793.html
>>>> Sent from the Apache Flex Development mailing list archive at Nabble.com.
>>>
>>
>>
>>
>> --
>> Ix Multimedia Software
>>
>> Jan Luykenstraat 27
>> 3521 VB Utrecht
>>
>> T. 06-51952295
>> I. www.ixsoftware.nl
>
--
Ix Multimedia Software
Jan Luykenstraat 27
3521 VB Utrecht
T. 06-51952295
I. www.ixsoftware.nl
Re: [TLF] merge 'tables' into 'develop'
Posted by Harbs <ha...@gmail.com>.
Yes. That’s what I most recently got.
Switching minimalTests to false causes a whole slew or errors. I don’t know how many are problems, and how many are problematic tests.
On Nov 27, 2014, at 2:00 PM, Erik de Bruin <er...@ixsoftware.nl> wrote:
> When I run 'ant all' with 'minimalTests = true' in build.properties, I
> see 56 tests being run, with this as a result:
>
> [flexunit] FlexUnit test atParagraphEnd in suite
> UnitTest.Tests.FloatTest failed.
> [flexunit] FlexUnit test contentWidthCheckLongFloat in suite
> UnitTest.Tests.FloatTest was ignored.
> ...
>
> [flexunit] Tests run: 56, Failures: 1, Errors: 0, Skipped: 1, Time
> elapsed: 24.881 sec
>
> Is that expected?
>
> EdB
>
>
>
>
> On Thu, Nov 27, 2014 at 12:42 PM, Harbs <ha...@gmail.com> wrote:
>> I plan on spending some time early next week getting my head better wrapped around the tests.
>>
>> I committed the changes. Can you see what happens when you run the full tests?
>>
>> On Nov 27, 2014, at 12:15 PM, piotrz <pi...@gmail.com> wrote:
>>
>>> During my tests migration some of the test methods initially failed, so I
>>> have marked them as [Ignore] and decided back to them later. - That is the
>>> skipped tests.
>>>
>>> You can check details of errors in tests reports -
>>> flex-tlf/bin/apps/automation_apps/bin/
>>>
>>> Some of the tests are quite heavy, so it takes some time - try to wait
>>> longer.
>>>
>>> Piotr
>>>
>>>
>>>
>>> -----
>>> Apache Flex PMC
>>> piotrzarzycki21@gmail.com
>>> --
>>> View this message in context: http://apache-flex-development.2333347.n4.nabble.com/TLF-merge-tables-into-develop-tp42713p42793.html
>>> Sent from the Apache Flex Development mailing list archive at Nabble.com.
>>
>
>
>
> --
> Ix Multimedia Software
>
> Jan Luykenstraat 27
> 3521 VB Utrecht
>
> T. 06-51952295
> I. www.ixsoftware.nl
Re: [TLF] merge 'tables' into 'develop'
Posted by Erik de Bruin <er...@ixsoftware.nl>.
When I run 'ant all' with 'minimalTests = true' in build.properties, I
see 56 tests being run, with this as a result:
[flexunit] FlexUnit test atParagraphEnd in suite
UnitTest.Tests.FloatTest failed.
[flexunit] FlexUnit test contentWidthCheckLongFloat in suite
UnitTest.Tests.FloatTest was ignored.
...
[flexunit] Tests run: 56, Failures: 1, Errors: 0, Skipped: 1, Time
elapsed: 24.881 sec
Is that expected?
EdB
On Thu, Nov 27, 2014 at 12:42 PM, Harbs <ha...@gmail.com> wrote:
> I plan on spending some time early next week getting my head better wrapped around the tests.
>
> I committed the changes. Can you see what happens when you run the full tests?
>
> On Nov 27, 2014, at 12:15 PM, piotrz <pi...@gmail.com> wrote:
>
>> During my tests migration some of the test methods initially failed, so I
>> have marked them as [Ignore] and decided back to them later. - That is the
>> skipped tests.
>>
>> You can check details of errors in tests reports -
>> flex-tlf/bin/apps/automation_apps/bin/
>>
>> Some of the tests are quite heavy, so it takes some time - try to wait
>> longer.
>>
>> Piotr
>>
>>
>>
>> -----
>> Apache Flex PMC
>> piotrzarzycki21@gmail.com
>> --
>> View this message in context: http://apache-flex-development.2333347.n4.nabble.com/TLF-merge-tables-into-develop-tp42713p42793.html
>> Sent from the Apache Flex Development mailing list archive at Nabble.com.
>
--
Ix Multimedia Software
Jan Luykenstraat 27
3521 VB Utrecht
T. 06-51952295
I. www.ixsoftware.nl
Re: [TLF] merge 'tables' into 'develop'
Posted by Harbs <ha...@gmail.com>.
I plan on spending some time early next week getting my head better wrapped around the tests.
I committed the changes. Can you see what happens when you run the full tests?
On Nov 27, 2014, at 12:15 PM, piotrz <pi...@gmail.com> wrote:
> During my tests migration some of the test methods initially failed, so I
> have marked them as [Ignore] and decided back to them later. - That is the
> skipped tests.
>
> You can check details of errors in tests reports -
> flex-tlf/bin/apps/automation_apps/bin/
>
> Some of the tests are quite heavy, so it takes some time - try to wait
> longer.
>
> Piotr
>
>
>
> -----
> Apache Flex PMC
> piotrzarzycki21@gmail.com
> --
> View this message in context: http://apache-flex-development.2333347.n4.nabble.com/TLF-merge-tables-into-develop-tp42713p42793.html
> Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [TLF] merge 'tables' into 'develop'
Posted by piotrz <pi...@gmail.com>.
During my tests migration some of the test methods initially failed, so I
have marked them as [Ignore] and decided back to them later. - That is the
skipped tests.
You can check details of errors in tests reports -
flex-tlf/bin/apps/automation_apps/bin/
Some of the tests are quite heavy, so it takes some time - try to wait
longer.
Piotr
-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/TLF-merge-tables-into-develop-tp42713p42793.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [TLF] merge 'tables' into 'develop'
Posted by Harbs <ha...@gmail.com>.
I applied the latest changes to tables and I tried running the tests with minimalTests set to false.
I got lots of errors and the tests stalled at 340 or so. (I don’t remember the exact number.)
What makes “skipped” tests?
On Nov 27, 2014, at 10:23 AM, Harbs <ha...@gmail.com> wrote:
> Okay. I’ll do that. I think there’s a total of 12 commits that need to be applied.
>
> On Nov 27, 2014, at 9:54 AM, OmPrakash Muppirala <bi...@gmail.com> wrote:
>
>> On Nov 26, 2014 11:42 PM, "Harbs" <ha...@gmail.com> wrote:
>>>
>>> You can feel free to do the merge.
>>>
>>> I’ll switch to develop once you do.
>>
>> It would be a good idea to first merge develop into tables and make sure
>> everything compiles fine. And then merge tables into develop.
>>
>> Thanks,
>> Om
>>
>> Thanks,
>> Om
>>
>>>
>>> On Nov 27, 2014, at 8:34 AM, piotrz <pi...@gmail.com> wrote:
>>>
>>>> Erik, Harbs I've changed my mind and I think we shouldn't bother about
>> this
>>>> one failing test for now and merge everything into the develop branch.
>>>>
>>>> Harbs will you do this or do you want me to do this ?
>>>>
>>>> Piotr
>>>>
>>>>
>>>>
>>>> -----
>>>> Apache Flex PMC
>>>> piotrzarzycki21@gmail.com
>>>> --
>>>> View this message in context:
>> http://apache-flex-development.2333347.n4.nabble.com/TLF-merge-tables-into-develop-tp42713p42787.html
>>>> Sent from the Apache Flex Development mailing list archive at
>> Nabble.com.
>>>
>
Re: [TLF] merge 'tables' into 'develop'
Posted by Harbs <ha...@gmail.com>.
Okay. I’ll do that. I think there’s a total of 12 commits that need to be applied.
On Nov 27, 2014, at 9:54 AM, OmPrakash Muppirala <bi...@gmail.com> wrote:
> On Nov 26, 2014 11:42 PM, "Harbs" <ha...@gmail.com> wrote:
>>
>> You can feel free to do the merge.
>>
>> I’ll switch to develop once you do.
>
> It would be a good idea to first merge develop into tables and make sure
> everything compiles fine. And then merge tables into develop.
>
> Thanks,
> Om
>
> Thanks,
> Om
>
>>
>> On Nov 27, 2014, at 8:34 AM, piotrz <pi...@gmail.com> wrote:
>>
>>> Erik, Harbs I've changed my mind and I think we shouldn't bother about
> this
>>> one failing test for now and merge everything into the develop branch.
>>>
>>> Harbs will you do this or do you want me to do this ?
>>>
>>> Piotr
>>>
>>>
>>>
>>> -----
>>> Apache Flex PMC
>>> piotrzarzycki21@gmail.com
>>> --
>>> View this message in context:
> http://apache-flex-development.2333347.n4.nabble.com/TLF-merge-tables-into-develop-tp42713p42787.html
>>> Sent from the Apache Flex Development mailing list archive at
> Nabble.com.
>>
Re: [TLF] merge 'tables' into 'develop'
Posted by Erik de Bruin <er...@ixsoftware.nl>.
>> You can feel free to do the merge.
>>
>> I’ll switch to develop once you do.
>
> It would be a good idea to first merge develop into tables and make sure
> everything compiles fine. And then merge tables into develop.
That sounds like an excellent plan. Looking forward to the torrent of
commit emails ;-)
Thanks for this effort, guys!
EdB
--
Ix Multimedia Software
Jan Luykenstraat 27
3521 VB Utrecht
T. 06-51952295
I. www.ixsoftware.nl
Re: [TLF] merge 'tables' into 'develop'
Posted by OmPrakash Muppirala <bi...@gmail.com>.
On Nov 26, 2014 11:42 PM, "Harbs" <ha...@gmail.com> wrote:
>
> You can feel free to do the merge.
>
> I’ll switch to develop once you do.
It would be a good idea to first merge develop into tables and make sure
everything compiles fine. And then merge tables into develop.
Thanks,
Om
Thanks,
Om
>
> On Nov 27, 2014, at 8:34 AM, piotrz <pi...@gmail.com> wrote:
>
> > Erik, Harbs I've changed my mind and I think we shouldn't bother about
this
> > one failing test for now and merge everything into the develop branch.
> >
> > Harbs will you do this or do you want me to do this ?
> >
> > Piotr
> >
> >
> >
> > -----
> > Apache Flex PMC
> > piotrzarzycki21@gmail.com
> > --
> > View this message in context:
http://apache-flex-development.2333347.n4.nabble.com/TLF-merge-tables-into-develop-tp42713p42787.html
> > Sent from the Apache Flex Development mailing list archive at
Nabble.com.
>
Re: [TLF] merge 'tables' into 'develop'
Posted by Harbs <ha...@gmail.com>.
You can feel free to do the merge.
I’ll switch to develop once you do.
On Nov 27, 2014, at 8:34 AM, piotrz <pi...@gmail.com> wrote:
> Erik, Harbs I've changed my mind and I think we shouldn't bother about this
> one failing test for now and merge everything into the develop branch.
>
> Harbs will you do this or do you want me to do this ?
>
> Piotr
>
>
>
> -----
> Apache Flex PMC
> piotrzarzycki21@gmail.com
> --
> View this message in context: http://apache-flex-development.2333347.n4.nabble.com/TLF-merge-tables-into-develop-tp42713p42787.html
> Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [TLF] merge 'tables' into 'develop'
Posted by piotrz <pi...@gmail.com>.
Erik, Harbs I've changed my mind and I think we shouldn't bother about this
one failing test for now and merge everything into the develop branch.
Harbs will you do this or do you want me to do this ?
Piotr
-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/TLF-merge-tables-into-develop-tp42713p42787.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.