You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/04/07 06:04:01 UTC
[GitHub] [flink-kubernetes-operator] gyfora opened a new pull request, #159: [FLINK-27005][FLINK-27065] Bump api version + store last spec as string
gyfora opened a new pull request, #159:
URL: https://github.com/apache/flink-kubernetes-operator/pull/159
This PR contains two (related) changes:
1. Bump the CRD version to v1beta1 (without keeping the old one) and updating examples/docs related to this
2. Change the status field in the CRD to store the lastReconciledSpec in a JSON string form instead object.
You can see an example of the resulting status:
```
Status:
Job Manager Deployment Status: DEPLOYING
Job Status:
Savepoint Info:
State: UNKNOWN
Reconciliation Status:
Last Reconciled Spec: {
"image" : "flink:1.14",
"imagePullPolicy" : null,
"serviceAccount" : "flink",
"flinkVersion" : "v1_14",
"ingress" : null,
"flinkConfiguration" : {
"taskmanager.numberOfTaskSlots" : "2"
},
"podTemplate" : null,
"jobManager" : {
"resource" : {
"cpu" : 1.0,
"memory" : "2048m"
},
"replicas" : 1,
"podTemplate" : null
},
"taskManager" : {
"resource" : {
"cpu" : 1.0,
"memory" : "2048m"
},
"podTemplate" : null
},
"job" : {
"jarURI" : "local:///opt/flink/examples/streaming/StateMachineExample.jar",
"parallelism" : 2,
"entryClass" : null,
"args" : [ [],
"state" : "running",
"savepointTriggerNonce" : null,
"initialSavepointPath" : null,
"upgradeMode" : "stateless"
},
"restartNonce" : null,
"logConfiguration" : null
}
Success: true
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] gyfora merged pull request #159: [FLINK-27005][FLINK-27065] Bump api version + store last spec as string
Posted by GitBox <gi...@apache.org>.
gyfora merged PR #159:
URL: https://github.com/apache/flink-kubernetes-operator/pull/159
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #159: [FLINK-27005][FLINK-27065] Bump api version + store last spec as string
Posted by GitBox <gi...@apache.org>.
gyfora commented on PR #159:
URL: https://github.com/apache/flink-kubernetes-operator/pull/159#issuecomment-1092487022
@tweise that makes sense, I will try to see how to add the extra version field
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] tweise commented on pull request #159: [FLINK-27005][FLINK-27065] Bump api version + store last spec as string
Posted by GitBox <gi...@apache.org>.
tweise commented on PR #159:
URL: https://github.com/apache/flink-kubernetes-operator/pull/159#issuecomment-1092213172
@gyfora it might also be good to capture the version of the spec that is stored in "Last Reconciled Spec"? That way it would be possible to deserialize older status fields after incompatible spec changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #159: [FLINK-27005][FLINK-27065] Bump api version + store last spec as string
Posted by GitBox <gi...@apache.org>.
gyfora commented on PR #159:
URL: https://github.com/apache/flink-kubernetes-operator/pull/159#issuecomment-1094623760
Merging this, I think https://issues.apache.org/jira/browse/FLINK-26811 will cover the doc change :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] wangyang0918 commented on pull request #159: [FLINK-27005][FLINK-27065] Bump api version + store last spec as string
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on PR #159:
URL: https://github.com/apache/flink-kubernetes-operator/pull/159#issuecomment-1091620399
I will have a try on this PR later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #159: [FLINK-27005][FLINK-27065] Bump api version + store last spec as string
Posted by GitBox <gi...@apache.org>.
gyfora commented on PR #159:
URL: https://github.com/apache/flink-kubernetes-operator/pull/159#issuecomment-1091392102
> Hmm. I prefer to store the lastReconciledSpec without spaces, line break, etc. since we are showing a json in a yaml format.
>
> ```
> Last Reconciled Spec: {"image":"flink:1.14","imagePullPolicy":null,"serviceAccount":"flink","flinkVersion":"v1_14","ingress":null,"flinkConfiguration":{"taskmanager.numberOfTaskSlots":"2"},"podTemplate":null,"jobManager":{"resource":{"cpu":1,"memory":"2048m"},"replicas":1,"podTemplate":null},"taskManager":{"resource":{"cpu":1,"memory":"2048m"},"podTemplate":null},"job":{"jarURI":"local:///opt/flink/examples/streaming/StateMachineExample.jar","parallelism":2,"entryClass":null,"args":[],"state":"running","savepointTriggerNonce":null,"initialSavepointPath":null,"upgradeMode":"stateless"},"restartNonce":null,"logConfiguration":null}
> ```
@wangyang0918 taht would be trivial to change, I thought this looks better for the user to read but otherwise I dont have a strong preference
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] wangyang0918 commented on pull request #159: [FLINK-27005][FLINK-27065] Bump api version + store last spec as string
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on PR #159:
URL: https://github.com/apache/flink-kubernetes-operator/pull/159#issuecomment-1091349870
Hmm. I prefer to store the lastReconciledSpec without spaces, line break, etc. since we are showing a json in a yaml format.
```
Last Reconciled Spec: {"image":"flink:1.14","imagePullPolicy":null,"serviceAccount":"flink","flinkVersion":"v1_14","ingress":null,"flinkConfiguration":{"taskmanager.numberOfTaskSlots":"2"},"podTemplate":null,"jobManager":{"resource":{"cpu":1,"memory":"2048m"},"replicas":1,"podTemplate":null},"taskManager":{"resource":{"cpu":1,"memory":"2048m"},"podTemplate":null},"job":{"jarURI":"local:///opt/flink/examples/streaming/StateMachineExample.jar","parallelism":2,"entryClass":null,"args":[],"state":"running","savepointTriggerNonce":null,"initialSavepointPath":null,"upgradeMode":"stateless"},"restartNonce":null,"logConfiguration":null}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #159: [FLINK-27005][FLINK-27065] Bump api version + store last spec as string
Posted by GitBox <gi...@apache.org>.
gyfora commented on PR #159:
URL: https://github.com/apache/flink-kubernetes-operator/pull/159#issuecomment-1092713394
Updated the logic now it looks like this:
```
Last Reconciled Spec: {"image":"flink:1.14","imagePullPolicy":null,"serviceAccount":"flink","flinkVersion":"v1_14","ingress":null,"flinkConfiguration":{"taskmanager.numberOfTaskSlots":"2"},"podTemplate":null,"jobManager":{"resource":{"cpu":1.0,"memory":"2048m"},"replicas":1,"podTemplate":null},"taskManager":{"resource":{"cpu":1.0,"memory":"2048m"},"podTemplate":null},"job":{"jarURI":"local:///opt/flink/examples/streaming/StateMachineExample.jar","parallelism":2,"entryClass":null,"args":[],"state":"running","savepointTriggerNonce":null,"initialSavepointPath":null,"upgradeMode":"stateless"},"restartNonce":null,"logConfiguration":null,"apiVersion":"v1beta1"}
```
Note the extra `apiVersion` field at the end.
@wangyang0918 @tweise PTAL again :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org