You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/09/13 10:57:10 UTC
[GitHub] [spark] yoda-mon opened a new pull request #33979: [SPARK-36739][DOCS][PYTHON] Add apache license headers to makefiles
yoda-mon opened a new pull request #33979:
URL: https://github.com/apache/spark/pull/33979
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Add apache license headers to makefiles of PySpark documents.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Makefiles of PySpark documentations do not have apache license headers, while the other files have.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
`make html`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33979: [SPARK-36739][DOCS][PYTHON] Add apache license headers to makefiles
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33979:
URL: https://github.com/apache/spark/pull/33979#issuecomment-918219069
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47709/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33979: [SPARK-36739][DOCS][PYTHON] Add apache license headers to makefiles
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33979:
URL: https://github.com/apache/spark/pull/33979#issuecomment-918120280
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47705/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #33979: [SPARK-36739][DOCS][PYTHON] Add apache license headers to makefiles
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #33979:
URL: https://github.com/apache/spark/pull/33979#issuecomment-918694161
@holdenk
> Since this is a missing license issue is it a blocker?
Yeah, I think so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #33979: [SPARK-36739][DOCS][PYTHON] Add apache license headers to makefiles
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #33979:
URL: https://github.com/apache/spark/pull/33979#issuecomment-918163910
retest this please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33979: [SPARK-36739][DOCS][PYTHON] Add apache license headers to makefiles
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33979:
URL: https://github.com/apache/spark/pull/33979#issuecomment-918168987
**[Test build #143209 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143209/testReport)** for PR 33979 at commit [`51ad83f`](https://github.com/apache/spark/commit/51ad83fe15129662f8c67507fed2ab793c97c001).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33979: [SPARK-36739][DOCS][PYTHON] Add apache license headers to makefiles
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33979:
URL: https://github.com/apache/spark/pull/33979#issuecomment-918168987
**[Test build #143209 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143209/testReport)** for PR 33979 at commit [`51ad83f`](https://github.com/apache/spark/commit/51ad83fe15129662f8c67507fed2ab793c97c001).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #33979: [SPARK-36739][DOCS][PYTHON] Add apache license headers to makefiles
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #33979:
URL: https://github.com/apache/spark/pull/33979#issuecomment-918685023
Merged to master and branch-3.2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33979: [SPARK-36739][DOCS][PYTHON] Add apache license headers to makefiles
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33979:
URL: https://github.com/apache/spark/pull/33979#issuecomment-918085161
**[Test build #143203 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143203/testReport)** for PR 33979 at commit [`51ad83f`](https://github.com/apache/spark/commit/51ad83fe15129662f8c67507fed2ab793c97c001).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33979: [SPARK-36739][DOCS][PYTHON] Add apache license headers to makefiles
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33979:
URL: https://github.com/apache/spark/pull/33979#issuecomment-918077147
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33979: [SPARK-36739][DOCS][PYTHON] Add apache license headers to makefiles
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33979:
URL: https://github.com/apache/spark/pull/33979#issuecomment-918114272
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47705/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #33979: [SPARK-36739][DOCS][PYTHON] Add apache license headers to makefiles
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #33979:
URL: https://github.com/apache/spark/pull/33979#issuecomment-918286059
@yoda-mon You changed `bat` files so it's better to ensure that we can successfully build the docs on Windows. Did you confirm that?
If so, could you note in the description that you confirmed `make html` on both Linux and Windows?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33979: [SPARK-36739][DOCS][PYTHON] Add apache license headers to makefiles
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33979:
URL: https://github.com/apache/spark/pull/33979#issuecomment-918108026
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143203/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33979: [SPARK-36739][DOCS][PYTHON] Add apache license headers to makefiles
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33979:
URL: https://github.com/apache/spark/pull/33979#issuecomment-918202890
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143209/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33979: [SPARK-36739][DOCS][PYTHON] Add apache license headers to makefiles
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33979:
URL: https://github.com/apache/spark/pull/33979#issuecomment-918077147
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33979: [SPARK-36739][DOCS][PYTHON] Add apache license headers to makefiles
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33979:
URL: https://github.com/apache/spark/pull/33979#issuecomment-918099986
**[Test build #143203 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143203/testReport)** for PR 33979 at commit [`51ad83f`](https://github.com/apache/spark/commit/51ad83fe15129662f8c67507fed2ab793c97c001).
* This patch **fails PySpark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #33979: [SPARK-36739][DOCS][PYTHON] Add apache license headers to makefiles
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #33979:
URL: https://github.com/apache/spark/pull/33979#issuecomment-918081009
ok to test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33979: [SPARK-36739][DOCS][PYTHON] Add apache license headers to makefiles
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33979:
URL: https://github.com/apache/spark/pull/33979#issuecomment-918228696
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47709/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33979: [SPARK-36739][DOCS][PYTHON] Add apache license headers to makefiles
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33979:
URL: https://github.com/apache/spark/pull/33979#issuecomment-918205661
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yoda-mon commented on pull request #33979: [SPARK-36739][DOCS][PYTHON] Add apache license headers to makefiles
Posted by GitBox <gi...@apache.org>.
yoda-mon commented on pull request #33979:
URL: https://github.com/apache/spark/pull/33979#issuecomment-918842437
> @yoda-mon You changed `bat` files so it's better to ensure that we can successfully build the docs on Windows. Did you confirm that?
> If so, could you note in the description that you confirmed `make html` on both Linux and Windows?
I did both of them, so I will change the discription like `make html` on boh Linux and Windows. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon edited a comment on pull request #33979: [SPARK-36739][DOCS][PYTHON] Add apache license headers to makefiles
Posted by GitBox <gi...@apache.org>.
HyukjinKwon edited a comment on pull request #33979:
URL: https://github.com/apache/spark/pull/33979#issuecomment-918948863
Oops, I just noticed that I merged it without seeing the comment above https://github.com/apache/spark/pull/33979#issuecomment-918694161. Good that the comment was addressed after the merge though 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33979: [SPARK-36739][DOCS][PYTHON] Add apache license headers to makefiles
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33979:
URL: https://github.com/apache/spark/pull/33979#issuecomment-918202890
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143209/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yoda-mon commented on a change in pull request #33979: [SPARK-36739][DOCS][PYTHON] Add apache license headers to makefiles
Posted by GitBox <gi...@apache.org>.
yoda-mon commented on a change in pull request #33979:
URL: https://github.com/apache/spark/pull/33979#discussion_r707228138
##########
File path: python/docs/make2.bat
##########
@@ -1,6 +1,23 @@
-@ECHO OFF
-
-REM Command file for Sphinx documentation
+@echo off
+
Review comment:
`spark/bin/pyspark.cmd` uses lower case, so I follow it here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33979: [SPARK-36739][DOCS][PYTHON] Add apache license headers to makefiles
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33979:
URL: https://github.com/apache/spark/pull/33979#issuecomment-918085161
**[Test build #143203 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143203/testReport)** for PR 33979 at commit [`51ad83f`](https://github.com/apache/spark/commit/51ad83fe15129662f8c67507fed2ab793c97c001).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #33979: [SPARK-36739][DOCS][PYTHON] Add apache license headers to makefiles
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #33979:
URL: https://github.com/apache/spark/pull/33979#issuecomment-918948863
Oops, I just noticed that I merged it without seeing https://github.com/apache/spark/pull/33979?fbclid=IwAR3NKZV5NQsSJwXRSwFgJZodP-1uIqF4oKw3L5mxL9Xn7OS7RhfHUKNTAOY#issuecomment-918286059. Good that the comment was addressed after the merge though 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33979: [SPARK-36739][DOCS][PYTHON] Add apache license headers to makefiles
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33979:
URL: https://github.com/apache/spark/pull/33979#issuecomment-918108026
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143203/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33979: [SPARK-36739][DOCS][PYTHON] Add apache license headers to makefiles
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33979:
URL: https://github.com/apache/spark/pull/33979#issuecomment-918205661
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33979: [SPARK-36739][DOCS][PYTHON] Add apache license headers to makefiles
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33979:
URL: https://github.com/apache/spark/pull/33979#issuecomment-918120233
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47705/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33979: [SPARK-36739][DOCS][PYTHON] Add apache license headers to makefiles
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33979:
URL: https://github.com/apache/spark/pull/33979#issuecomment-918228636
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47709/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33979: [SPARK-36739][DOCS][PYTHON] Add apache license headers to makefiles
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33979:
URL: https://github.com/apache/spark/pull/33979#issuecomment-918120280
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47705/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yoda-mon commented on a change in pull request #33979: [SPARK-36739][DOCS][PYTHON] Add apache license headers to makefiles
Posted by GitBox <gi...@apache.org>.
yoda-mon commented on a change in pull request #33979:
URL: https://github.com/apache/spark/pull/33979#discussion_r707227708
##########
File path: python/docs/make.bat
##########
@@ -1,4 +1,21 @@
-@ECHO OFF
+@echo off
+
Review comment:
`spark/bin/pyspark.cmd` uses lower case, so I follow it here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33979: [SPARK-36739][DOCS][PYTHON] Add apache license headers to makefiles
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33979:
URL: https://github.com/apache/spark/pull/33979#issuecomment-918665547
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #33979: [SPARK-36739][DOCS][PYTHON] Add apache license headers to makefiles
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #33979:
URL: https://github.com/apache/spark/pull/33979
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] holdenk commented on pull request #33979: [SPARK-36739][DOCS][PYTHON] Add apache license headers to makefiles
Posted by GitBox <gi...@apache.org>.
holdenk commented on pull request #33979:
URL: https://github.com/apache/spark/pull/33979#issuecomment-918512845
Since this is a missing license issue is it a blocker?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon edited a comment on pull request #33979: [SPARK-36739][DOCS][PYTHON] Add apache license headers to makefiles
Posted by GitBox <gi...@apache.org>.
HyukjinKwon edited a comment on pull request #33979:
URL: https://github.com/apache/spark/pull/33979#issuecomment-918948863
Oops, I just noticed that I merged it without seeing the comment above https://github.com/apache/spark/pull/33979#issuecomment-918286059. Good that the comment was addressed after the merge though 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33979: [SPARK-36739][DOCS][PYTHON] Add apache license headers to makefiles
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33979:
URL: https://github.com/apache/spark/pull/33979#issuecomment-918228696
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47709/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33979: [SPARK-36739][DOCS][PYTHON] Add apache license headers to makefiles
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33979:
URL: https://github.com/apache/spark/pull/33979#issuecomment-918199668
**[Test build #143209 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143209/testReport)** for PR 33979 at commit [`51ad83f`](https://github.com/apache/spark/commit/51ad83fe15129662f8c67507fed2ab793c97c001).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org