You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@superset.apache.org by gi...@git.apache.org on 2017/10/14 05:48:42 UTC

[GitHub] graceguo-supercat commented on issue #3498: Add check_ownership call in save_or_overwrite_slice

graceguo-supercat commented on issue #3498: Add check_ownership call in save_or_overwrite_slice
URL: https://github.com/apache/incubator-superset/issues/3498#issuecomment-336612331
 
 
   @jaylindquist check these lines
   `slice_add_perm = self.can_access('can_add', 'SliceModelView')`
   `slice_overwrite_perm = is_owner(slc, g.user)`
   `slice_download_perm = self.can_access('can_download', 'SliceModelView')`
   ...
   `        if action == 'overwrite' and not slice_overwrite_perm:`
   `            return json_error_response("You don't have the rights to alter this slice", status=400)`
   
   
   we checked all permissions and passing down to `self.save_or_overwrite_slice`. is it a good permission check?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services