You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/10/20 10:48:12 UTC
[GitHub] [doris] yixiutt opened a new pull request, #13522: [enhancement](publish) add publish version cost
yixiutt opened a new pull request, #13522:
URL: https://github.com/apache/doris/pull/13522
# Proposed changes
Issue Number: close #xxx
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #13522: [improvement](publish) add publish version cost
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13522:
URL: https://github.com/apache/doris/pull/13522#issuecomment-1286007089
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei commented on a diff in pull request #13522: [improvement](publish) add publish version cost
Posted by GitBox <gi...@apache.org>.
yiguolei commented on code in PR #13522:
URL: https://github.com/apache/doris/pull/13522#discussion_r1001583168
##########
be/src/olap/storage_engine.cpp:
##########
@@ -1026,38 +1026,8 @@ void StorageEngine::notify_listeners() {
}
Status StorageEngine::execute_task(EngineTask* task) {
- auto lock_related_tablets = [&]() -> std::vector<std::unique_lock<std::shared_mutex>> {
- // add write lock to all related tablets
Review Comment:
task execute will modify tablet's meta, so that I think we should acquire lock here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #13522: [improvement](publish) add publish version cost
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #13522:
URL: https://github.com/apache/doris/pull/13522#issuecomment-1285900777
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 40.71 seconds
load time: 595 seconds
storage size: 17154823301 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221021012154_clickbench_pr_32145.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #13522: [improvement](publish) add publish version cost
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13522:
URL: https://github.com/apache/doris/pull/13522#issuecomment-1286007046
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zhannngchen commented on pull request #13522: [improvement](publish) add publish version cost
Posted by GitBox <gi...@apache.org>.
zhannngchen commented on PR #13522:
URL: https://github.com/apache/doris/pull/13522#issuecomment-1285704344
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #13522: [improvement](publish) add publish version cost
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #13522:
URL: https://github.com/apache/doris/pull/13522#issuecomment-1286398678
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 41.33 seconds
load time: 598 seconds
storage size: 17154823389 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221021110639_clickbench_pr_32296.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yixiutt commented on a diff in pull request #13522: [improvement](publish) add publish version cost
Posted by GitBox <gi...@apache.org>.
yixiutt commented on code in PR #13522:
URL: https://github.com/apache/doris/pull/13522#discussion_r1001588589
##########
be/src/olap/storage_engine.cpp:
##########
@@ -1026,38 +1026,8 @@ void StorageEngine::notify_listeners() {
}
Status StorageEngine::execute_task(EngineTask* task) {
- auto lock_related_tablets = [&]() -> std::vector<std::unique_lock<std::shared_mutex>> {
- // add write lock to all related tablets
Review Comment:
No engine task has implement get_related_tablets() so it will always return empty, so no locks will acquire here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #13522: [improvement](publish) add publish version cost
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #13522:
URL: https://github.com/apache/doris/pull/13522#issuecomment-1286482964
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 41.89 seconds
load time: 671 seconds
storage size: 17154823173 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221021053526_clickbench_pr_32363.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #13522: [improvement](publish) add publish version cost
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #13522:
URL: https://github.com/apache/doris/pull/13522
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #13522: [improvement](publish) add publish version cost
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13522:
URL: https://github.com/apache/doris/pull/13522#issuecomment-1286504095
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org