You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@plc4x.apache.org by cd...@apache.org on 2019/02/03 16:38:46 UTC
[incubator-plc4x] branch develop updated (c212f77 -> e920496)
This is an automated email from the ASF dual-hosted git repository.
cdutz pushed a change to branch develop
in repository https://gitbox.apache.org/repos/asf/incubator-plc4x.git.
from c212f77 - Added a first poc on a purely xml dynamic plc4x driver
new 54b9f9c - Fixed some sonarqube findings
new e920496 - Enabled the sandbox profile for the develop branch build.
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
Jenkinsfile | 2 +-
.../apache/plc4x/examples/robot/controllers/RobotController.java | 8 ++++++--
2 files changed, 7 insertions(+), 3 deletions(-)
[incubator-plc4x] 01/02: - Fixed some sonarqube findings
Posted by cd...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
cdutz pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/incubator-plc4x.git
commit 54b9f9c0c86e190a053694228799f0c703df941d
Author: Christofer Dutz <ch...@c-ware.de>
AuthorDate: Sun Feb 3 17:05:47 2019 +0100
- Fixed some sonarqube findings
---
.../apache/plc4x/examples/robot/controllers/RobotController.java | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/examples/hello-webapp/service/src/main/java/org/apache/plc4x/examples/robot/controllers/RobotController.java b/examples/hello-webapp/service/src/main/java/org/apache/plc4x/examples/robot/controllers/RobotController.java
index 9fe5194..0ff47c3 100644
--- a/examples/hello-webapp/service/src/main/java/org/apache/plc4x/examples/robot/controllers/RobotController.java
+++ b/examples/hello-webapp/service/src/main/java/org/apache/plc4x/examples/robot/controllers/RobotController.java
@@ -23,6 +23,8 @@ import org.apache.plc4x.java.PlcDriverManager;
import org.apache.plc4x.java.api.PlcConnection;
import org.apache.plc4x.java.api.exceptions.PlcConnectionException;
import org.apache.plc4x.java.api.messages.PlcWriteRequest;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
import org.springframework.beans.factory.annotation.Value;
import org.springframework.web.bind.annotation.RequestMapping;
import org.springframework.web.bind.annotation.RequestParam;
@@ -37,6 +39,8 @@ import java.util.concurrent.TimeoutException;
@RequestMapping("api/robot")
public class RobotController {
+ private static final Logger logger = LoggerFactory.getLogger(RobotController.class);
+
private static byte MOTOR_RIGHT_BACKWARDS = 0x01;
private static byte MOTOR_RIGHT_ON = 0x02;
private static byte MOTOR_LEFT_BACKWARDS = 0x04;
@@ -57,7 +61,7 @@ public class RobotController {
@RequestMapping("move")
public boolean move(@RequestParam(value="direction", defaultValue="stop") String direction) {
- System.out.println("Move in direction: " + direction);
+ logger.info("Move in direction: " + direction);
byte state = 0;
switch (direction) {
case "forward-right":
@@ -90,7 +94,7 @@ public class RobotController {
updateRequest.execute().get(2000, TimeUnit.MILLISECONDS);
return true;
} catch (InterruptedException | ExecutionException | TimeoutException e) {
- e.printStackTrace();
+ logger.error("Caught Exception:", e);
return false;
}
}
[incubator-plc4x] 02/02: - Enabled the sandbox profile for the
develop branch build.
Posted by cd...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
cdutz pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/incubator-plc4x.git
commit e92049681ceafb7a987dcaa872638eeee16f81ab
Author: Christofer Dutz <ch...@c-ware.de>
AuthorDate: Sun Feb 3 17:06:22 2019 +0100
- Enabled the sandbox profile for the develop branch build.
---
Jenkinsfile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Jenkinsfile b/Jenkinsfile
index c3b76ce..6cc4977 100644
--- a/Jenkinsfile
+++ b/Jenkinsfile
@@ -107,7 +107,7 @@ pipeline {
// We'll deploy to a relative directory so we can save
// that and deploy in a later step on a different node
- sh 'mvn -P${JENKINS_PROFILE},development ${MVN_TEST_FAIL_IGNORE} ${JQASSISTANT_NEO4J_VERSION} -DaltDeploymentRepository=snapshot-repo::default::file:./local-snapshots-dir clean deploy'
+ sh 'mvn -P${JENKINS_PROFILE},development,with-sandbox ${MVN_TEST_FAIL_IGNORE} ${JQASSISTANT_NEO4J_VERSION} -DaltDeploymentRepository=snapshot-repo::default::file:./local-snapshots-dir clean deploy'
// Stash the build results so we can deploy them on another node
stash name: 'plc4x-build-snapshots', includes: 'local-snapshots-dir/**'