You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2017/06/28 18:27:17 UTC
[kudu-CR] [java] excluded slf4j from async dependency
Grant Henke has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7320
Change subject: [java] excluded slf4j from async dependency
......................................................................
[java] excluded slf4j from async dependency
The slf4j-api dependency defined by async uses a range-based version. This change excludes that dependency in order to ensure re-producible builds regardless of what slf4j-api versions are available.
Change-Id: Ia557729ef50b3736a53224bae64663652aeb0722
---
M java/kudu-client/pom.xml
M java/kudu-mapreduce/pom.xml
2 files changed, 16 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/20/7320/1
--
To view, visit http://gerrit.cloudera.org:8080/7320
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia557729ef50b3736a53224bae64663652aeb0722
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke <gr...@gmail.com>
[kudu-CR] [java] excluded slf4j from async dependency
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: [java] excluded slf4j from async dependency
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7320
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia557729ef50b3736a53224bae64663652aeb0722
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [java] excluded slf4j from async dependency
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Todd Lipcon, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7320
to look at the new patch set (#2).
Change subject: [java] excluded slf4j from async dependency
......................................................................
[java] excluded slf4j from async dependency
The slf4j-api dependency defined by async uses a
range-based version. This change excludes that dependency
in order to ensure re-producible builds regardless of what
slf4j-api versions are available.
Change-Id: Ia557729ef50b3736a53224bae64663652aeb0722
---
M java/kudu-client/pom.xml
M java/kudu-mapreduce/pom.xml
2 files changed, 16 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/20/7320/2
--
To view, visit http://gerrit.cloudera.org:8080/7320
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia557729ef50b3736a53224bae64663652aeb0722
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [java] excluded slf4j from async dependency
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged.
Change subject: [java] excluded slf4j from async dependency
......................................................................
[java] excluded slf4j from async dependency
The slf4j-api dependency defined by async uses a
range-based version. This change excludes that dependency
in order to ensure re-producible builds regardless of what
slf4j-api versions are available.
Change-Id: Ia557729ef50b3736a53224bae64663652aeb0722
Reviewed-on: http://gerrit.cloudera.org:8080/7320
Reviewed-by: Dan Burkert <da...@apache.org>
Tested-by: Dan Burkert <da...@apache.org>
---
M java/kudu-client/pom.xml
M java/kudu-mapreduce/pom.xml
2 files changed, 16 insertions(+), 0 deletions(-)
Approvals:
Dan Burkert: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/7320
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia557729ef50b3736a53224bae64663652aeb0722
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [java] excluded slf4j from async dependency
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change.
Change subject: [java] excluded slf4j from async dependency
......................................................................
Patch Set 2:
I don't have any formal write up on version ranges advice. But essentially the advice is that though ranges may be useful during development, the released version used should be static. Since async uses the version range '[1.6.0,)' for slf4j, each time a build is run a new version of slf4j could be pulled in. If slf4j in the future makes a breaking change, there is no way to prevent it from being pulled into current or old builds.
The maven docs on version ranges are here: http://maven.apache.org/enforcer/enforcer-rules/versionRanges.html
--
To view, visit http://gerrit.cloudera.org:8080/7320
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia557729ef50b3736a53224bae64663652aeb0722
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [java] excluded slf4j from async dependency
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: [java] excluded slf4j from async dependency
......................................................................
Patch Set 2:
Seems find to me, but I don't really understand the effect of version ranges in Maven. Is there something I should read up on regarding transitive version ranges?
--
To view, visit http://gerrit.cloudera.org:8080/7320
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia557729ef50b3736a53224bae64663652aeb0722
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [java] excluded slf4j from async dependency
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: [java] excluded slf4j from async dependency
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7320/1//COMMIT_MSG
Commit Message:
Line 9: The slf4j-api dependency defined by async uses a range-based version. This change excludes that dependency in order to ensure re-producible builds regardless of what slf4j-api versions are available.
nit: please wrap
--
To view, visit http://gerrit.cloudera.org:8080/7320
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia557729ef50b3736a53224bae64663652aeb0722
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [java] excluded slf4j from async dependency
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: [java] excluded slf4j from async dependency
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7320
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia557729ef50b3736a53224bae64663652aeb0722
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No