You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Qifan Chen (Code Review)" <ge...@cloudera.org> on 2021/02/23 19:19:24 UTC
[Impala-ASF-CR] IMPALA-10532 TestOverlapMinMaxFilters.test overlap min max filters seems flaky
Qifan Chen has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17111
Change subject: IMPALA-10532 TestOverlapMinMaxFilters.test_overlap_min_max_filters seems flaky
......................................................................
IMPALA-10532 TestOverlapMinMaxFilters.test_overlap_min_max_filters seems flaky
This patch addresses the flakyness seen with a particular test within
overlap_min_max_filters by allowing the sum of NumRuntimeFilteredPages
to be greater than a value. Previously, such a sum can only be equal to
an expected value and is not sufficient for various test conditions in
which the scan of the parquet data files can start before the arrival
of a runtime filter.
The extension to test_result_verifier.py allows '>' and '<' condition
to be expressed for aggregation(SUM, <counter>), such as
aggregation(SUM, NumRuntimeFilteredPages)> 80.
Testing:
- Ran TestOverlapMinMaxFilters.
Change-Id: I93940a104bfb2d68cb1d41d7e303348190fd5972
---
M testdata/workloads/functional-query/queries/QueryTest/overlap_min_max_filters.test
M tests/common/test_result_verifier.py
2 files changed, 31 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/11/17111/1
--
To view, visit http://gerrit.cloudera.org:8080/17111
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I93940a104bfb2d68cb1d41d7e303348190fd5972
Gerrit-Change-Number: 17111
Gerrit-PatchSet: 1
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
[Impala-ASF-CR] IMPALA-10532 TestOverlapMinMaxFilters.test overlap min max filters seems flaky
Posted by "Qifan Chen (Code Review)" <ge...@cloudera.org>.
Qifan Chen has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/17111 )
Change subject: IMPALA-10532 TestOverlapMinMaxFilters.test_overlap_min_max_filters seems flaky
......................................................................
IMPALA-10532 TestOverlapMinMaxFilters.test_overlap_min_max_filters seems flaky
This patch addresses the flakiness seen with a particular test within
overlap_min_max_filters by allowing the sum of NumRuntimeFilteredPages
to be greater than an expected value. Previously, such a sum can only
be equal to the expected value and is not sufficient for various test
conditions in which the scan of the parquet data files can start
before the arrival of a runtime filter.
The extension in test_result_verifier.py allows '>' and '<' condition
to be expressed for aggregation(SUM, <counter>), such as
aggregation(SUM, NumRuntimeFilteredPages)> 80.
Testing:
- Ran TestOverlapMinMaxFilters.
Change-Id: I93940a104bfb2d68cb1d41d7e303348190fd5972
---
M testdata/workloads/functional-query/queries/QueryTest/overlap_min_max_filters.test
M tests/common/test_result_verifier.py
2 files changed, 32 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/11/17111/3
--
To view, visit http://gerrit.cloudera.org:8080/17111
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I93940a104bfb2d68cb1d41d7e303348190fd5972
Gerrit-Change-Number: 17111
Gerrit-PatchSet: 3
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-10532 TestOverlapMinMaxFilters.test overlap min max filters seems flaky
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17111 )
Change subject: IMPALA-10532 TestOverlapMinMaxFilters.test_overlap_min_max_filters seems flaky
......................................................................
Patch Set 5:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/8238/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17111
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93940a104bfb2d68cb1d41d7e303348190fd5972
Gerrit-Change-Number: 17111
Gerrit-PatchSet: 5
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Feb 2021 14:36:52 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10532 TestOverlapMinMaxFilters.test overlap min max filters seems flaky
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17111 )
Change subject: IMPALA-10532 TestOverlapMinMaxFilters.test_overlap_min_max_filters seems flaky
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/8206/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17111
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93940a104bfb2d68cb1d41d7e303348190fd5972
Gerrit-Change-Number: 17111
Gerrit-PatchSet: 2
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Feb 2021 19:51:17 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10532 TestOverlapMinMaxFilters.test overlap min max filters seems flaky
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/17111 )
Change subject: IMPALA-10532 TestOverlapMinMaxFilters.test_overlap_min_max_filters seems flaky
......................................................................
Patch Set 5: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/17111/5/testdata/workloads/functional-query/queries/QueryTest/overlap_min_max_filters.test
File testdata/workloads/functional-query/queries/QueryTest/overlap_min_max_filters.test:
http://gerrit.cloudera.org:8080/#/c/17111/5/testdata/workloads/functional-query/queries/QueryTest/overlap_min_max_filters.test@9
PS5, Line 9: CREATE TABLE tpch_parquet.lineitem_orderkey_only(l_orderkey bigint)
I see there are already other instances like this in this file, so I guess its fine to leave as is, but I wanted to note that I think a better way of doing this rather than creating the table in the tpch_parquet database (which potentially leaves it in a weird state if one of the test cases before the "drop table" below fails), would be to use the 'unique_database' functionality and create the table there, which would guarantee that its always dropped even if an error is encountered.
--
To view, visit http://gerrit.cloudera.org:8080/17111
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93940a104bfb2d68cb1d41d7e303348190fd5972
Gerrit-Change-Number: 17111
Gerrit-PatchSet: 5
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Feb 2021 21:21:25 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10532 TestOverlapMinMaxFilters.test overlap min max filters seems flaky
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17111 )
Change subject: IMPALA-10532 TestOverlapMinMaxFilters.test_overlap_min_max_filters seems flaky
......................................................................
IMPALA-10532 TestOverlapMinMaxFilters.test_overlap_min_max_filters seems flaky
This patch addresses the flakiness seen with a particular test within
overlap_min_max_filters by allowing the sum of NumRuntimeFilteredPages
to be greater than an expected value. Previously, such a sum can only
be equal to the expected value and is not sufficient for various test
conditions in which the scan of the parquet data files can start
before the arrival of a runtime filter.
The extension in test_result_verifier.py allows '>' and '<' condition
to be expressed for aggregation(SUM, <counter>), such as
aggregation(SUM, NumRuntimeFilteredPages)> 80.
Testing:
- Ran TestOverlapMinMaxFilters.
Change-Id: I93940a104bfb2d68cb1d41d7e303348190fd5972
Reviewed-on: http://gerrit.cloudera.org:8080/17111
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M testdata/workloads/functional-query/queries/QueryTest/overlap_min_max_filters.test
M tests/common/test_result_verifier.py
2 files changed, 52 insertions(+), 13 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/17111
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I93940a104bfb2d68cb1d41d7e303348190fd5972
Gerrit-Change-Number: 17111
Gerrit-PatchSet: 7
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[Impala-ASF-CR] IMPALA-10532 TestOverlapMinMaxFilters.test overlap min max filters seems flaky
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17111 )
Change subject: IMPALA-10532 TestOverlapMinMaxFilters.test_overlap_min_max_filters seems flaky
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/8209/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17111
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93940a104bfb2d68cb1d41d7e303348190fd5972
Gerrit-Change-Number: 17111
Gerrit-PatchSet: 4
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Feb 2021 20:09:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10532 TestOverlapMinMaxFilters.test overlap min max filters seems flaky
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17111 )
Change subject: IMPALA-10532 TestOverlapMinMaxFilters.test_overlap_min_max_filters seems flaky
......................................................................
Patch Set 6:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6923/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/17111
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93940a104bfb2d68cb1d41d7e303348190fd5972
Gerrit-Change-Number: 17111
Gerrit-PatchSet: 6
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 26 Feb 2021 17:07:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10532 TestOverlapMinMaxFilters.test overlap min max filters seems flaky
Posted by "Qifan Chen (Code Review)" <ge...@cloudera.org>.
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17111 )
Change subject: IMPALA-10532 TestOverlapMinMaxFilters.test_overlap_min_max_filters seems flaky
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/17111/4/testdata/workloads/functional-query/queries/QueryTest/overlap_min_max_filters.test
File testdata/workloads/functional-query/queries/QueryTest/overlap_min_max_filters.test:
http://gerrit.cloudera.org:8080/#/c/17111/4/testdata/workloads/functional-query/queries/QueryTest/overlap_min_max_filters.test@34
PS4, Line 34: 80
> How was this lower bound determined? What happens if things are really slow
It was based on several error reports where the total number of pages filtered is in the high 80s (https://master-02.jenkins.cloudera.com/job/impala-asf-master-exhaustive-release/1049/testReport/junit/query_test.test_runtime_filters/TestOverlapMinMaxFilters/test_overlap_min_max_filters_protocol__beeswax___exec_option____batch_size___0___num_nodes___0___disable_codegen_rows_threshold___0___disable_codegen___True___abort_on_error___1___exec_single_node_rows_threshold___0____table_format__parquet_none_/).
In my R&D box, the total is over 90.
The total number of pages in the two tables remains the same, across these two testing environment.
Since the scanner starts the process without waiting for the arrival of filters, this un-determinedness is always there.
Setting a value at 80 provides a pretty reasonable lower bound, IMHO :-).
--
To view, visit http://gerrit.cloudera.org:8080/17111
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93940a104bfb2d68cb1d41d7e303348190fd5972
Gerrit-Change-Number: 17111
Gerrit-PatchSet: 4
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Feb 2021 20:34:39 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10532 TestOverlapMinMaxFilters.test overlap min max filters seems flaky
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17111 )
Change subject: IMPALA-10532 TestOverlapMinMaxFilters.test_overlap_min_max_filters seems flaky
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/17111/1/tests/common/test_result_verifier.py
File tests/common/test_result_verifier.py:
http://gerrit.cloudera.org:8080/#/c/17111/1/tests/common/test_result_verifier.py@540
PS1, Line 540: 0
flake8: E501 line too long (92 > 90 characters)
--
To view, visit http://gerrit.cloudera.org:8080/17111
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93940a104bfb2d68cb1d41d7e303348190fd5972
Gerrit-Change-Number: 17111
Gerrit-PatchSet: 1
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Feb 2021 19:20:32 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10532 TestOverlapMinMaxFilters.test overlap min max filters seems flaky
Posted by "Qifan Chen (Code Review)" <ge...@cloudera.org>.
Qifan Chen has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/17111 )
Change subject: IMPALA-10532 TestOverlapMinMaxFilters.test_overlap_min_max_filters seems flaky
......................................................................
IMPALA-10532 TestOverlapMinMaxFilters.test_overlap_min_max_filters seems flaky
This patch addresses the flakiness seen with a particular test within
overlap_min_max_filters by allowing the sum of NumRuntimeFilteredPages
to be greater than an expected value. Previously, such a sum can only
be equal to the expected value and is not sufficient for various test
conditions in which the scan of the parquet data files can start
before the arrival of a runtime filter.
The extension in test_result_verifier.py allows '>' and '<' condition
to be expressed for aggregation(SUM, <counter>), such as
aggregation(SUM, NumRuntimeFilteredPages)> 80.
Testing:
- Ran TestOverlapMinMaxFilters.
Change-Id: I93940a104bfb2d68cb1d41d7e303348190fd5972
---
M testdata/workloads/functional-query/queries/QueryTest/overlap_min_max_filters.test
M tests/common/test_result_verifier.py
2 files changed, 31 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/11/17111/2
--
To view, visit http://gerrit.cloudera.org:8080/17111
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I93940a104bfb2d68cb1d41d7e303348190fd5972
Gerrit-Change-Number: 17111
Gerrit-PatchSet: 2
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-10532 TestOverlapMinMaxFilters.test overlap min max filters seems flaky
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17111 )
Change subject: IMPALA-10532 TestOverlapMinMaxFilters.test_overlap_min_max_filters seems flaky
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/8207/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17111
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93940a104bfb2d68cb1d41d7e303348190fd5972
Gerrit-Change-Number: 17111
Gerrit-PatchSet: 3
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Feb 2021 19:55:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10532 TestOverlapMinMaxFilters.test overlap min max filters seems flaky
Posted by "Qifan Chen (Code Review)" <ge...@cloudera.org>.
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17111 )
Change subject: IMPALA-10532 TestOverlapMinMaxFilters.test_overlap_min_max_filters seems flaky
......................................................................
Patch Set 4:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/17111/4/testdata/workloads/functional-query/queries/QueryTest/overlap_min_max_filters.test
File testdata/workloads/functional-query/queries/QueryTest/overlap_min_max_filters.test:
http://gerrit.cloudera.org:8080/#/c/17111/4/testdata/workloads/functional-query/queries/QueryTest/overlap_min_max_filters.test@34
PS4, Line 34: 80
> Should we skip this test for sanitizer builds, which are slow?
The failures were with exhaustive release build. Tested Sanitize build on my R&D box and observed the same result.
http://gerrit.cloudera.org:8080/#/c/17111/4/testdata/workloads/functional-query/queries/QueryTest/overlap_min_max_filters.test@34
PS4, Line 34: 80
> Well, the scanner should wait at least RUNTIME_FILTER_WAIT_TIME_MS before s
Yes, I checked and think you are right. The wait time used during all failed tests was set at 60000ms and the actual arrival time was around 370ms.
In all failed tests (exhaustive release), the total number of filtered pages (NumRuntimeFilteredPages) is 128.
Therefore the use of 80 as the lower bound is pretty reasonable.
http://gerrit.cloudera.org:8080/#/c/17111/4/testdata/workloads/functional-query/queries/QueryTest/overlap_min_max_filters.test@34
PS4, Line 34: 80
> How was this lower bound determined? What happens if things are really slow
It was based on the error report seen
--
To view, visit http://gerrit.cloudera.org:8080/17111
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93940a104bfb2d68cb1d41d7e303348190fd5972
Gerrit-Change-Number: 17111
Gerrit-PatchSet: 4
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 24 Feb 2021 05:34:35 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10532 TestOverlapMinMaxFilters.test overlap min max filters seems flaky
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17111 )
Change subject: IMPALA-10532 TestOverlapMinMaxFilters.test_overlap_min_max_filters seems flaky
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/17111/2/tests/common/test_result_verifier.py
File tests/common/test_result_verifier.py:
http://gerrit.cloudera.org:8080/#/c/17111/2/tests/common/test_result_verifier.py@540
PS2, Line 540: 0
flake8: E501 line too long (92 > 90 characters)
--
To view, visit http://gerrit.cloudera.org:8080/17111
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93940a104bfb2d68cb1d41d7e303348190fd5972
Gerrit-Change-Number: 17111
Gerrit-PatchSet: 2
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Feb 2021 19:25:55 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10532 TestOverlapMinMaxFilters.test overlap min max filters seems flaky
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/17111 )
Change subject: IMPALA-10532 TestOverlapMinMaxFilters.test_overlap_min_max_filters seems flaky
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17111
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93940a104bfb2d68cb1d41d7e303348190fd5972
Gerrit-Change-Number: 17111
Gerrit-PatchSet: 4
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Feb 2021 00:16:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10532 TestOverlapMinMaxFilters.test overlap min max filters seems flaky
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/17111 )
Change subject: IMPALA-10532 TestOverlapMinMaxFilters.test_overlap_min_max_filters seems flaky
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/17111/4/testdata/workloads/functional-query/queries/QueryTest/overlap_min_max_filters.test
File testdata/workloads/functional-query/queries/QueryTest/overlap_min_max_filters.test:
http://gerrit.cloudera.org:8080/#/c/17111/4/testdata/workloads/functional-query/queries/QueryTest/overlap_min_max_filters.test@34
PS4, Line 34: 80
> It was based on several error reports where the total number of pages filte
Well, the scanner should wait at least RUNTIME_FILTER_WAIT_TIME_MS before starting, so assuming that's set high enough to ensure they arrive before it starts (which is what we've always relied on in other similar runtime filter tests) I think the total sum would be deterministic.
Relying on that still leaves the possibility that the test is flaky in unusually slow environments, of course, but it has the nice property that when the test does run correctly we've ensured that the filter is applied correctly (eg. by making this a lower bound instead of a precise count there's a certain class of bugs where the filters are being misapplied and not filtering things that should be filtered that the test would not catch anymore).
So, it might be nice to just increase RUNTIME_FILTER_WAIT_TIME_MS instead of what you've done here. On the other hand, we've already increased that value a few times in the past due to this sort of flakiness, and we can't just keep increasing it forever. I'll leave it up to you.
--
To view, visit http://gerrit.cloudera.org:8080/17111
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93940a104bfb2d68cb1d41d7e303348190fd5972
Gerrit-Change-Number: 17111
Gerrit-PatchSet: 4
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Feb 2021 20:51:13 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10532 TestOverlapMinMaxFilters.test overlap min max filters seems flaky
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/17111 )
Change subject: IMPALA-10532 TestOverlapMinMaxFilters.test_overlap_min_max_filters seems flaky
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/17111/4/testdata/workloads/functional-query/queries/QueryTest/overlap_min_max_filters.test
File testdata/workloads/functional-query/queries/QueryTest/overlap_min_max_filters.test:
http://gerrit.cloudera.org:8080/#/c/17111/4/testdata/workloads/functional-query/queries/QueryTest/overlap_min_max_filters.test@34
PS4, Line 34: 80
How was this lower bound determined? What happens if things are really slow, could even more of the scan happen before the filter arrives, making this test still flaky? I guess in the extreme case this number could even end up as 0, if the entire scan happens before the filter arrives?
--
To view, visit http://gerrit.cloudera.org:8080/17111
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93940a104bfb2d68cb1d41d7e303348190fd5972
Gerrit-Change-Number: 17111
Gerrit-PatchSet: 4
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Feb 2021 20:12:02 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10532 TestOverlapMinMaxFilters.test overlap min max filters seems flaky
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/17111 )
Change subject: IMPALA-10532 TestOverlapMinMaxFilters.test_overlap_min_max_filters seems flaky
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/17111/4/testdata/workloads/functional-query/queries/QueryTest/overlap_min_max_filters.test
File testdata/workloads/functional-query/queries/QueryTest/overlap_min_max_filters.test:
http://gerrit.cloudera.org:8080/#/c/17111/4/testdata/workloads/functional-query/queries/QueryTest/overlap_min_max_filters.test@34
PS4, Line 34: 80
> Well, the scanner should wait at least RUNTIME_FILTER_WAIT_TIME_MS before s
Should we skip this test for sanitizer builds, which are slow?
--
To view, visit http://gerrit.cloudera.org:8080/17111
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93940a104bfb2d68cb1d41d7e303348190fd5972
Gerrit-Change-Number: 17111
Gerrit-PatchSet: 4
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Feb 2021 22:01:24 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10532 TestOverlapMinMaxFilters.test overlap min max filters seems flaky
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17111 )
Change subject: IMPALA-10532 TestOverlapMinMaxFilters.test_overlap_min_max_filters seems flaky
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17111
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93940a104bfb2d68cb1d41d7e303348190fd5972
Gerrit-Change-Number: 17111
Gerrit-PatchSet: 6
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 26 Feb 2021 17:07:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10532 TestOverlapMinMaxFilters.test overlap min max filters seems flaky
Posted by "Qifan Chen (Code Review)" <ge...@cloudera.org>.
Qifan Chen has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/17111 )
Change subject: IMPALA-10532 TestOverlapMinMaxFilters.test_overlap_min_max_filters seems flaky
......................................................................
IMPALA-10532 TestOverlapMinMaxFilters.test_overlap_min_max_filters seems flaky
This patch addresses the flakiness seen with a particular test within
overlap_min_max_filters by allowing the sum of NumRuntimeFilteredPages
to be greater than an expected value. Previously, such a sum can only
be equal to the expected value and is not sufficient for various test
conditions in which the scan of the parquet data files can start
before the arrival of a runtime filter.
The extension in test_result_verifier.py allows '>' and '<' condition
to be expressed for aggregation(SUM, <counter>), such as
aggregation(SUM, NumRuntimeFilteredPages)> 80.
Testing:
- Ran TestOverlapMinMaxFilters.
Change-Id: I93940a104bfb2d68cb1d41d7e303348190fd5972
---
M testdata/workloads/functional-query/queries/QueryTest/overlap_min_max_filters.test
M tests/common/test_result_verifier.py
2 files changed, 32 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/11/17111/4
--
To view, visit http://gerrit.cloudera.org:8080/17111
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I93940a104bfb2d68cb1d41d7e303348190fd5972
Gerrit-Change-Number: 17111
Gerrit-PatchSet: 4
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-10532 TestOverlapMinMaxFilters.test overlap min max filters seems flaky
Posted by "Qifan Chen (Code Review)" <ge...@cloudera.org>.
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17111 )
Change subject: IMPALA-10532 TestOverlapMinMaxFilters.test_overlap_min_max_filters seems flaky
......................................................................
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/17111/5/testdata/workloads/functional-query/queries/QueryTest/overlap_min_max_filters.test
File testdata/workloads/functional-query/queries/QueryTest/overlap_min_max_filters.test:
http://gerrit.cloudera.org:8080/#/c/17111/5/testdata/workloads/functional-query/queries/QueryTest/overlap_min_max_filters.test@9
PS5, Line 9: CREATE TABLE tpch_parquet.lineitem_orderkey_only(l_orderkey bigint)
> I see there are already other instances like this in this file, so I guess
Sounds like a good idea. Will make the change in my other commit in this area. Will leave it as is for this commit. Thanks!
--
To view, visit http://gerrit.cloudera.org:8080/17111
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93940a104bfb2d68cb1d41d7e303348190fd5972
Gerrit-Change-Number: 17111
Gerrit-PatchSet: 5
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 26 Feb 2021 01:03:05 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10532 TestOverlapMinMaxFilters.test overlap min max filters seems flaky
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17111 )
Change subject: IMPALA-10532 TestOverlapMinMaxFilters.test_overlap_min_max_filters seems flaky
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/17111/3/tests/common/test_result_verifier.py
File tests/common/test_result_verifier.py:
http://gerrit.cloudera.org:8080/#/c/17111/3/tests/common/test_result_verifier.py@541
PS3, Line 541: r
flake8: E126 continuation line over-indented for hanging indent
--
To view, visit http://gerrit.cloudera.org:8080/17111
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93940a104bfb2d68cb1d41d7e303348190fd5972
Gerrit-Change-Number: 17111
Gerrit-PatchSet: 3
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Feb 2021 19:36:11 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10532 TestOverlapMinMaxFilters.test overlap min max filters seems flaky
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17111 )
Change subject: IMPALA-10532 TestOverlapMinMaxFilters.test_overlap_min_max_filters seems flaky
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/8205/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17111
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93940a104bfb2d68cb1d41d7e303348190fd5972
Gerrit-Change-Number: 17111
Gerrit-PatchSet: 1
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Feb 2021 19:47:12 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10532 TestOverlapMinMaxFilters.test overlap min max filters seems flaky
Posted by "Qifan Chen (Code Review)" <ge...@cloudera.org>.
Qifan Chen has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/17111 )
Change subject: IMPALA-10532 TestOverlapMinMaxFilters.test_overlap_min_max_filters seems flaky
......................................................................
IMPALA-10532 TestOverlapMinMaxFilters.test_overlap_min_max_filters seems flaky
This patch addresses the flakiness seen with a particular test within
overlap_min_max_filters by allowing the sum of NumRuntimeFilteredPages
to be greater than an expected value. Previously, such a sum can only
be equal to the expected value and is not sufficient for various test
conditions in which the scan of the parquet data files can start
before the arrival of a runtime filter.
The extension in test_result_verifier.py allows '>' and '<' condition
to be expressed for aggregation(SUM, <counter>), such as
aggregation(SUM, NumRuntimeFilteredPages)> 80.
Testing:
- Ran TestOverlapMinMaxFilters.
Change-Id: I93940a104bfb2d68cb1d41d7e303348190fd5972
---
M testdata/workloads/functional-query/queries/QueryTest/overlap_min_max_filters.test
M tests/common/test_result_verifier.py
2 files changed, 52 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/11/17111/5
--
To view, visit http://gerrit.cloudera.org:8080/17111
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I93940a104bfb2d68cb1d41d7e303348190fd5972
Gerrit-Change-Number: 17111
Gerrit-PatchSet: 5
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[Impala-ASF-CR] IMPALA-10532 TestOverlapMinMaxFilters.test overlap min max filters seems flaky
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17111 )
Change subject: IMPALA-10532 TestOverlapMinMaxFilters.test_overlap_min_max_filters seems flaky
......................................................................
Patch Set 6: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/17111
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93940a104bfb2d68cb1d41d7e303348190fd5972
Gerrit-Change-Number: 17111
Gerrit-PatchSet: 6
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Fri, 26 Feb 2021 22:52:15 +0000
Gerrit-HasComments: No