You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/11/30 23:54:23 UTC

[GitHub] [apisix-dashboard] nic-chen opened a new pull request #929: Deploy master as demo

nic-chen opened a new pull request #929:
URL: https://github.com/apache/apisix-dashboard/pull/929


   Please answer these questions before submitting a pull request
   
   - Why submit this pull request?
   - [x] Bugfix
   - [ ] New feature provided
   - [ ] Improve performance
   
   - Related issues
   #920 
   
   should deploy code in master branch to the online demo
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #929: CD: auto deploy codes on the master branch to the online demo

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #929:
URL: https://github.com/apache/apisix-dashboard/pull/929#discussion_r533124140



##########
File path: docs/deploy-with-docker.md
##########
@@ -38,6 +38,10 @@ $ docker build -t apisix-dashboard:$tag .
 
 # For users in mainland China, the `ENABLE_PROXY` parameter can be provided to speed up module downloads.
 $ docker build -t apisix-dashboard:$tag . --build-arg ENABLE_PROXY=true
+
+# If you want to use the latest codes to build, you can specify the `APISIX_DASHBOARD_VERSION` parameter to `master`. 
+# This parameter can also be specified as branch name of a specific version, such as `v2.0`.
+$ docker build -t apisix-dashboard:$tag . --build-arg APISIX_DASHBOARD_VERSION=master

Review comment:
       no, use 2.1 is because the dashboard has released the 2.1.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #929: CD: auto deploy codes on the master branch to the online demo

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #929:
URL: https://github.com/apache/apisix-dashboard/pull/929#issuecomment-736125969


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/929?src=pr&el=h1) Report
   > Merging [#929](https://codecov.io/gh/apache/apisix-dashboard/pull/929?src=pr&el=desc) (0a44498) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/96e3ad1ec87f35d52d75f0a560dc152843e21e23?el=desc) (96e3ad1) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/929/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/929?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master     #929   +/-   ##
   =======================================
     Coverage   42.82%   42.82%           
   =======================================
     Files          18       18           
     Lines        1289     1289           
   =======================================
     Hits          552      552           
     Misses        645      645           
     Partials       92       92           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/929?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/929?src=pr&el=footer). Last update [96e3ad1...0a44498](https://codecov.io/gh/apache/apisix-dashboard/pull/929?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #929: CD: auto deploy codes on the master branch to the online demo

Posted by GitBox <gi...@apache.org>.
nic-chen commented on a change in pull request #929:
URL: https://github.com/apache/apisix-dashboard/pull/929#discussion_r533090251



##########
File path: docs/deploy-with-docker.md
##########
@@ -38,6 +38,10 @@ $ docker build -t apisix-dashboard:$tag .
 
 # For users in mainland China, the `ENABLE_PROXY` parameter can be provided to speed up module downloads.
 $ docker build -t apisix-dashboard:$tag . --build-arg ENABLE_PROXY=true
+
+# If you want to use the latest code to build, you can specify the `APISIX_DASHBOARD_VERSION` parameter to `master`. 

Review comment:
       fixed.

##########
File path: docs/deploy-with-docker.md
##########
@@ -38,6 +38,10 @@ $ docker build -t apisix-dashboard:$tag .
 
 # For users in mainland China, the `ENABLE_PROXY` parameter can be provided to speed up module downloads.
 $ docker build -t apisix-dashboard:$tag . --build-arg ENABLE_PROXY=true
+
+# If you want to use the latest code to build, you can specify the `APISIX_DASHBOARD_VERSION` parameter to `master`. 
+# This parameter can also be specified as a version number, such as `v2.0`.

Review comment:
       fixed.

##########
File path: docs/deploy-with-docker.md
##########
@@ -38,6 +38,10 @@ $ docker build -t apisix-dashboard:$tag .
 
 # For users in mainland China, the `ENABLE_PROXY` parameter can be provided to speed up module downloads.
 $ docker build -t apisix-dashboard:$tag . --build-arg ENABLE_PROXY=true
+
+# If you want to use the latest code to build, you can specify the `APISIX_DASHBOARD_VERSION` parameter to `master`. 
+# This parameter can also be specified as a version number, such as `v2.0`.
+$ docker build -t apisix-dashboard:$tag . --build-arg ENABLE_PROXY=true --build-arg APISIX_DASHBOARD_VERSION=master

Review comment:
       fixed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #929: ci: should deploy code in master branch to the online demo

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #929:
URL: https://github.com/apache/apisix-dashboard/pull/929#discussion_r532997579



##########
File path: docs/deploy-with-docker.md
##########
@@ -38,6 +38,10 @@ $ docker build -t apisix-dashboard:$tag .
 
 # For users in mainland China, the `ENABLE_PROXY` parameter can be provided to speed up module downloads.
 $ docker build -t apisix-dashboard:$tag . --build-arg ENABLE_PROXY=true
+
+# If you want to use the latest code to build, you can specify the `APISIX_DASHBOARD_VERSION` parameter to `master`. 
+# This parameter can also be specified as a version number, such as `v2.0`.
+$ docker build -t apisix-dashboard:$tag . --build-arg ENABLE_PROXY=true --build-arg APISIX_DASHBOARD_VERSION=master

Review comment:
       `ENABLE_PROXY` is not needed;

##########
File path: .github/workflows/deploy-with-docker.yml
##########
@@ -4,6 +4,9 @@ on:
   push:
     branches:
       - master
+  pull_request:
+    branches:
+      - master

Review comment:
       emmm No

##########
File path: docs/deploy-with-docker.zh-CN.md
##########
@@ -38,6 +38,9 @@ $ docker build -t apisix-dashboard:$tag .
 
 # 对于中国大陆的用户，可启用 `ENABLE_PROXY` 参数加快模块下载速度。
 $ docker build -t apisix-dashboard:$tag . --build-arg ENABLE_PROXY=true
+
+# 如果需要使用最新代码构建，可启用 `APISIX_DASHBOARD_VERSION` 参数指定为 `master` ，此参数也可以指定为其他版本号，如 `v2.0` 。

Review comment:
       ditto

##########
File path: docs/deploy-with-docker.md
##########
@@ -38,6 +38,10 @@ $ docker build -t apisix-dashboard:$tag .
 
 # For users in mainland China, the `ENABLE_PROXY` parameter can be provided to speed up module downloads.
 $ docker build -t apisix-dashboard:$tag . --build-arg ENABLE_PROXY=true
+
+# If you want to use the latest code to build, you can specify the `APISIX_DASHBOARD_VERSION` parameter to `master`. 
+# This parameter can also be specified as a version number, such as `v2.0`.

Review comment:
       xxx version string, actually the release branch's name

##########
File path: docs/deploy-with-docker.md
##########
@@ -38,6 +38,10 @@ $ docker build -t apisix-dashboard:$tag .
 
 # For users in mainland China, the `ENABLE_PROXY` parameter can be provided to speed up module downloads.
 $ docker build -t apisix-dashboard:$tag . --build-arg ENABLE_PROXY=true
+
+# If you want to use the latest code to build, you can specify the `APISIX_DASHBOARD_VERSION` parameter to `master`. 

Review comment:
       codes




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] membphis commented on a change in pull request #929: CD: auto deploy codes on the master branch to the online demo

Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #929:
URL: https://github.com/apache/apisix-dashboard/pull/929#discussion_r533117485



##########
File path: docs/deploy-with-docker.md
##########
@@ -38,6 +38,10 @@ $ docker build -t apisix-dashboard:$tag .
 
 # For users in mainland China, the `ENABLE_PROXY` parameter can be provided to speed up module downloads.
 $ docker build -t apisix-dashboard:$tag . --build-arg ENABLE_PROXY=true
+
+# If you want to use the latest codes to build, you can specify the `APISIX_DASHBOARD_VERSION` parameter to `master`. 
+# This parameter can also be specified as branch name of a specific version, such as `v2.0`.
+$ docker build -t apisix-dashboard:$tag . --build-arg APISIX_DASHBOARD_VERSION=master

Review comment:
       I think it should be 2.1 now. 
   
   APISIX has release 2.1 today ^_^




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #929: CD: auto deploy codes on the master branch to the online demo

Posted by GitBox <gi...@apache.org>.
nic-chen commented on a change in pull request #929:
URL: https://github.com/apache/apisix-dashboard/pull/929#discussion_r533090365



##########
File path: .github/workflows/deploy-with-docker.yml
##########
@@ -4,6 +4,9 @@ on:
   push:
     branches:
       - master
+  pull_request:
+    branches:
+      - master

Review comment:
       removed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] membphis commented on a change in pull request #929: CD: auto deploy codes on the master branch to the online demo

Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #929:
URL: https://github.com/apache/apisix-dashboard/pull/929#discussion_r533057597



##########
File path: docs/deploy-with-docker.md
##########
@@ -38,6 +38,10 @@ $ docker build -t apisix-dashboard:$tag .
 
 # For users in mainland China, the `ENABLE_PROXY` parameter can be provided to speed up module downloads.
 $ docker build -t apisix-dashboard:$tag . --build-arg ENABLE_PROXY=true
+
+# If you want to use the latest code to build, you can specify the `APISIX_DASHBOARD_VERSION` parameter to `master`. 

Review comment:
       @juzhiyuan do you mean to change `code` to `codes`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] membphis commented on pull request #929: CD: auto deploy codes on the master branch to the online demo

Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #929:
URL: https://github.com/apache/apisix-dashboard/pull/929#issuecomment-736274331


   @nic-chen CI failed, please take a look


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] membphis commented on a change in pull request #929: CD: auto deploy codes on the master branch to the online demo

Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #929:
URL: https://github.com/apache/apisix-dashboard/pull/929#discussion_r533093817



##########
File path: docs/deploy-with-docker.md
##########
@@ -38,6 +38,10 @@ $ docker build -t apisix-dashboard:$tag .
 
 # For users in mainland China, the `ENABLE_PROXY` parameter can be provided to speed up module downloads.
 $ docker build -t apisix-dashboard:$tag . --build-arg ENABLE_PROXY=true
+
+# If you want to use the latest codes to build, you can specify the `APISIX_DASHBOARD_VERSION` parameter to `master`. 
+# This parameter can also be specified as branch name of a specific version, such as `v2.0`.
+$ docker build -t apisix-dashboard:$tag . --build-arg APISIX_DASHBOARD_VERSION=master

Review comment:
       what is the default value of `APISIX_DASHBOARD_VERSION`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #929: CD: auto deploy codes on the master branch to the online demo

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #929:
URL: https://github.com/apache/apisix-dashboard/pull/929#discussion_r533060267



##########
File path: docs/deploy-with-docker.md
##########
@@ -38,6 +38,10 @@ $ docker build -t apisix-dashboard:$tag .
 
 # For users in mainland China, the `ENABLE_PROXY` parameter can be provided to speed up module downloads.
 $ docker build -t apisix-dashboard:$tag . --build-arg ENABLE_PROXY=true
+
+# If you want to use the latest code to build, you can specify the `APISIX_DASHBOARD_VERSION` parameter to `master`. 

Review comment:
       Yes, it's a grammar issue.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] nic-chen commented on pull request #929: CD: auto deploy codes on the master branch to the online demo

Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #929:
URL: https://github.com/apache/apisix-dashboard/pull/929#issuecomment-736329500


   > @nic-chen CI failed, please take a look
   
   OK now, front end e2e test unstable this time.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #929: CD: auto deploy codes on the master branch to the online demo

Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #929:
URL: https://github.com/apache/apisix-dashboard/pull/929


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #929: CD: auto deploy codes on the master branch to the online demo

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #929:
URL: https://github.com/apache/apisix-dashboard/pull/929#issuecomment-736125969


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/929?src=pr&el=h1) Report
   > Merging [#929](https://codecov.io/gh/apache/apisix-dashboard/pull/929?src=pr&el=desc) (1480ff9) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/18744a5082c4286a62503f35f2e1c60656262cc3?el=desc) (18744a5) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/929/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/929?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master     #929   +/-   ##
   =======================================
     Coverage   42.82%   42.82%           
   =======================================
     Files          18       18           
     Lines        1289     1289           
   =======================================
     Hits          552      552           
     Misses        645      645           
     Partials       92       92           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/929?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/929?src=pr&el=footer). Last update [18744a5...1480ff9](https://codecov.io/gh/apache/apisix-dashboard/pull/929?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io commented on pull request #929: ci: should deploy code in master branch to the online demo

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #929:
URL: https://github.com/apache/apisix-dashboard/pull/929#issuecomment-736125969


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/929?src=pr&el=h1) Report
   > Merging [#929](https://codecov.io/gh/apache/apisix-dashboard/pull/929?src=pr&el=desc) (db9172e) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/a7d8e13e0f97b4636ab8a35576a848c0bf004221?el=desc) (a7d8e13) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/929/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/929?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master     #929   +/-   ##
   =======================================
     Coverage   42.82%   42.82%           
   =======================================
     Files          18       18           
     Lines        1289     1289           
   =======================================
     Hits          552      552           
     Misses        645      645           
     Partials       92       92           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/929?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/929?src=pr&el=footer). Last update [a7d8e13...db9172e](https://codecov.io/gh/apache/apisix-dashboard/pull/929?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #929: CD: auto deploy codes on the master branch to the online demo

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #929:
URL: https://github.com/apache/apisix-dashboard/pull/929#issuecomment-736125969


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/929?src=pr&el=h1) Report
   > Merging [#929](https://codecov.io/gh/apache/apisix-dashboard/pull/929?src=pr&el=desc) (dae945b) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/a7d8e13e0f97b4636ab8a35576a848c0bf004221?el=desc) (a7d8e13) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/929/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/929?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master     #929   +/-   ##
   =======================================
     Coverage   42.82%   42.82%           
   =======================================
     Files          18       18           
     Lines        1289     1289           
   =======================================
     Hits          552      552           
     Misses        645      645           
     Partials       92       92           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/929?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/929?src=pr&el=footer). Last update [a7d8e13...dae945b](https://codecov.io/gh/apache/apisix-dashboard/pull/929?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #929: CD: auto deploy codes on the master branch to the online demo

Posted by GitBox <gi...@apache.org>.
nic-chen commented on a change in pull request #929:
URL: https://github.com/apache/apisix-dashboard/pull/929#discussion_r533095028



##########
File path: docs/deploy-with-docker.md
##########
@@ -38,6 +38,10 @@ $ docker build -t apisix-dashboard:$tag .
 
 # For users in mainland China, the `ENABLE_PROXY` parameter can be provided to speed up module downloads.
 $ docker build -t apisix-dashboard:$tag . --build-arg ENABLE_PROXY=true
+
+# If you want to use the latest codes to build, you can specify the `APISIX_DASHBOARD_VERSION` parameter to `master`. 
+# This parameter can also be specified as branch name of a specific version, such as `v2.0`.
+$ docker build -t apisix-dashboard:$tag . --build-arg APISIX_DASHBOARD_VERSION=master

Review comment:
       now it's v2.0. maybe master is better ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #929: CD: auto deploy codes on the master branch to the online demo

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #929:
URL: https://github.com/apache/apisix-dashboard/pull/929#discussion_r533839121



##########
File path: docs/deploy-with-docker.zh-CN.md
##########
@@ -38,6 +38,9 @@ $ docker build -t apisix-dashboard:$tag .
 
 # 对于中国大陆的用户，可启用 `ENABLE_PROXY` 参数加快模块下载速度。
 $ docker build -t apisix-dashboard:$tag . --build-arg ENABLE_PROXY=true
+
+# 如果需要使用最新代码构建，可启用 `APISIX_DASHBOARD_VERSION` 参数指定为 `master` ，此参数也可以指定为其他版本的分支名，如 `v2.0` 。

Review comment:
       Users may not know what's it, need more clearer or simpler description.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #929: CD: auto deploy codes on the master branch to the online demo

Posted by GitBox <gi...@apache.org>.
nic-chen commented on a change in pull request #929:
URL: https://github.com/apache/apisix-dashboard/pull/929#discussion_r533090228



##########
File path: docs/deploy-with-docker.zh-CN.md
##########
@@ -38,6 +38,9 @@ $ docker build -t apisix-dashboard:$tag .
 
 # 对于中国大陆的用户，可启用 `ENABLE_PROXY` 参数加快模块下载速度。
 $ docker build -t apisix-dashboard:$tag . --build-arg ENABLE_PROXY=true
+
+# 如果需要使用最新代码构建，可启用 `APISIX_DASHBOARD_VERSION` 参数指定为 `master` ，此参数也可以指定为其他版本号，如 `v2.0` 。

Review comment:
       fixed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] membphis commented on a change in pull request #929: CD: auto deploy codes on the master branch to the online demo

Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #929:
URL: https://github.com/apache/apisix-dashboard/pull/929#discussion_r533461371



##########
File path: docs/deploy-with-docker.md
##########
@@ -38,6 +38,10 @@ $ docker build -t apisix-dashboard:$tag .
 
 # For users in mainland China, the `ENABLE_PROXY` parameter can be provided to speed up module downloads.
 $ docker build -t apisix-dashboard:$tag . --build-arg ENABLE_PROXY=true
+
+# If you want to use the latest codes to build, you can specify the `APISIX_DASHBOARD_VERSION` parameter to `master`. 
+# This parameter can also be specified as branch name of a specific version, such as `v2.0`.
+$ docker build -t apisix-dashboard:$tag . --build-arg APISIX_DASHBOARD_VERSION=master

Review comment:
       @juzhiyuan you are right




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org