You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2014/03/04 20:12:48 UTC

Review Request 18742: Logs do not give the full picture of steps executed

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18742/
-----------------------------------------------------------

Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-4944
    https://issues.apache.org/jira/browse/AMBARI-4944


Repository: ambari


Description
-------

When performing an install/start, the UI logs do not give a full picture of the complete set of steps performed. The UI only shows the beginning, then updates to the most recent, which might/might not have missed steps.

Users need a complete view of all steps performed to accomplish a task.


Diffs
-----

  ambari-agent/conf/unix/ambari-agent.ini 27eb6e1 
  ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 18e4c8a 
  ambari-agent/src/main/python/ambari_agent/PythonExecutor.py 8e3a87a 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/PIG/package/scripts/service_check.py 5dd0935 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/package/scripts/service_check.py 5dd0935 
  ambari-server/src/test/python/stacks/1.3.2/PIG/test_pig_service_check.py 1b4e45e 
  ambari-server/src/test/python/stacks/2.0.6/PIG/test_pig_service_check.py 0357926 

Diff: https://reviews.apache.org/r/18742/diff/


Testing
-------

mvn clean test -Dmaven.test.skip=true
...
OK
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Ambari Main ....................................... SUCCESS [0.144s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.045s]
[INFO] Ambari Web ........................................ SUCCESS [9.142s]
[INFO] Ambari Views ...................................... SUCCESS [1.698s]
[INFO] Ambari Server ..................................... SUCCESS [20.805s]
[INFO] Ambari Agent ...................................... SUCCESS [14.471s]
[INFO] Ambari Client ..................................... SUCCESS [0.315s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 47.325s
[INFO] Finished at: Tue Mar 04 10:52:05 PST 2014
[INFO] Final Memory: 27M/400M
[INFO] ------------------------------------------------------------------------


Thanks,

Andrew Onischuk


Re: Review Request 18742: Logs do not give the full picture of steps executed

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18742/#review36146
-----------------------------------------------------------

Ship it!


Ship It!

- Dmitro Lisnichenko


On March 4, 2014, 7:23 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18742/
> -----------------------------------------------------------
> 
> (Updated March 4, 2014, 7:23 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-4944
>     https://issues.apache.org/jira/browse/AMBARI-4944
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> When performing an install/start, the UI logs do not give a full picture of the complete set of steps performed. The UI only shows the beginning, then updates to the most recent, which might/might not have missed steps.
> 
> Users need a complete view of all steps performed to accomplish a task.
> 
> 
> Diffs
> -----
> 
>   ambari-agent/conf/unix/ambari-agent.ini 27eb6e1 
>   ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 18e4c8a 
>   ambari-agent/src/main/python/ambari_agent/PythonExecutor.py 8e3a87a 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/PIG/package/scripts/service_check.py 5dd0935 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/package/scripts/service_check.py 5dd0935 
>   ambari-server/src/test/python/stacks/1.3.2/PIG/test_pig_service_check.py 1b4e45e 
>   ambari-server/src/test/python/stacks/2.0.6/PIG/test_pig_service_check.py 0357926 
> 
> Diff: https://reviews.apache.org/r/18742/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test -Dmaven.test.skip=true
> ...
> OK
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Main ....................................... SUCCESS [0.144s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.045s]
> [INFO] Ambari Web ........................................ SUCCESS [9.142s]
> [INFO] Ambari Views ...................................... SUCCESS [1.698s]
> [INFO] Ambari Server ..................................... SUCCESS [20.805s]
> [INFO] Ambari Agent ...................................... SUCCESS [14.471s]
> [INFO] Ambari Client ..................................... SUCCESS [0.315s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 47.325s
> [INFO] Finished at: Tue Mar 04 10:52:05 PST 2014
> [INFO] Final Memory: 27M/400M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>


Re: Review Request 18742: Logs do not give the full picture of steps executed

Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18742/
-----------------------------------------------------------

(Updated March 4, 2014, 7:23 p.m.)


Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-4944
    https://issues.apache.org/jira/browse/AMBARI-4944


Repository: ambari


Description
-------

When performing an install/start, the UI logs do not give a full picture of the complete set of steps performed. The UI only shows the beginning, then updates to the most recent, which might/might not have missed steps.

Users need a complete view of all steps performed to accomplish a task.


Diffs (updated)
-----

  ambari-agent/conf/unix/ambari-agent.ini 27eb6e1 
  ambari-agent/src/main/python/ambari_agent/AmbariConfig.py 18e4c8a 
  ambari-agent/src/main/python/ambari_agent/PythonExecutor.py 8e3a87a 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/PIG/package/scripts/service_check.py 5dd0935 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/package/scripts/service_check.py 5dd0935 
  ambari-server/src/test/python/stacks/1.3.2/PIG/test_pig_service_check.py 1b4e45e 
  ambari-server/src/test/python/stacks/2.0.6/PIG/test_pig_service_check.py 0357926 

Diff: https://reviews.apache.org/r/18742/diff/


Testing
-------

mvn clean test -Dmaven.test.skip=true
...
OK
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Ambari Main ....................................... SUCCESS [0.144s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.045s]
[INFO] Ambari Web ........................................ SUCCESS [9.142s]
[INFO] Ambari Views ...................................... SUCCESS [1.698s]
[INFO] Ambari Server ..................................... SUCCESS [20.805s]
[INFO] Ambari Agent ...................................... SUCCESS [14.471s]
[INFO] Ambari Client ..................................... SUCCESS [0.315s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 47.325s
[INFO] Finished at: Tue Mar 04 10:52:05 PST 2014
[INFO] Final Memory: 27M/400M
[INFO] ------------------------------------------------------------------------


Thanks,

Andrew Onischuk