[jira] [Commented] (FLINK-7898) TaskExecutorTest.testTriggerRegistrationOnLeaderChange fails on Travis

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-7898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16214290#comment-16214290 ] 

ASF GitHub Bot commented on FLINK-7898:
---------------------------------------

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/4880

    [FLINK-7898] [flip6] Don't propagate CancellationExceptions in RegisteredRpcConnection

    ## What is the purpose of the change
    
    The RegisteredRpcConnection should not call the exception handler when the RetryingRegistration future failed with a cancellation exception, because this is how the future is completed in case of stopping the RetryingRegistration.
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink fixTaskExecutorTest

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4880.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4880
    
----
commit d7c6f4a56eb5d1c7ac3d4ee1b02e37697ca0022a
Author: Till Rohrmann <tr...@apache.org>
Date:   2017-10-22T11:38:50Z

    [FLINK-7898] [flip6] Don't propagate CancellationExceptions in RegisteredRpcConnection
    
    The RegisteredRpcConnection should not call the exception handler when the RetryingRegistration future
    failed with a cancellation exception, because this is how the future is completed in case of stopping
    the RetryingRegistration.

----


> TaskExecutorTest.testTriggerRegistrationOnLeaderChange fails on Travis
> ----------------------------------------------------------------------
>
>                 Key: FLINK-7898
>                 URL: https://issues.apache.org/jira/browse/FLINK-7898
>             Project: Flink
>          Issue Type: Bug
>          Components: Tests
>    Affects Versions: 1.4.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Critical
>              Labels: test-stability
>             Fix For: 1.4.0
>
>
> The {{TaskExecutorTest.testTriggerRegistrationOnLeaderChange}} fails spuriously on Travis.
> https://travis-ci.org/aljoscha/flink/jobs/291074999



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)