You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2019/08/30 01:45:17 UTC
[GitHub] [hadoop] jojochuang commented on a change in pull request #1314:
HDFS-14748. Make DataNodePeerMetrics#minOutlierDetectionSamples configurable
jojochuang commented on a change in pull request #1314: HDFS-14748. Make DataNodePeerMetrics#minOutlierDetectionSamples configurable
URL: https://github.com/apache/hadoop/pull/1314#discussion_r319331328
##########
File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/metrics/DataNodePeerMetrics.java
##########
@@ -58,11 +61,13 @@
* for outlier detection. If the number of samples is below this then
* outlier detection is skipped.
*/
- @VisibleForTesting
- static final long MIN_OUTLIER_DETECTION_SAMPLES = 1000;
+ private final long minOutlierDetectionSamples;
- public DataNodePeerMetrics(final String name) {
+ public DataNodePeerMetrics(final String name, Configuration conf) {
Review comment:
This one arguably breaks compatibility. But given that this class is
@InterfaceAudience.Private
@InterfaceStability.Unstable
I think this is acceptable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org