You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@beam.apache.org by Scott Wegner <sc...@apache.org> on 2018/06/26 21:21:25 UTC
Filtered Pre-commit triggering is BACK!
By popular demand [1], filtered pre-commit triggering is now re-enabled.
Now when submitting pull request, only pre-commit tests for your affected
files will run: if you change just the Go SDK, you'll no longer need to run
Java pre-commits.
Last time we introduced this change it regressed our ability to run other
pre-commits via trigger phrase ("Run Java PreCommit"); this is now fixed by
splitting the Jenkins jobs by trigger condition [2].
Enjoy!
[1]
https://lists.apache.org/thread.html/f98af933ce1ffbf8ae85161dea032aab4577a600c749f46b1d85c226@%3Cdev.beam.apache.org%3E
[2] https://github.com/apache/beam/pull/5757
Re: Filtered Pre-commit triggering is BACK!
Posted by Reuven Lax <re...@google.com>.
Yeah, this last one took 20 minutes to trigger :(
On Fri, Jun 29, 2018 at 9:25 AM Scott Wegner <sw...@google.com> wrote:
> GitHub triggering continues to be delayed intermittently. I've filed a
> JIRA to track: https://issues.apache.org/jira/browse/BEAM-4692. JB, can
> you link any ticket you have with INFRA for those that are affected to keep
> track?
>
> Robin, I looked at your PR#5787 which ran all pre-commits instead of just
> Java. I suspect it's because your PR has merge commits for upstream/master
> [1] which bring in non-Java changes. The include paths for Java are defined
> here [2] and here [3], and the logic is implemented in the Jenkins ghprb
> plugin [4].
>
> Reuven, from your open pull requests I think you are referring to PR#5545
> [5]. I can see that tests eventually re-ran [6] after about an 11 min delay.
>
>
> [1] https://github.com/apache/beam/pull/5787/commits
> [2]
> https://github.com/apache/beam/blob/627d4eed7db7d6072c0b98762c94ea2472d530dc/.test-infra/jenkins/job_PreCommit_Java.groovy#L25
>
> [3]
> https://github.com/apache/beam/blob/627d4eed7db7d6072c0b98762c94ea2472d530dc/.test-infra/jenkins/PrecommitJobBuilder.groovy#L62
>
> [4]
> https://github.com/jenkinsci/ghprb-plugin/blob/c943b3038b98f73b183b527d6ae3da7d58667e6e/src/main/java/org/jenkinsci/plugins/ghprb/GhprbPullRequest.java#L458
>
> [5] https://github.com/apache/beam/pull/5545#issuecomment-401215439
> [6] https://builds.apache.org/job/beam_PreCommit_Java_Commit/124/
>
> On Thu, Jun 28, 2018 at 7:25 PM Jean-Baptiste Onofré <jb...@nanthrax.net>
> wrote:
>
>> It failed again. I'm pinging infra a new time.
>>
>> Sorry about that.
>>
>> Regards
>> JB
>> Le 29 juin 2018, à 08:52, Reuven Lax <re...@google.com> a écrit:
>>>
>>> "retest this please" also seems to not be working right now.
>>>
>>> On Thu, Jun 28, 2018 at 5:49 PM Reuven Lax < relax@google.com> wrote:
>>>
>>>> I've pushed changes that definitely affect code, and seen no tests at
>>>> all being triggered. I also wonder if something isn't working quite right
>>>> with this filtering.
>>>>
>>>> On Thu, Jun 28, 2018 at 5:16 PM Robin Qiu < robinyq@google.com> wrote:
>>>>
>>>>> My PR with only changes in Java also triggered Python ("Run Python
>>>>> PreCommit") and Go ("Run Go PreCommit") tests. Is that the expected
>>>>> behavior?
>>>>> https://github.com/apache/beam/pull/5787
>>>>>
>>>>> On Wed, Jun 27, 2018 at 5:04 PM Ahmet Altay < altay@google.com>
>>>>> wrote:
>>>>>
>>>>>> Two of my PRs with python changes did not trigger any pre-commits.
>>>>>> Could it be related to this change?
>>>>>>
>>>>>> https://github.com/apache/beam/pull/5768
>>>>>> https://github.com/apache/beam/pull/5800
>>>>>>
>>>>>> Ahmet
>>>>>>
>>>>>>
>>>>>>
>>>>>> On Tue, Jun 26, 2018 at 2:30 PM, Andrew Pilloud <ap...@google.com>
>>>>>> wrote:
>>>>>>
>>>>>>> Awesome! This will save so much time running tests.
>>>>>>>
>>>>>>> On Tue, Jun 26, 2018 at 2:29 PM Yifan Zou < yifanzou@google.com>
>>>>>>> wrote:
>>>>>>>
>>>>>>>> Thanks Scott! It's nice to have this feature.
>>>>>>>>
>>>>>>>> On Tue, Jun 26, 2018 at 2:24 PM Pablo Estrada < pabloem@google.com>
>>>>>>>> wrote:
>>>>>>>>
>>>>>>>>> This is great. Reducing load on infrastructure should help Beam
>>>>>>>>> scale into a larger project : ) - Thanks Scott!
>>>>>>>>>
>>>>>>>>> On Tue, Jun 26, 2018 at 2:21 PM Scott Wegner < scott@apache.org>
>>>>>>>>> wrote:
>>>>>>>>>
>>>>>>>>>> By popular demand [1], filtered pre-commit triggering is now
>>>>>>>>>> re-enabled. Now when submitting pull request, only pre-commit tests for
>>>>>>>>>> your affected files will run: if you change just the Go SDK, you'll no
>>>>>>>>>> longer need to run Java pre-commits.
>>>>>>>>>>
>>>>>>>>>> Last time we introduced this change it regressed our ability to
>>>>>>>>>> run other pre-commits via trigger phrase ("Run Java PreCommit"); this is
>>>>>>>>>> now fixed by splitting the Jenkins jobs by trigger condition [2].
>>>>>>>>>>
>>>>>>>>>> Enjoy!
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> [1]
>>>>>>>>>> https://lists.apache.org/thread.html/f98af933ce1ffbf8ae85161dea032aab4577a600c749f46b1d85c226@%3Cdev.beam.apache.org%3E
>>>>>>>>>> [2] https://github.com/apache/beam/pull/5757
>>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> Got feedback? go/pabloem-feedback
>>>>>>>>> <https://goto.google.com/pabloem-feedback>
>>>>>>>>>
>>>>>>>>
>>>>>>
Re: Filtered Pre-commit triggering is BACK!
Posted by Scott Wegner <sw...@google.com>.
GitHub triggering continues to be delayed intermittently. I've filed a JIRA
to track: https://issues.apache.org/jira/browse/BEAM-4692. JB, can you link
any ticket you have with INFRA for those that are affected to keep track?
Robin, I looked at your PR#5787 which ran all pre-commits instead of just
Java. I suspect it's because your PR has merge commits for upstream/master
[1] which bring in non-Java changes. The include paths for Java are defined
here [2] and here [3], and the logic is implemented in the Jenkins ghprb
plugin [4].
Reuven, from your open pull requests I think you are referring to PR#5545
[5]. I can see that tests eventually re-ran [6] after about an 11 min delay.
[1] https://github.com/apache/beam/pull/5787/commits
[2]
https://github.com/apache/beam/blob/627d4eed7db7d6072c0b98762c94ea2472d530dc/.test-infra/jenkins/job_PreCommit_Java.groovy#L25
[3]
https://github.com/apache/beam/blob/627d4eed7db7d6072c0b98762c94ea2472d530dc/.test-infra/jenkins/PrecommitJobBuilder.groovy#L62
[4]
https://github.com/jenkinsci/ghprb-plugin/blob/c943b3038b98f73b183b527d6ae3da7d58667e6e/src/main/java/org/jenkinsci/plugins/ghprb/GhprbPullRequest.java#L458
[5] https://github.com/apache/beam/pull/5545#issuecomment-401215439
[6] https://builds.apache.org/job/beam_PreCommit_Java_Commit/124/
On Thu, Jun 28, 2018 at 7:25 PM Jean-Baptiste Onofré <jb...@nanthrax.net>
wrote:
> It failed again. I'm pinging infra a new time.
>
> Sorry about that.
>
> Regards
> JB
> Le 29 juin 2018, à 08:52, Reuven Lax <re...@google.com> a écrit:
>>
>> "retest this please" also seems to not be working right now.
>>
>> On Thu, Jun 28, 2018 at 5:49 PM Reuven Lax < relax@google.com> wrote:
>>
>>> I've pushed changes that definitely affect code, and seen no tests at
>>> all being triggered. I also wonder if something isn't working quite right
>>> with this filtering.
>>>
>>> On Thu, Jun 28, 2018 at 5:16 PM Robin Qiu < robinyq@google.com> wrote:
>>>
>>>> My PR with only changes in Java also triggered Python ("Run Python
>>>> PreCommit") and Go ("Run Go PreCommit") tests. Is that the expected
>>>> behavior?
>>>> https://github.com/apache/beam/pull/5787
>>>>
>>>> On Wed, Jun 27, 2018 at 5:04 PM Ahmet Altay < altay@google.com> wrote:
>>>>
>>>>> Two of my PRs with python changes did not trigger any pre-commits.
>>>>> Could it be related to this change?
>>>>>
>>>>> https://github.com/apache/beam/pull/5768
>>>>> https://github.com/apache/beam/pull/5800
>>>>>
>>>>> Ahmet
>>>>>
>>>>>
>>>>>
>>>>> On Tue, Jun 26, 2018 at 2:30 PM, Andrew Pilloud <ap...@google.com>
>>>>> wrote:
>>>>>
>>>>>> Awesome! This will save so much time running tests.
>>>>>>
>>>>>> On Tue, Jun 26, 2018 at 2:29 PM Yifan Zou < yifanzou@google.com>
>>>>>> wrote:
>>>>>>
>>>>>>> Thanks Scott! It's nice to have this feature.
>>>>>>>
>>>>>>> On Tue, Jun 26, 2018 at 2:24 PM Pablo Estrada < pabloem@google.com>
>>>>>>> wrote:
>>>>>>>
>>>>>>>> This is great. Reducing load on infrastructure should help Beam
>>>>>>>> scale into a larger project : ) - Thanks Scott!
>>>>>>>>
>>>>>>>> On Tue, Jun 26, 2018 at 2:21 PM Scott Wegner < scott@apache.org>
>>>>>>>> wrote:
>>>>>>>>
>>>>>>>>> By popular demand [1], filtered pre-commit triggering is now
>>>>>>>>> re-enabled. Now when submitting pull request, only pre-commit tests for
>>>>>>>>> your affected files will run: if you change just the Go SDK, you'll no
>>>>>>>>> longer need to run Java pre-commits.
>>>>>>>>>
>>>>>>>>> Last time we introduced this change it regressed our ability to
>>>>>>>>> run other pre-commits via trigger phrase ("Run Java PreCommit"); this is
>>>>>>>>> now fixed by splitting the Jenkins jobs by trigger condition [2].
>>>>>>>>>
>>>>>>>>> Enjoy!
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> [1]
>>>>>>>>> https://lists.apache.org/thread.html/f98af933ce1ffbf8ae85161dea032aab4577a600c749f46b1d85c226@%3Cdev.beam.apache.org%3E
>>>>>>>>> [2] https://github.com/apache/beam/pull/5757
>>>>>>>>>
>>>>>>>> --
>>>>>>>> Got feedback? go/pabloem-feedback
>>>>>>>> <https://goto.google.com/pabloem-feedback>
>>>>>>>>
>>>>>>>
>>>>>
Re: Filtered Pre-commit triggering is BACK!
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
It failed again. I'm pinging infra a new time.
Sorry about that.
Regards
JB
Le 29 juin 2018 à 08:52, à 08:52, Reuven Lax <re...@google.com> a écrit:
>"retest this please" also seems to not be working right now.
>
>On Thu, Jun 28, 2018 at 5:49 PM Reuven Lax <re...@google.com> wrote:
>
>> I've pushed changes that definitely affect code, and seen no tests at
>all
>> being triggered. I also wonder if something isn't working quite right
>with
>> this filtering.
>>
>> On Thu, Jun 28, 2018 at 5:16 PM Robin Qiu <ro...@google.com> wrote:
>>
>>> My PR with only changes in Java also triggered Python ("Run Python
>>> PreCommit") and Go ("Run Go PreCommit") tests. Is that the expected
>>> behavior?
>>> https://github.com/apache/beam/pull/5787
>>>
>>> On Wed, Jun 27, 2018 at 5:04 PM Ahmet Altay <al...@google.com>
>wrote:
>>>
>>>> Two of my PRs with python changes did not trigger any pre-commits.
>Could
>>>> it be related to this change?
>>>>
>>>> https://github.com/apache/beam/pull/5768
>>>> https://github.com/apache/beam/pull/5800
>>>>
>>>> Ahmet
>>>>
>>>>
>>>>
>>>> On Tue, Jun 26, 2018 at 2:30 PM, Andrew Pilloud
><ap...@google.com>
>>>> wrote:
>>>>
>>>>> Awesome! This will save so much time running tests.
>>>>>
>>>>> On Tue, Jun 26, 2018 at 2:29 PM Yifan Zou <yi...@google.com>
>wrote:
>>>>>
>>>>>> Thanks Scott! It's nice to have this feature.
>>>>>>
>>>>>> On Tue, Jun 26, 2018 at 2:24 PM Pablo Estrada
><pa...@google.com>
>>>>>> wrote:
>>>>>>
>>>>>>> This is great. Reducing load on infrastructure should help Beam
>scale
>>>>>>> into a larger project : ) - Thanks Scott!
>>>>>>>
>>>>>>> On Tue, Jun 26, 2018 at 2:21 PM Scott Wegner <sc...@apache.org>
>>>>>>> wrote:
>>>>>>>
>>>>>>>> By popular demand [1], filtered pre-commit triggering is now
>>>>>>>> re-enabled. Now when submitting pull request, only pre-commit
>tests for
>>>>>>>> your affected files will run: if you change just the Go SDK,
>you'll no
>>>>>>>> longer need to run Java pre-commits.
>>>>>>>>
>>>>>>>> Last time we introduced this change it regressed our ability to
>run
>>>>>>>> other pre-commits via trigger phrase ("Run Java PreCommit");
>this is now
>>>>>>>> fixed by splitting the Jenkins jobs by trigger condition [2].
>>>>>>>>
>>>>>>>> Enjoy!
>>>>>>>>
>>>>>>>>
>>>>>>>> [1]
>>>>>>>>
>https://lists.apache.org/thread.html/f98af933ce1ffbf8ae85161dea032aab4577a600c749f46b1d85c226@%3Cdev.beam.apache.org%3E
>>>>>>>> [2] https://github.com/apache/beam/pull/5757
>>>>>>>>
>>>>>>> --
>>>>>>> Got feedback? go/pabloem-feedback
>>>>>>> <https://goto.google.com/pabloem-feedback>
>>>>>>>
>>>>>>
>>>>
Re: Filtered Pre-commit triggering is BACK!
Posted by Reuven Lax <re...@google.com>.
"retest this please" also seems to not be working right now.
On Thu, Jun 28, 2018 at 5:49 PM Reuven Lax <re...@google.com> wrote:
> I've pushed changes that definitely affect code, and seen no tests at all
> being triggered. I also wonder if something isn't working quite right with
> this filtering.
>
> On Thu, Jun 28, 2018 at 5:16 PM Robin Qiu <ro...@google.com> wrote:
>
>> My PR with only changes in Java also triggered Python ("Run Python
>> PreCommit") and Go ("Run Go PreCommit") tests. Is that the expected
>> behavior?
>> https://github.com/apache/beam/pull/5787
>>
>> On Wed, Jun 27, 2018 at 5:04 PM Ahmet Altay <al...@google.com> wrote:
>>
>>> Two of my PRs with python changes did not trigger any pre-commits. Could
>>> it be related to this change?
>>>
>>> https://github.com/apache/beam/pull/5768
>>> https://github.com/apache/beam/pull/5800
>>>
>>> Ahmet
>>>
>>>
>>>
>>> On Tue, Jun 26, 2018 at 2:30 PM, Andrew Pilloud <ap...@google.com>
>>> wrote:
>>>
>>>> Awesome! This will save so much time running tests.
>>>>
>>>> On Tue, Jun 26, 2018 at 2:29 PM Yifan Zou <yi...@google.com> wrote:
>>>>
>>>>> Thanks Scott! It's nice to have this feature.
>>>>>
>>>>> On Tue, Jun 26, 2018 at 2:24 PM Pablo Estrada <pa...@google.com>
>>>>> wrote:
>>>>>
>>>>>> This is great. Reducing load on infrastructure should help Beam scale
>>>>>> into a larger project : ) - Thanks Scott!
>>>>>>
>>>>>> On Tue, Jun 26, 2018 at 2:21 PM Scott Wegner <sc...@apache.org>
>>>>>> wrote:
>>>>>>
>>>>>>> By popular demand [1], filtered pre-commit triggering is now
>>>>>>> re-enabled. Now when submitting pull request, only pre-commit tests for
>>>>>>> your affected files will run: if you change just the Go SDK, you'll no
>>>>>>> longer need to run Java pre-commits.
>>>>>>>
>>>>>>> Last time we introduced this change it regressed our ability to run
>>>>>>> other pre-commits via trigger phrase ("Run Java PreCommit"); this is now
>>>>>>> fixed by splitting the Jenkins jobs by trigger condition [2].
>>>>>>>
>>>>>>> Enjoy!
>>>>>>>
>>>>>>>
>>>>>>> [1]
>>>>>>> https://lists.apache.org/thread.html/f98af933ce1ffbf8ae85161dea032aab4577a600c749f46b1d85c226@%3Cdev.beam.apache.org%3E
>>>>>>> [2] https://github.com/apache/beam/pull/5757
>>>>>>>
>>>>>> --
>>>>>> Got feedback? go/pabloem-feedback
>>>>>> <https://goto.google.com/pabloem-feedback>
>>>>>>
>>>>>
>>>
Re: Filtered Pre-commit triggering is BACK!
Posted by Reuven Lax <re...@google.com>.
I've pushed changes that definitely affect code, and seen no tests at all
being triggered. I also wonder if something isn't working quite right with
this filtering.
On Thu, Jun 28, 2018 at 5:16 PM Robin Qiu <ro...@google.com> wrote:
> My PR with only changes in Java also triggered Python ("Run Python
> PreCommit") and Go ("Run Go PreCommit") tests. Is that the expected
> behavior?
> https://github.com/apache/beam/pull/5787
>
> On Wed, Jun 27, 2018 at 5:04 PM Ahmet Altay <al...@google.com> wrote:
>
>> Two of my PRs with python changes did not trigger any pre-commits. Could
>> it be related to this change?
>>
>> https://github.com/apache/beam/pull/5768
>> https://github.com/apache/beam/pull/5800
>>
>> Ahmet
>>
>>
>>
>> On Tue, Jun 26, 2018 at 2:30 PM, Andrew Pilloud <ap...@google.com>
>> wrote:
>>
>>> Awesome! This will save so much time running tests.
>>>
>>> On Tue, Jun 26, 2018 at 2:29 PM Yifan Zou <yi...@google.com> wrote:
>>>
>>>> Thanks Scott! It's nice to have this feature.
>>>>
>>>> On Tue, Jun 26, 2018 at 2:24 PM Pablo Estrada <pa...@google.com>
>>>> wrote:
>>>>
>>>>> This is great. Reducing load on infrastructure should help Beam scale
>>>>> into a larger project : ) - Thanks Scott!
>>>>>
>>>>> On Tue, Jun 26, 2018 at 2:21 PM Scott Wegner <sc...@apache.org> wrote:
>>>>>
>>>>>> By popular demand [1], filtered pre-commit triggering is now
>>>>>> re-enabled. Now when submitting pull request, only pre-commit tests for
>>>>>> your affected files will run: if you change just the Go SDK, you'll no
>>>>>> longer need to run Java pre-commits.
>>>>>>
>>>>>> Last time we introduced this change it regressed our ability to run
>>>>>> other pre-commits via trigger phrase ("Run Java PreCommit"); this is now
>>>>>> fixed by splitting the Jenkins jobs by trigger condition [2].
>>>>>>
>>>>>> Enjoy!
>>>>>>
>>>>>>
>>>>>> [1]
>>>>>> https://lists.apache.org/thread.html/f98af933ce1ffbf8ae85161dea032aab4577a600c749f46b1d85c226@%3Cdev.beam.apache.org%3E
>>>>>> [2] https://github.com/apache/beam/pull/5757
>>>>>>
>>>>> --
>>>>> Got feedback? go/pabloem-feedback
>>>>> <https://goto.google.com/pabloem-feedback>
>>>>>
>>>>
>>
Re: Filtered Pre-commit triggering is BACK!
Posted by Robin Qiu <ro...@google.com>.
My PR with only changes in Java also triggered Python ("Run Python
PreCommit") and Go ("Run Go PreCommit") tests. Is that the expected
behavior?
https://github.com/apache/beam/pull/5787
On Wed, Jun 27, 2018 at 5:04 PM Ahmet Altay <al...@google.com> wrote:
> Two of my PRs with python changes did not trigger any pre-commits. Could
> it be related to this change?
>
> https://github.com/apache/beam/pull/5768
> https://github.com/apache/beam/pull/5800
>
> Ahmet
>
>
>
> On Tue, Jun 26, 2018 at 2:30 PM, Andrew Pilloud <ap...@google.com>
> wrote:
>
>> Awesome! This will save so much time running tests.
>>
>> On Tue, Jun 26, 2018 at 2:29 PM Yifan Zou <yi...@google.com> wrote:
>>
>>> Thanks Scott! It's nice to have this feature.
>>>
>>> On Tue, Jun 26, 2018 at 2:24 PM Pablo Estrada <pa...@google.com>
>>> wrote:
>>>
>>>> This is great. Reducing load on infrastructure should help Beam scale
>>>> into a larger project : ) - Thanks Scott!
>>>>
>>>> On Tue, Jun 26, 2018 at 2:21 PM Scott Wegner <sc...@apache.org> wrote:
>>>>
>>>>> By popular demand [1], filtered pre-commit triggering is now
>>>>> re-enabled. Now when submitting pull request, only pre-commit tests for
>>>>> your affected files will run: if you change just the Go SDK, you'll no
>>>>> longer need to run Java pre-commits.
>>>>>
>>>>> Last time we introduced this change it regressed our ability to run
>>>>> other pre-commits via trigger phrase ("Run Java PreCommit"); this is now
>>>>> fixed by splitting the Jenkins jobs by trigger condition [2].
>>>>>
>>>>> Enjoy!
>>>>>
>>>>>
>>>>> [1]
>>>>> https://lists.apache.org/thread.html/f98af933ce1ffbf8ae85161dea032aab4577a600c749f46b1d85c226@%3Cdev.beam.apache.org%3E
>>>>> [2] https://github.com/apache/beam/pull/5757
>>>>>
>>>> --
>>>> Got feedback? go/pabloem-feedback
>>>> <https://goto.google.com/pabloem-feedback>
>>>>
>>>
>
Re: Filtered Pre-commit triggering is BACK!
Posted by Ahmet Altay <al...@google.com>.
Two of my PRs with python changes did not trigger any pre-commits. Could it
be related to this change?
https://github.com/apache/beam/pull/5768
https://github.com/apache/beam/pull/5800
Ahmet
On Tue, Jun 26, 2018 at 2:30 PM, Andrew Pilloud <ap...@google.com> wrote:
> Awesome! This will save so much time running tests.
>
> On Tue, Jun 26, 2018 at 2:29 PM Yifan Zou <yi...@google.com> wrote:
>
>> Thanks Scott! It's nice to have this feature.
>>
>> On Tue, Jun 26, 2018 at 2:24 PM Pablo Estrada <pa...@google.com> wrote:
>>
>>> This is great. Reducing load on infrastructure should help Beam scale
>>> into a larger project : ) - Thanks Scott!
>>>
>>> On Tue, Jun 26, 2018 at 2:21 PM Scott Wegner <sc...@apache.org> wrote:
>>>
>>>> By popular demand [1], filtered pre-commit triggering is now
>>>> re-enabled. Now when submitting pull request, only pre-commit tests for
>>>> your affected files will run: if you change just the Go SDK, you'll no
>>>> longer need to run Java pre-commits.
>>>>
>>>> Last time we introduced this change it regressed our ability to run
>>>> other pre-commits via trigger phrase ("Run Java PreCommit"); this is now
>>>> fixed by splitting the Jenkins jobs by trigger condition [2].
>>>>
>>>> Enjoy!
>>>>
>>>>
>>>> [1] https://lists.apache.org/thread.html/f98af933ce1ffbf8ae85161dea032a
>>>> ab4577a600c749f46b1d85c226@%3Cdev.beam.apache.org%3E
>>>> [2] https://github.com/apache/beam/pull/5757
>>>>
>>> --
>>> Got feedback? go/pabloem-feedback
>>> <https://goto.google.com/pabloem-feedback>
>>>
>>
Re: Filtered Pre-commit triggering is BACK!
Posted by Andrew Pilloud <ap...@google.com>.
Awesome! This will save so much time running tests.
On Tue, Jun 26, 2018 at 2:29 PM Yifan Zou <yi...@google.com> wrote:
> Thanks Scott! It's nice to have this feature.
>
> On Tue, Jun 26, 2018 at 2:24 PM Pablo Estrada <pa...@google.com> wrote:
>
>> This is great. Reducing load on infrastructure should help Beam scale
>> into a larger project : ) - Thanks Scott!
>>
>> On Tue, Jun 26, 2018 at 2:21 PM Scott Wegner <sc...@apache.org> wrote:
>>
>>> By popular demand [1], filtered pre-commit triggering is now re-enabled.
>>> Now when submitting pull request, only pre-commit tests for your affected
>>> files will run: if you change just the Go SDK, you'll no longer need to run
>>> Java pre-commits.
>>>
>>> Last time we introduced this change it regressed our ability to run
>>> other pre-commits via trigger phrase ("Run Java PreCommit"); this is now
>>> fixed by splitting the Jenkins jobs by trigger condition [2].
>>>
>>> Enjoy!
>>>
>>>
>>> [1]
>>> https://lists.apache.org/thread.html/f98af933ce1ffbf8ae85161dea032aab4577a600c749f46b1d85c226@%3Cdev.beam.apache.org%3E
>>> [2] https://github.com/apache/beam/pull/5757
>>>
>> --
>> Got feedback? go/pabloem-feedback
>> <https://goto.google.com/pabloem-feedback>
>>
>
Re: Filtered Pre-commit triggering is BACK!
Posted by Yifan Zou <yi...@google.com>.
Thanks Scott! It's nice to have this feature.
On Tue, Jun 26, 2018 at 2:24 PM Pablo Estrada <pa...@google.com> wrote:
> This is great. Reducing load on infrastructure should help Beam scale into
> a larger project : ) - Thanks Scott!
>
> On Tue, Jun 26, 2018 at 2:21 PM Scott Wegner <sc...@apache.org> wrote:
>
>> By popular demand [1], filtered pre-commit triggering is now re-enabled.
>> Now when submitting pull request, only pre-commit tests for your affected
>> files will run: if you change just the Go SDK, you'll no longer need to run
>> Java pre-commits.
>>
>> Last time we introduced this change it regressed our ability to run other
>> pre-commits via trigger phrase ("Run Java PreCommit"); this is now fixed by
>> splitting the Jenkins jobs by trigger condition [2].
>>
>> Enjoy!
>>
>>
>> [1]
>> https://lists.apache.org/thread.html/f98af933ce1ffbf8ae85161dea032aab4577a600c749f46b1d85c226@%3Cdev.beam.apache.org%3E
>> [2] https://github.com/apache/beam/pull/5757
>>
> --
> Got feedback? go/pabloem-feedback
> <https://goto.google.com/pabloem-feedback>
>
Re: Filtered Pre-commit triggering is BACK!
Posted by Pablo Estrada <pa...@google.com>.
This is great. Reducing load on infrastructure should help Beam scale into
a larger project : ) - Thanks Scott!
On Tue, Jun 26, 2018 at 2:21 PM Scott Wegner <sc...@apache.org> wrote:
> By popular demand [1], filtered pre-commit triggering is now re-enabled.
> Now when submitting pull request, only pre-commit tests for your affected
> files will run: if you change just the Go SDK, you'll no longer need to run
> Java pre-commits.
>
> Last time we introduced this change it regressed our ability to run other
> pre-commits via trigger phrase ("Run Java PreCommit"); this is now fixed by
> splitting the Jenkins jobs by trigger condition [2].
>
> Enjoy!
>
>
> [1]
> https://lists.apache.org/thread.html/f98af933ce1ffbf8ae85161dea032aab4577a600c749f46b1d85c226@%3Cdev.beam.apache.org%3E
> [2] https://github.com/apache/beam/pull/5757
>
--
Got feedback? go/pabloem-feedback