Re: Review Request 61895: GEDOE-3516: TXManagerImpl.tryResume call may add itself again into the waiting thread queue

[Eric Shu <es...@pivotal.io>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61895/#review184582
-----------------------------------------------------------




geode-core/src/test/java/org/apache/geode/internal/cache/TXManagerImplJUnitTest.java
Lines 380 (patched)
<https://reviews.apache.org/r/61895/#comment260750>

    To make sure the thread wait for 300 ms before calling suspend method.



geode-core/src/test/java/org/apache/geode/internal/cache/TXManagerImplJUnitTest.java
Lines 384 (patched)
<https://reviews.apache.org/r/61895/#comment260751>

    The other two threads calls spyMgr.tryResume, and that method call will continue to park untill another thread calls suspend to unpark a waiting thread. Yes, it is guaranteed.


- Eric Shu


On Aug. 25, 2017, 4:53 p.m., Eric Shu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61895/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2017, 4:53 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Darrel Schneider, Lynn Gallinat, and Nick Reich.
> 
> 
> Bugs: GEODE-3516
>     https://issues.apache.org/jira/browse/GEODE-3516
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> Remove the thread from waiting thread queue after successfully resumed the transaction
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/org/apache/geode/internal/cache/TXManagerImpl.java a0a4d7c 
>   geode-core/src/test/java/org/apache/geode/internal/cache/TXManagerImplJUnitTest.java a2c1e70 
> 
> 
> Diff: https://reviews.apache.org/r/61895/diff/2/
> 
> 
> Testing
> -------
> 
> precheckin.
> 
> 
> Thanks,
> 
> Eric Shu
> 
>