You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "Justin Bertram (Jira)" <ji...@apache.org> on 2020/11/13 13:27:00 UTC
[jira] [Commented] (ARTEMIS-2991) Leak of HttpAcceptorHandler
instances when using websocket connections
[ https://issues.apache.org/jira/browse/ARTEMIS-2991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231446#comment-17231446 ]
Justin Bertram commented on ARTEMIS-2991:
-----------------------------------------
As far as I can tell the {{HttpAcceptorHandler}} is _already_ [removed during the upgrade|https://github.com/apache/activemq-artemis/blob/master/artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/ProtocolHandler.java#L144].
> Leak of HttpAcceptorHandler instances when using websocket connections
> ----------------------------------------------------------------------
>
> Key: ARTEMIS-2991
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2991
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Affects Versions: 2.9.0, 2.10.0, 2.10.1, 2.11.0, 2.12.0, 2.13.0, 2.14.0, 2.15.0, 2.16.0
> Reporter: Luis Miguel De Bello
> Priority: Major
> Fix For: 2.17.0
>
> Attachments: HeapDump analysis.png
>
>
> We are running Artemis 2.9.0 and we noticed the memory grows continuously after getting a heap we discovered there are a leak of multiple instances of type org.apache.activemq.artemis.core.remoting.impl.netty.HttpAcceptorHandler which are keep in a list inside org.apache.activemq.artemis.core.remoting.impl.netty.HttpKeepAliveRunnable.
>
> Those instances are removed in the channelInactive method but this method is not called because when doing the upgrade to websocket the handler is removed.
>
> Proposals:
> 1) In the upgrade clean up the reference for the HttpAcceptorHandler before removing the handler.
> 2) If option 1 does not work because that threads also send the keep alive for websocket, I could use the channelInactive from websocket handler to later unregister the handler
--
This message was sent by Atlassian Jira
(v8.3.4#803005)