[jira] [Commented] (SQOOP-367) codegen support free-form query

["Bilung Lee (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SQOOP-367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13133204#comment-13133204 ] 

Bilung Lee commented on SQOOP-367:
----------------------------------

Thanks for the patch!  Look very good overall.  Some minor stuff:
1. Use TABLE_ARG for "table" just like what you did with SQL_QUERY_ARG in the exception messages.
2. Run "ant checkstyle" in your sqoop directory and then check "checkstyle-errors.html" under "build" directory.  There are some style complains that need to be fixed.

                
> codegen support free-form query
> -------------------------------
>
>                 Key: SQOOP-367
>                 URL: https://issues.apache.org/jira/browse/SQOOP-367
>             Project: Sqoop
>          Issue Type: New Feature
>          Components: codegen
>    Affects Versions: 1.4.0-incubating
>         Environment: 64bit Ubuntu 10.10 Linux, Java build 1.6.0_24-b07, mysql 5.1.49-1ubuntu8.1
>            Reporter: guoyunsky
>            Assignee: guoyunsky
>              Labels: codegen, query, sqoop
>             Fix For: 1.4.0-incubating
>
>         Attachments: codegen-support-free-form-query.patch
>
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> Like the import tool,  support using free-form query or table to import datas.
> example:
> codegen --connect jdbc:mysql://localhost/sqoop_datas --username root --password 123456  --query 'select * from sqoop_source_datas where $CONDITIONS'  --hadoop-home=...

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira