You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@isis.apache.org by Stephen Cameron <st...@gmail.com> on 2015/12/13 22:45:47 UTC

upgrading to 1.11.0-SNAPSHOT issue

Hi,

I am upgrading to the 1.11.0-SNAPSHOT to make use of the JAXB integration.

I've encountered an issue with Calendars, getting a null-pointer exception.
It seems to be related to the following method in
org.isisaddons.wicket.fullcalendar2.cpt.ui.EventProviderAbstract returning
a null reference.

    private Object dereference(final Object domainObject) {
        final List<CalendarableDereferencingService>
calendarableDereferencingServices =
                getServicesInjector().lookupServices(
                        CalendarableDereferencingService.class);
        for (final CalendarableDereferencingService dereferencingService :
calendarableDereferencingServices) {
            final Object dereferencedObject =
dereferencingService.dereference(domainObject);
            if(dereferencedObject != domainObject) {
                return dereferencedObject;
            }
        }
        return domainObject;
    }

The only CalendarableDereferencingService implementation used/found is one
provided by the notes module. I suspect that the line should be

-              if( dereferencedObject != domainObject) {
+            if(dereferencedObject != null && dereferencedObject !=
domainObject) {
                return dereferencedObject;
            }

Thanks

Re: upgrading to 1.11.0-SNAPSHOT issue

Posted by Stephen Cameron <st...@gmail.com>.
Hi,

I've found source of my problems. I was using 1.10.0 calendar module
instead of 1.11.0-SNAPSHOT due to it being a dependency of the incode notes
module, whose pom still references 1.10.0 dependancies. Changing all those
to 1.11.0-SNAPSHOT means the null-pointer exception goes away (the code
might still be wrong, or not defensive enough :)).

I still can only see the calendar and maps if I run the app in prototype
mode (set in web.xml), in production mode both maps and calendars fail to
load. This is already a flagged issue in JIRA, I might try to tackle it.


Thanks






On Mon, Dec 14, 2015 at 8:48 AM, Dan Haywood <da...@haywood-associates.co.uk>
wrote:

> Hi Steve,
> yes I think you are right.
> Do you want to raise a pull request for that?
> Cheers, Dan
> On 13 Dec 2015 21:45, "Stephen Cameron" <st...@gmail.com>
> wrote:
>
> > Hi,
> >
> > I am upgrading to the 1.11.0-SNAPSHOT to make use of the JAXB
> integration.
> >
> > I've encountered an issue with Calendars, getting a null-pointer
> exception.
> > It seems to be related to the following method in
> > org.isisaddons.wicket.fullcalendar2.cpt.ui.EventProviderAbstract
> returning
> > a null reference.
> >
> >     private Object dereference(final Object domainObject) {
> >         final List<CalendarableDereferencingService>
> > calendarableDereferencingServices =
> >                 getServicesInjector().lookupServices(
> >                         CalendarableDereferencingService.class);
> >         for (final CalendarableDereferencingService dereferencingService
> :
> > calendarableDereferencingServices) {
> >             final Object dereferencedObject =
> > dereferencingService.dereference(domainObject);
> >             if(dereferencedObject != domainObject) {
> >                 return dereferencedObject;
> >             }
> >         }
> >         return domainObject;
> >     }
> >
> > The only CalendarableDereferencingService implementation used/found is
> one
> > provided by the notes module. I suspect that the line should be
> >
> > -              if( dereferencedObject != domainObject) {
> > +            if(dereferencedObject != null && dereferencedObject !=
> > domainObject) {
> >                 return dereferencedObject;
> >             }
> >
> > Thanks
> >
>

Re: upgrading to 1.11.0-SNAPSHOT issue

Posted by Dan Haywood <da...@haywood-associates.co.uk>.
Hi Steve,
yes I think you are right.
Do you want to raise a pull request for that?
Cheers, Dan
On 13 Dec 2015 21:45, "Stephen Cameron" <st...@gmail.com> wrote:

> Hi,
>
> I am upgrading to the 1.11.0-SNAPSHOT to make use of the JAXB integration.
>
> I've encountered an issue with Calendars, getting a null-pointer exception.
> It seems to be related to the following method in
> org.isisaddons.wicket.fullcalendar2.cpt.ui.EventProviderAbstract returning
> a null reference.
>
>     private Object dereference(final Object domainObject) {
>         final List<CalendarableDereferencingService>
> calendarableDereferencingServices =
>                 getServicesInjector().lookupServices(
>                         CalendarableDereferencingService.class);
>         for (final CalendarableDereferencingService dereferencingService :
> calendarableDereferencingServices) {
>             final Object dereferencedObject =
> dereferencingService.dereference(domainObject);
>             if(dereferencedObject != domainObject) {
>                 return dereferencedObject;
>             }
>         }
>         return domainObject;
>     }
>
> The only CalendarableDereferencingService implementation used/found is one
> provided by the notes module. I suspect that the line should be
>
> -              if( dereferencedObject != domainObject) {
> +            if(dereferencedObject != null && dereferencedObject !=
> domainObject) {
>                 return dereferencedObject;
>             }
>
> Thanks
>