[GitHub] [spark] itholic commented on a change in pull request #33911: [SPARK-36653][PYTHON] implement Series.__xor__

[GitBox <gi...@apache.org>]

itholic commented on a change in pull request #33911:
URL: https://github.com/apache/spark/pull/33911#discussion_r703223642



##########
File path: python/pyspark/pandas/tests/test_series.py
##########
@@ -2950,6 +2950,30 @@ def _test_cov(self, pdf):
         pscov = psdf["s1"].cov(psdf["s2"], min_periods=4)
         self.assert_eq(pcov, pscov, almost=True)
 
+    def test_xor(self):
+        df = pd.DataFrame([[True, True], [True, False]])
+        sdf = ps.from_pandas(df)

Review comment:
       nit: Can we use `pdf` rather then `df`, and `psdf` rather than `sdf` ??
   
   Not strictly forced, but we usually use the following rule in our code base to distinguish them:
   - `pdf` for pandas DataFrame
   - `sdf` for Spark DataFrame 
   - `psdf` for pandas-on-Spark DataFrame




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org