You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by SebastianCarroll <gi...@git.apache.org> on 2017/10/07 17:48:50 UTC

[GitHub] nifi issue #2154: NIFI-2663: Add WebSocket support for MQTT processors

Github user SebastianCarroll commented on the issue:

    https://github.com/apache/nifi/pull/2154
  
    I've added  an abstract `getUri` method which allows me to subclass `TestConsumeMQTT` -> `TestConsumeMqttWS` and `TestConsumeMqttSSL` -> `TestConsumeMqttWSS` and only override the getUri method to return the `ws://` and `wss://` protocols respectively but still run the same set of tests for the base classes. 
    
    This approach is currently failing with the error `java.io.IOException: WebSocket Response header: Invalid response from Server, It may not support WebSockets.`. Initially I thought that the Moquette server may not support WebSockets but on closer inspection it looks like a misconfiguration.
    
    Putting aside the current test failures, does this subclassing test strategy make sense?


---