You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "hermanschaaf (via GitHub)" <gi...@apache.org> on 2023/04/19 07:44:34 UTC
[GitHub] [arrow] hermanschaaf opened a new pull request, #35231: [Go] Fix skip argument to Callers
hermanschaaf opened a new pull request, #35231:
URL: https://github.com/apache/arrow/pull/35231
Follow-up to https://github.com/apache/arrow/pull/35215. It's mostly cosmetic, but without the additional 2 skips passed in to `Callers`, the Caller frame is repeated in the stack trace, and one frame below it is added as well. With this change, the checked allocator stack trace contains no duplicates.
I had this change locally but didn't realize it wasn't pushed to the PR branch, sorry about that :bow:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35231: GH-35234: [Go] Fix skip argument to Callers
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35231:
URL: https://github.com/apache/arrow/pull/35231#issuecomment-1514435984
:warning: GitHub issue #35234 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] hermanschaaf commented on pull request #35231: GH-35234: [Go] Fix skip argument to Callers
Posted by "hermanschaaf (via GitHub)" <gi...@apache.org>.
hermanschaaf commented on PR #35231:
URL: https://github.com/apache/arrow/pull/35231#issuecomment-1517998463
@zeroshade Just updated to the latest main; looks like all the tests passed except for `Go / AMD64 Debian 11 Go 1.18`. The test failure still seems unrelated to this PR:
```
--- FAIL: TestPreparedStatementNoSchema (0.01s)
driver_test.go:744:
Error Trace: /arrow/go/arrow/flight/flightsql/driver/driver_test.go:744
Error: Received unexpected error:
EOF
Test: TestPreparedStatementNoSchema
FAIL
FAIL github.com/apache/arrow/go/v12/arrow/flight/flightsql/driver 1.150s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35231: GH-35234: [Go] Fix skip argument to Callers
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35231:
URL: https://github.com/apache/arrow/pull/35231#issuecomment-1518937114
Benchmark runs are scheduled for baseline = 1a697abd08d6db6ac1496e548dcdb86a9a82c152 and contender = c48916a537d8279485c5e30cb85af7451383e39d. c48916a537d8279485c5e30cb85af7451383e39d is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/ee7718732b3a477482bc73758ec3ad92...f04b2a4872cb4497aa0e6a4a2496614b/)
[Failed] [test-mac-arm](https://conbench.ursa.dev/compare/runs/3269fdd33074413db254784b3308cb30...17c44c05e4134bbeab6f9ba1a4514acb/)
[Finished :arrow_down:1.02% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/c6a1ce87c70f420dba28c9957645e98f...184ba6c7d5e745f19a0ef5ca4e44fb38/)
[Finished :arrow_down:0.15% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/34f67b0ba3e44d958cd1e65f0d0865f8...80cc530b44cc4d5db5b83e5015f64088/)
Buildkite builds:
[Finished] [`c48916a5` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2766)
[Failed] [`c48916a5` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2800)
[Finished] [`c48916a5` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2764)
[Finished] [`c48916a5` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2791)
[Finished] [`1a697abd` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2765)
[Failed] [`1a697abd` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2799)
[Finished] [`1a697abd` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2763)
[Finished] [`1a697abd` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2790)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade merged pull request #35231: GH-35234: [Go] Fix skip argument to Callers
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade merged PR #35231:
URL: https://github.com/apache/arrow/pull/35231
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on pull request #35231: GH-35234: [Go] Fix skip argument to Callers
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on PR #35231:
URL: https://github.com/apache/arrow/pull/35231#issuecomment-1517950526
@hermanschaaf can you try rebaseing from main and seeing if that alleviates the test failure?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35231: [Go] Fix skip argument to Callers
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35231:
URL: https://github.com/apache/arrow/pull/35231#issuecomment-1514284571
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35231: GH-35234: [Go] Fix skip argument to Callers
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35231:
URL: https://github.com/apache/arrow/pull/35231#issuecomment-1514435909
* Closes: #35234
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] disq commented on pull request #35231: GH-35234: [Go] Fix skip argument to Callers
Posted by "disq (via GitHub)" <gi...@apache.org>.
disq commented on PR #35231:
URL: https://github.com/apache/arrow/pull/35231#issuecomment-1516494266
Test failure doesn't seem relevant
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org