You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Dian Fu <di...@gmail.com> on 2015/07/04 04:51:27 UTC
Review Request 36175: Sqoop2: Tool: Load repository dump into a
different repository
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36175/
-----------------------------------------------------------
Review request for Sqoop.
Bugs: SQOOP-1256
https://issues.apache.org/jira/browse/SQOOP-1256
Repository: sqoop-sqoop2
Description
-------
Load repository dump into a different repository
Diffs
-----
tools/src/main/java/org/apache/sqoop/tools/tool/JSONConstants.java 9301707
tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java a25ebe8
Diff: https://reviews.apache.org/r/36175/diff/
Testing
-------
Thanks,
Dian Fu
Re: Review Request 36175: Sqoop2: Tool: Load repository dump into a
different repository
Posted by Dian Fu <di...@gmail.com>.
> On July 23, 2015, 1:39 a.m., Abraham Elmahrek wrote:
> > Seems cool! Just a few more comments and I think we're good.
> >
> > As a follow up, can we also add testing for this tool? And specifically this functionality?
Yes, of course. Have created SQOOP-2423 for this.
- Dian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36175/#review92702
-----------------------------------------------------------
On July 23, 2015, 1:52 a.m., Dian Fu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36175/
> -----------------------------------------------------------
>
> (Updated July 23, 2015, 1:52 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1256
> https://issues.apache.org/jira/browse/SQOOP-1256
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Load repository dump into a different repository
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/json/SubmissionBean.java ad05057
> tools/src/main/java/org/apache/sqoop/tools/tool/JSONConstants.java 9301707
> tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java 1027baf
> tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java a25ebe8
>
> Diff: https://reviews.apache.org/r/36175/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dian Fu
>
>
Re: Review Request 36175: Sqoop2: Tool: Load repository dump into a
different repository
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36175/#review92702
-----------------------------------------------------------
Ship it!
Seems cool! Just a few more comments and I think we're good.
As a follow up, can we also add testing for this tool? And specifically this functionality?
common/src/main/java/org/apache/sqoop/json/SubmissionBean.java (line 47)
<https://reviews.apache.org/r/36175/#comment146942>
Can we add "job-id" separately and mark "job" as deprecated (but still provide it?). I ask because consumers of this API (such as Hue can use it).
tools/src/main/java/org/apache/sqoop/tools/tool/JSONConstants.java (line 34)
<https://reviews.apache.org/r/36175/#comment146941>
You can kill this off since it's not being used any more.
- Abraham Elmahrek
On July 20, 2015, 10:10 a.m., Dian Fu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36175/
> -----------------------------------------------------------
>
> (Updated July 20, 2015, 10:10 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1256
> https://issues.apache.org/jira/browse/SQOOP-1256
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Load repository dump into a different repository
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/json/SubmissionBean.java ad05057
> tools/src/main/java/org/apache/sqoop/tools/tool/JSONConstants.java 9301707
> tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java 1027baf
> tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java a25ebe8
>
> Diff: https://reviews.apache.org/r/36175/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dian Fu
>
>
Re: Review Request 36175: Sqoop2: Tool: Load repository dump into a
different repository
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36175/#review92712
-----------------------------------------------------------
A couple of more comments.
common/src/main/java/org/apache/sqoop/json/SubmissionBean.java (line 47)
<https://reviews.apache.org/r/36175/#comment146947>
Kill white space
common/src/main/java/org/apache/sqoop/json/SubmissionBean.java (line 107)
<https://reviews.apache.org/r/36175/#comment146948>
Need to set JOB_ID and JOB. If JOB and JOB_ID is set when restoring, then JOB_ID would take precedence.
- Abraham Elmahrek
On July 23, 2015, 1:52 a.m., Dian Fu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36175/
> -----------------------------------------------------------
>
> (Updated July 23, 2015, 1:52 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1256
> https://issues.apache.org/jira/browse/SQOOP-1256
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Load repository dump into a different repository
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/json/SubmissionBean.java ad05057
> tools/src/main/java/org/apache/sqoop/tools/tool/JSONConstants.java 9301707
> tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java 1027baf
> tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java a25ebe8
>
> Diff: https://reviews.apache.org/r/36175/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dian Fu
>
>
Re: Review Request 36175: Sqoop2: Tool: Load repository dump into a
different repository
Posted by Dian Fu <di...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36175/
-----------------------------------------------------------
(Updated July 23, 2015, 5:18 a.m.)
Review request for Sqoop.
Bugs: SQOOP-1256
https://issues.apache.org/jira/browse/SQOOP-1256
Repository: sqoop-sqoop2
Description
-------
Load repository dump into a different repository
Diffs (updated)
-----
common/src/main/java/org/apache/sqoop/json/SubmissionBean.java ad05057
tools/src/main/java/org/apache/sqoop/tools/tool/JSONConstants.java 9301707
tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java 1027baf
tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java a25ebe8
Diff: https://reviews.apache.org/r/36175/diff/
Testing
-------
Thanks,
Dian Fu
Re: Review Request 36175: Sqoop2: Tool: Load repository dump into a
different repository
Posted by Dian Fu <di...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36175/
-----------------------------------------------------------
(Updated July 23, 2015, 1:52 a.m.)
Review request for Sqoop.
Bugs: SQOOP-1256
https://issues.apache.org/jira/browse/SQOOP-1256
Repository: sqoop-sqoop2
Description
-------
Load repository dump into a different repository
Diffs (updated)
-----
common/src/main/java/org/apache/sqoop/json/SubmissionBean.java ad05057
tools/src/main/java/org/apache/sqoop/tools/tool/JSONConstants.java 9301707
tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java 1027baf
tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java a25ebe8
Diff: https://reviews.apache.org/r/36175/diff/
Testing
-------
Thanks,
Dian Fu
Re: Review Request 36175: Sqoop2: Tool: Load repository dump into a
different repository
Posted by Dian Fu <di...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36175/
-----------------------------------------------------------
(Updated July 20, 2015, 10:10 a.m.)
Review request for Sqoop.
Bugs: SQOOP-1256
https://issues.apache.org/jira/browse/SQOOP-1256
Repository: sqoop-sqoop2
Description
-------
Load repository dump into a different repository
Diffs (updated)
-----
common/src/main/java/org/apache/sqoop/json/SubmissionBean.java ad05057
tools/src/main/java/org/apache/sqoop/tools/tool/JSONConstants.java 9301707
tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java 1027baf
tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java a25ebe8
Diff: https://reviews.apache.org/r/36175/diff/
Testing
-------
Thanks,
Dian Fu
Re: Review Request 36175: Sqoop2: Tool: Load repository dump into a
different repository
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36175/#review91728
-----------------------------------------------------------
If a user supplies a custom connector, the repository load/dump tool will not work. The IDs for the connector and its configs might be out of place for example. Would it be possible to extend the name -> id code to the other objects as well? Can be a separate Jira.
- Abraham Elmahrek
On July 13, 2015, 10:42 a.m., Dian Fu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36175/
> -----------------------------------------------------------
>
> (Updated July 13, 2015, 10:42 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1256
> https://issues.apache.org/jira/browse/SQOOP-1256
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Load repository dump into a different repository
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/json/SubmissionBean.java ad05057
> tools/src/main/java/org/apache/sqoop/tools/tool/JSONConstants.java 9301707
> tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java 1027baf
> tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java a25ebe8
>
> Diff: https://reviews.apache.org/r/36175/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dian Fu
>
>
Re: Review Request 36175: Sqoop2: Tool: Load repository dump into a
different repository
Posted by Dian Fu <di...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36175/
-----------------------------------------------------------
(Updated July 13, 2015, 10:42 a.m.)
Review request for Sqoop.
Bugs: SQOOP-1256
https://issues.apache.org/jira/browse/SQOOP-1256
Repository: sqoop-sqoop2
Description
-------
Load repository dump into a different repository
Diffs (updated)
-----
common/src/main/java/org/apache/sqoop/json/SubmissionBean.java ad05057
tools/src/main/java/org/apache/sqoop/tools/tool/JSONConstants.java 9301707
tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java 1027baf
tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java a25ebe8
Diff: https://reviews.apache.org/r/36175/diff/
Testing
-------
Thanks,
Dian Fu
Re: Review Request 36175: Sqoop2: Tool: Load repository dump into a
different repository
Posted by Dian Fu <di...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36175/#review90422
-----------------------------------------------------------
Please ignore the current patch as it's incomplete. Will update the patch ASAP.
- Dian Fu
On July 4, 2015, 2:51 a.m., Dian Fu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36175/
> -----------------------------------------------------------
>
> (Updated July 4, 2015, 2:51 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1256
> https://issues.apache.org/jira/browse/SQOOP-1256
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Load repository dump into a different repository
>
>
> Diffs
> -----
>
> tools/src/main/java/org/apache/sqoop/tools/tool/JSONConstants.java 9301707
> tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java a25ebe8
>
> Diff: https://reviews.apache.org/r/36175/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dian Fu
>
>