You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2019/07/31 13:24:28 UTC
[GitHub] [kylin] nichunen commented on a change in pull request #764:
KYLIN-4101: set hive and spark job name when building cube
nichunen commented on a change in pull request #764: KYLIN-4101: set hive and spark job name when building cube
URL: https://github.com/apache/kylin/pull/764#discussion_r309217283
##########
File path: core-common/src/test/java/org/apache/kylin/common/util/HiveCmdBuilderTest.java
##########
@@ -59,14 +59,14 @@ public void testHiveCLI() {
hiveProps.put("hive.execution.engine", "mr");
Map<String, String> hivePropsOverwrite = new HashMap<>();
hivePropsOverwrite.put("hive.execution.engine", "tez");
- HiveCmdBuilder hiveCmdBuilder = new HiveCmdBuilder();
+ HiveCmdBuilder hiveCmdBuilder = new HiveCmdBuilder("test HiveCLI");
hiveCmdBuilder.addStatement("USE default;");
hiveCmdBuilder.addStatement("DROP TABLE `test`;");
hiveCmdBuilder.addStatement("SHOW\n TABLES;");
hiveCmdBuilder.setHiveConfProps(hiveProps);
hiveCmdBuilder.overwriteHiveProps(hivePropsOverwrite);
assertEquals(
- "hive -e \"USE default;\nDROP TABLE \\`test\\`;\nSHOW\n TABLES;\n\" --hiveconf hive.execution.engine=tez",
+ "hive -e \"set set mapred.job.name='test HiveCLI';\nUSE default;\nDROP TABLE \\`test\\`;\nSHOW\n TABLES;\n\" --hiveconf hive.execution.engine=tez",
Review comment:
why "set" twice?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services