You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by ap...@apache.org on 2015/04/02 23:24:50 UTC

[4/4] hbase git commit: HBASE-13388 Handling NullPointer in ZKProcedureMemberRpcs while getting ZNode data (Vikas Vishwakarma)

HBASE-13388 Handling NullPointer in ZKProcedureMemberRpcs while getting ZNode data (Vikas Vishwakarma)


Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/2ec3443f
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/2ec3443f
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/2ec3443f

Branch: refs/heads/0.98
Commit: 2ec3443f07c022516b538596a41dc7f6f78d26d1
Parents: 27ec6bc
Author: Andrew Purtell <ap...@apache.org>
Authored: Thu Apr 2 14:17:26 2015 -0700
Committer: Andrew Purtell <ap...@apache.org>
Committed: Thu Apr 2 14:18:15 2015 -0700

----------------------------------------------------------------------
 .../org/apache/hadoop/hbase/procedure/ZKProcedureMemberRpcs.java   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hbase/blob/2ec3443f/hbase-server/src/main/java/org/apache/hadoop/hbase/procedure/ZKProcedureMemberRpcs.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/procedure/ZKProcedureMemberRpcs.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/procedure/ZKProcedureMemberRpcs.java
index 9918d11..dd26328 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/procedure/ZKProcedureMemberRpcs.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/procedure/ZKProcedureMemberRpcs.java
@@ -200,7 +200,6 @@ public class ZKProcedureMemberRpcs implements ProcedureMemberRpcs {
     Subprocedure subproc = null;
     try {
       byte[] data = ZKUtil.getData(zkController.getWatcher(), path);
-      LOG.debug("start proc data length is " + data.length);
       if (!ProtobufUtil.isPBMagicPrefix(data)) {
         String msg = "Data in for starting procuedure " + opName +
           " is illegally formatted (no pb magic). " +
@@ -208,6 +207,7 @@ public class ZKProcedureMemberRpcs implements ProcedureMemberRpcs {
         LOG.error(msg);
         throw new IllegalArgumentException(msg);
       }
+      LOG.debug("start proc data length is " + data.length);
       data = Arrays.copyOfRange(data, ProtobufUtil.lengthOfPBMagic(), data.length);
       LOG.debug("Found data for znode:" + path);
       subproc = member.createSubprocedure(opName, data);