You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by greghogan <gi...@git.apache.org> on 2016/02/21 05:13:18 UTC

[GitHub] flink pull request: 3385 fix outer join skipping unprobed partitio...

GitHub user greghogan opened a pull request:

    https://github.com/apache/flink/pull/1680

    3385 fix outer join skipping unprobed partitions

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/greghogan/flink 3385_fix_outer_join_skipping_unprobed_partitions

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1680.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1680
    
----
commit 98407afb11dc092070d495c133d4065cdaaa36f3
Author: Greg Hogan <co...@greghogan.com>
Date:   2016-02-19T21:08:22Z

    [hotfix] [runtime] Fix processing unmatched build-side when all buckets spilled

commit aec0094e84fbc942eab156da64aa00f322c4f77e
Author: Greg Hogan <co...@greghogan.com>
Date:   2016-02-19T19:59:33Z

    [FLINK-3385] [runtime] Fix outer join skipping unprobed partitions

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3385] [runtime] Fix outer join skipping...

Posted by fhueske <gi...@git.apache.org>.

Github user fhueske commented on the pull request:

    https://github.com/apache/flink/pull/1680#issuecomment-187448014
  
    Thanks for the fix! Will merge this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3385] [runtime] Fix outer join skipping...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/1680


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3385] [runtime] Fix outer join skipping...

Posted by greghogan <gi...@git.apache.org>.

Github user greghogan commented on the pull request:

    https://github.com/apache/flink/pull/1680#issuecomment-187258482
  
    Unprobed, spilled partitions are now retained when performing a build-side outer join (and still discarded in all other cases).
    
    When these unprobed, spilled partitions are loaded by `MutableHashTable.prepareNextPartition` we simply create an iterator over the spilled segments which are read by the appropriate HashJoinIterator in a single loop.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3385] [runtime] Fix outer join skipping...

Posted by hsaputra <gi...@git.apache.org>.

Github user hsaputra commented on the pull request:

    https://github.com/apache/flink/pull/1680#issuecomment-187253798
  
    Could add description on how is the fix being done and proposed result. Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---