[jira] [Created] (SPARK-24834) Utils#nanSafeCompare{Double,Float} functions do not differ from normal java double/float comparison

["Benjamin Duffield (JIRA)" <ji...@apache.org>]

Benjamin Duffield created SPARK-24834:
-----------------------------------------

             Summary: Utils#nanSafeCompare{Double,Float} functions do not differ from normal java double/float comparison
                 Key: SPARK-24834
                 URL: https://issues.apache.org/jira/browse/SPARK-24834
             Project: Spark
          Issue Type: Improvement
          Components: Spark Core
    Affects Versions: 2.3.2
            Reporter: Benjamin Duffield


Utils.scala contains two functions `nanSafeCompareDoubles` and `nanSafeCompareFloats` which purport to have special handling of NaN values in comparisons.

The handling in these functions do not appear to differ from java.lang.Double.compare and java.lang.Float.compare - they seem to produce identical output to the built-in java comparison functions.

I think it's clearer to not have these special Utils functions, and instead just use the standard java comparison functions.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org