You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@arrow.apache.org by "Jeroen van Straten (Jira)" <ji...@apache.org> on 2022/07/07 10:14:00 UTC

[jira] [Updated] (ARROW-16987) [C++] Refactor Substrait ToProto/FromProto to visitor pattern

     [ https://issues.apache.org/jira/browse/ARROW-16987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jeroen van Straten updated ARROW-16987:
---------------------------------------
    Summary: [C++] Refactor Substrait ToProto/FromProto to visitor pattern  (was: Refactor Substrait ToProto/FromProto to visitor pattern)

> [C++] Refactor Substrait ToProto/FromProto to visitor pattern
> -------------------------------------------------------------
>
>                 Key: ARROW-16987
>                 URL: https://issues.apache.org/jira/browse/ARROW-16987
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>            Reporter: Jeroen van Straten
>            Priority: Major
>              Labels: substrait
>
> Currently, the conversion between Acero and Substrait plans is done ad hoc using various overloads of the ToProto and FromProto functions. Code quality may benefit from refactoring this to a visitor pattern, to make it more easy to track state (ExtensionSet), store conversion options, maybe make multiple implementations in the future via inheritance, etc.
> It's probably better to do this sooner rather than later (if we're going to do it).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)