[jira] [Commented] (TINKERPOP-2303) GremlinDsl generate addV instead of addE

["Stephen Mallette (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TINKERPOP-2303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16942688#comment-16942688 ] 

Stephen Mallette commented on TINKERPOP-2303:
---------------------------------------------

Thanks for reporting this. That's a really bad bug. Do you intend to submit a pull request or would you just like me to correct it? Note that we are firming up for release right now, so if you do intend to submit a pull request it would be best to get it in before the end of the week. Also, if you do submit the pull request, please submit to the {{tp33}} branch. 

> GremlinDsl generate addV instead of addE
> ----------------------------------------
>
>                 Key: TINKERPOP-2303
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2303
>             Project: TinkerPop
>          Issue Type: Bug
>          Components: process
>    Affects Versions: 3.4.3
>            Reporter: ali ammar
>            Priority: Minor
>
> in GremlinDslProcessor class , when generating traversalSource 
> at generateTraversalSource method addV should be replaced by addE 
> {quote} 
> traversalSourceClass.addMethod(MethodSpec.methodBuilder("{color:#00875a}addE{color}")
>  .addModifiers(Modifier.PUBLIC)
>  .addAnnotation(Override.class)
>  .addParameter(String.class, "label")
>  .addStatement("$N clone = this.clone()", ctx.traversalSourceClazz)
>  .addStatement("clone.getBytecode().addStep($T.{color:#FF0000}*addV*{color}, label)", GraphTraversal.Symbols.class)
>  .addStatement("$N traversal = new $N(clone)", ctx.defaultTraversalClazz, ctx.defaultTraversalClazz)
>  .addStatement("return ($T) traversal.asAdmin().addStep(new $T(traversal, label))", ctx.traversalClassName, AddEdgeStartStep.class)
>  .returns(ParameterizedTypeName.get(ctx.traversalClassName, ClassName.get(Edge.class), ClassName.get(Edge.class)))
>  .build());
> {quote}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)