You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/08/16 16:59:18 UTC

[GitHub] [kafka] lbradstreet opened a new pull request #9187: MINOR: bump mockito to 3.5.0

lbradstreet opened a new pull request #9187:
URL: https://github.com/apache/kafka/pull/9187


   3.5.0 no longer uses any reflection and is backwards compatible. The lack of reflection could be helpful when writing jmh benchmark tests as often these mocks can completely throw off benchmark results and require some finagling to be more respresentative.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] lbradstreet closed pull request #9187: MINOR: bump mockito to 3.5.0

Posted by GitBox <gi...@apache.org>.
lbradstreet closed pull request #9187:
URL: https://github.com/apache/kafka/pull/9187


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ijuma commented on pull request #9187: MINOR: bump mockito to 3.5.0

Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #9187:
URL: https://github.com/apache/kafka/pull/9187#issuecomment-678682051


   Looks like 3.5.2 is the latest version https://search.maven.org/artifact/org.mockito/mockito-core/3.5.2/jar


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] lbradstreet commented on pull request #9187: MINOR: bump mockito to 3.5.0

Posted by GitBox <gi...@apache.org>.
lbradstreet commented on pull request #9187:
URL: https://github.com/apache/kafka/pull/9187#issuecomment-674551252


   I thought this might be useful for jmh benchmarks as reflection can often throw us off. I'm not sure we use the inline mock maker anywhere though.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ijuma commented on pull request #9187: MINOR: bump mockito to 3.5.0

Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #9187:
URL: https://github.com/apache/kafka/pull/9187#issuecomment-678681985


   I don't think we use the inline mock maker.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ijuma commented on pull request #9187: MINOR: bump mockito to 3.5.0

Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #9187:
URL: https://github.com/apache/kafka/pull/9187#issuecomment-678681961


   ok to test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org