You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildstream.apache.org by "nanonyme (via GitHub)" <gi...@apache.org> on 2024/05/02 17:09:48 UTC

[I] Hang when duplicate keys defined in element [buildstream]

nanonyme opened a new issue, #1917:
URL: https://github.com/apache/buildstream/issues/1917

   Noticed with BuildStream 2.2.0
   
   ```
   [12:40:35][--:--:--][        ][    main:core activity                 ] START   Build
   [12:40:35][--:--:--][        ][    main:core activity                 ] START   Loading elements
   [12:40:36][--:--:--][        ][    main:core activity                 ] BUG     Duplicate key (@) at line 26 column 0
       Traceback (most recent call last):
         File "/usr/lib/python3.11/site-packages/buildstream/_loader/loader.py", line 409, in _load_one_file
           element = self._elements[filename]
                     ~~~~~~~~~~~~~~^^^^^^^^^^
       KeyError: 'extensions/vulkaninfo/vulkan-tools.bst'
       
       During handling of the above exception, another exception occurred:
       
       buildstream._yaml.YAMLLoadError: Duplicate key (@) at line 26 column 0
   ```
   BuildStream doesn't correctly handle the raised exception but instead hits BUG and promptly hangs after this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Hang when duplicate keys defined in element [buildstream]

Posted by "nanonyme (via GitHub)" <gi...@apache.org>.
nanonyme commented on issue #1917:
URL: https://github.com/apache/buildstream/issues/1917#issuecomment-2093500881

   https://gitlab.com/freedesktop-sdk/freedesktop-sdk/-/commit/e71cbc8432df1f5058cc11d1109d32a3ad7c4f73


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Hang when duplicate keys defined in element [buildstream]

Posted by "abderrahim (via GitHub)" <gi...@apache.org>.
abderrahim commented on issue #1917:
URL: https://github.com/apache/buildstream/issues/1917#issuecomment-2091165394

   Please post the freedesktop-sdk commit to reproduce this. It would help fix it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Hang when duplicate keys defined in element [buildstream]

Posted by "nanonyme (via GitHub)" <gi...@apache.org>.
nanonyme commented on issue #1917:
URL: https://github.com/apache/buildstream/issues/1917#issuecomment-2093502779

   You don't have to use the custom config template to reproduce. It's enough to use BuildStream 2.2.0 and that commit.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Hang when duplicate keys defined in element [buildstream]

Posted by "abderrahim (via GitHub)" <gi...@apache.org>.
abderrahim commented on issue #1917:
URL: https://github.com/apache/buildstream/issues/1917#issuecomment-2094117753

   Yes, indeed. On my system I have
   ```
   ruamel.yaml        0.17.21
   ruamel.yaml.clib   0.2.7
   ```
   
   In the container
   ```
   ruamel.yaml                 0.18.6
   ruamel.yaml.clib            0.2.8
   ```
   
   However, upgrading to the same version on my system I keep getting the same behaviour (a proper FAILURE, not a BUG with a hang).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Hang when duplicate keys defined in element [buildstream]

Posted by "nanonyme (via GitHub)" <gi...@apache.org>.
nanonyme commented on issue #1917:
URL: https://github.com/apache/buildstream/issues/1917#issuecomment-2094090202

   Is there a difference in ruamel.yaml or ruamel.yaml.clib versions?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Hang when duplicate keys defined in element [buildstream]

Posted by "nanonyme (via GitHub)" <gi...@apache.org>.
nanonyme commented on issue #1917:
URL: https://github.com/apache/buildstream/issues/1917#issuecomment-2094130076

   This is so odd. While there may be a difference in Cython used, I don't expect it to affect quite that.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Hang when duplicate keys defined in element [buildstream]

Posted by "abderrahim (via GitHub)" <gi...@apache.org>.
abderrahim commented on issue #1917:
URL: https://github.com/apache/buildstream/issues/1917#issuecomment-2094075629

   This is indeed weird. I can't reproduce it using my host install of buildstream (installed using pipx). However, using the CI container used in that commit I can reproduce it.
   
   The error itself looks like we're leaking a `YAMLLoadError` which should be caught within the `_yaml` module. Reading the code, I suspect it's a typo here https://github.com/apache/buildstream/blob/c7274d41d0d0af87cc2081d67589841e8e16b592/src/buildstream/_yaml.pyx#L287, where should be `YAMLLoadError` instead of `LoadError`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org