You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kibble.apache.org by hu...@apache.org on 2018/09/09 14:06:35 UTC

[kibble-scanners] branch master updated (6aff99d -> 52fbb8e)

This is an automated email from the ASF dual-hosted git repository.

humbedooh pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/kibble-scanners.git.


    from 6aff99d  bump default limits for tone/mood analysis
     new 899a751  closer may be null for imported issues
     new 52fbb8e  handle closer key errors properly

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 src/plugins/scanners/jira.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


[kibble-scanners] 02/02: handle closer key errors properly

Posted by hu...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

humbedooh pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kibble-scanners.git

commit 52fbb8e79a2492011f46918a1a31827f7757db29
Author: Daniel Gruno <hu...@apache.org>
AuthorDate: Sun Sep 9 16:06:20 2018 +0200

    handle closer key errors properly
    
    it's a dict...
---
 src/plugins/scanners/jira.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/plugins/scanners/jira.py b/src/plugins/scanners/jira.py
index cb1ba75..82703bc 100644
--- a/src/plugins/scanners/jira.py
+++ b/src/plugins/scanners/jira.py
@@ -81,7 +81,7 @@ def wasclosed(js):
             if 'items' in citem:
                 for item in citem['items']:
                     if item['field'] == 'status' and (item['toString'].lower().find('closed') != -1 or item['toString'].lower().find('resolved') != -1):
-                        return (True, citem.get('author', 'Unknown'))
+                        return (True, citem.get('author', {}))
     else:
         if 'items' in js:
             for item in js['items']:
@@ -162,7 +162,7 @@ def scanTicket(KibbleBit, key, u, source, creds, openTickets):
         if closer:
             #print("Parsing closer")
             closerEmail = closer.get('emailAddress', 'unknown@kibble').replace(" dot ", ".", 10).replace(" at ", "@", 1)
-            displayName = closer['displayName']
+            displayName = closer.get('displayName', 'Unkown')
             if displayName and len(displayName) > 0:
                 # Add to people db
                 pid = hashlib.sha1( ("%s%s" % (source['organisation'], closerEmail)).encode('ascii', errors='replace')).hexdigest()


[kibble-scanners] 01/02: closer may be null for imported issues

Posted by hu...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

humbedooh pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kibble-scanners.git

commit 899a7511473e7cd27adc64a637401daa5210c465
Author: Daniel Gruno <hu...@apache.org>
AuthorDate: Sun Sep 9 16:05:23 2018 +0200

    closer may be null for imported issues
---
 src/plugins/scanners/jira.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/plugins/scanners/jira.py b/src/plugins/scanners/jira.py
index fd8209f..cb1ba75 100644
--- a/src/plugins/scanners/jira.py
+++ b/src/plugins/scanners/jira.py
@@ -81,7 +81,7 @@ def wasclosed(js):
             if 'items' in citem:
                 for item in citem['items']:
                     if item['field'] == 'status' and (item['toString'].lower().find('closed') != -1 or item['toString'].lower().find('resolved') != -1):
-                        return (True, citem['author'])
+                        return (True, citem.get('author', 'Unknown'))
     else:
         if 'items' in js:
             for item in js['items']: