You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Michael Stockton (JIRA)" <ji...@apache.org> on 2011/06/14 16:12:47 UTC

[jira] [Commented] (THRIFT-1204) Ruby autogenerated files should require 'thrift' gem

    [ https://issues.apache.org/jira/browse/THRIFT-1204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13049193#comment-13049193 ] 

Michael Stockton commented on THRIFT-1204:
------------------------------------------

I'm not sure that rubygems should be required from within stub files. You're assuming that the user wants to use rubygems throughout their program which may not be the case. 




> Ruby autogenerated files should require 'thrift' gem
> ----------------------------------------------------
>
>                 Key: THRIFT-1204
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1204
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Ruby - Compiler
>    Affects Versions: 0.6.1
>         Environment: All
>            Reporter: Ilya Maykov
>            Assignee: Ilya Maykov
>            Priority: Minor
>         Attachments: THRIFT-1204-require-thrift-in-gen-rb-files.patch
>
>
> The gen-rb files currently don't require the thrift gem. This means that the user of such a file must explicitly require 'thrift' in his code before requiring a gen-rb file, which can be a bit annoying (especially when debugging / experimenting in IRB). I propose that we change the compiler to add the require at the top of every gen-rb file.
> Patch coming shortly.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira