You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by knusbaum <gi...@git.apache.org> on 2015/10/14 23:01:27 UTC

[GitHub] storm pull request: STORM-702: Exhibitor support

Github user knusbaum commented on a diff in the pull request:

    https://github.com/apache/storm/pull/432#discussion_r42052527
  
    --- Diff: storm-core/src/jvm/backtype/storm/utils/Utils.java ---
    @@ -306,7 +327,30 @@ public static ComponentCommon getComponentCommon(StormTopology topology, String
             }
             throw new IllegalArgumentException("Could not find component with id " + id);
         }
    -    
    +
    +    public static List<String> getStrings(final Object o) {
    +        if (o == null) {
    +            return Collections.emptyList();
    --- End diff --
    
    All of the other lists here are mutable, but this isn't. 
    I'd rather see a new ArrayList, since it's a public method.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---