You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Jayapal Reddy <ja...@citrix.com> on 2013/04/23 12:55:46 UTC
Review Request: Updated the user permission to acquire ip
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10727/
-----------------------------------------------------------
Review request for cloudstack, Abhinandan Prateek and Murali Reddy.
Description
-------
Updated the user permissions check
This addresses bug CLOUDSTACK-2134.
Diffs
-----
server/src/com/cloud/network/NetworkServiceImpl.java ac2ac45
Diff: https://reviews.apache.org/r/10727/diff/
Testing
-------
Unit tested on basic and advanced zone
Thanks,
Jayapal Reddy
Re: Review Request: Updated the user permission to acquire ip
Posted by Abhinandan Prateek <ap...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10727/#review21969
-----------------------------------------------------------
Ship it!
Ship It!
- Abhinandan Prateek
On April 25, 2013, 8:43 a.m., Jayapal Reddy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10727/
> -----------------------------------------------------------
>
> (Updated April 25, 2013, 8:43 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Murali Reddy.
>
>
> Description
> -------
>
> Updated the user permissions check
>
>
> This addresses bug CLOUDSTACK-2134.
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/NetworkServiceImpl.java 7653a08
>
> Diff: https://reviews.apache.org/r/10727/diff/
>
>
> Testing
> -------
>
> Unit tested on basic and advanced zone
>
>
> Thanks,
>
> Jayapal Reddy
>
>
Re: Review Request: Updated the user permission to acquire ip
Posted by Nitin Mehta <ni...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10727/#review19622
-----------------------------------------------------------
server/src/com/cloud/network/NetworkServiceImpl.java
<https://reviews.apache.org/r/10727/#comment40532>
Can we not use @ACL annotation for this ?
- Nitin Mehta
On April 25, 2013, 8:43 a.m., Jayapal Reddy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10727/
> -----------------------------------------------------------
>
> (Updated April 25, 2013, 8:43 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Murali Reddy.
>
>
> Description
> -------
>
> Updated the user permissions check
>
>
> This addresses bug CLOUDSTACK-2134.
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/NetworkServiceImpl.java 7653a08
>
> Diff: https://reviews.apache.org/r/10727/diff/
>
>
> Testing
> -------
>
> Unit tested on basic and advanced zone
>
>
> Thanks,
>
> Jayapal Reddy
>
>
Re: Review Request: Updated the user permission to acquire ip
Posted by Jayapal Reddy <ja...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10727/
-----------------------------------------------------------
(Updated April 25, 2013, 8:43 a.m.)
Review request for cloudstack, Abhinandan Prateek and Murali Reddy.
Changes
-------
Updated access checks to vm
Description
-------
Updated the user permissions check
This addresses bug CLOUDSTACK-2134.
Diffs (updated)
-----
server/src/com/cloud/network/NetworkServiceImpl.java 7653a08
Diff: https://reviews.apache.org/r/10727/diff/
Testing
-------
Unit tested on basic and advanced zone
Thanks,
Jayapal Reddy
Re: Review Request: Updated the user permission to acquire ip
Posted by Murali Reddy <mu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10727/#review19616
-----------------------------------------------------------
server/src/com/cloud/network/NetworkServiceImpl.java
<https://reviews.apache.org/r/10727/#comment40527>
you need to check for both 'isolated' & 'shared' networks of advanced zone.
server/src/com/cloud/network/NetworkServiceImpl.java
<https://reviews.apache.org/r/10727/#comment40526>
You need to check for only basic zone here. 'shared' network of advanced zone is different from 'shared' network of basic zone w.r.t to guest IP allocation.
server/src/com/cloud/network/NetworkServiceImpl.java
<https://reviews.apache.org/r/10727/#comment40525>
this check is required, dont remove it.
server/src/com/cloud/network/NetworkServiceImpl.java
<https://reviews.apache.org/r/10727/#comment40524>
This check needs to be done for both advanced/basic zones and isolate/shared networks.
also you need to check if NIC is owned/usable by caller. No need for check access on VM
- Murali Reddy
On April 23, 2013, 10:55 a.m., Jayapal Reddy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10727/
> -----------------------------------------------------------
>
> (Updated April 23, 2013, 10:55 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Murali Reddy.
>
>
> Description
> -------
>
> Updated the user permissions check
>
>
> This addresses bug CLOUDSTACK-2134.
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/NetworkServiceImpl.java ac2ac45
>
> Diff: https://reviews.apache.org/r/10727/diff/
>
>
> Testing
> -------
>
> Unit tested on basic and advanced zone
>
>
> Thanks,
>
> Jayapal Reddy
>
>