You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/04/16 15:28:40 UTC

[GitHub] [apisix] zhixiongdu027 opened a new pull request, #6868: feat: improve kubernetes discovery

zhixiongdu027 opened a new pull request, #6868:
URL: https://github.com/apache/apisix/pull/6868

   ### Description
   
   <!-- Please include a summary of the change and which issue is fixed. -->
   <!-- Please also include relevant motivation and context. -->
   
   Fixes # (issue)
   #6830 
   
   By default, APISIX doesn't recognize extra environment variables,
   This Pr Try Inject The Env Variable Into nginx.conf  When K8S service discovery is enabled ,
   
   
   1:  inject the env variable when k8s service discovery is enabled  -> apisix/opt.lua
   
   2: update test file because env variable inject -> ci/kubernetes-ci.sh, t/kubernetes/discovery/kubernetes.t ,t/APISIX.pm
   
   3:  optimization of a character comparison  -> apisix/discovery/kubernetes/init.lua
   
   ### Checklist
   
   - [y ] I have explained the need for this PR and the problem it solves
   - [ ] I have explained the changes or the new features added to this PR
   - [ y] I have added tests corresponding to this change
   - [ ] I have updated the documentation to reflect this change
   - [ ] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
   
   <!--
   
   Note
   
   1. Mark the PR as draft until it's ready to be reviewed.
   2. Always add/update tests for any changes unless you have a good reason.
   3. Always update the documentation to reflect the changes made in the PR.
   4. Make a new commit to resolve conversations instead of `push -f`.
   5. To resolve merge conflicts, merge master instead of rebasing.
   6. Use "request review" to notify the reviewer after making changes.
   7. Only a reviewer can mark a conversation as resolved.
   
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] zhixiongdu027 closed pull request #6868: feat: improve kubernetes discovery

Posted by GitBox <gi...@apache.org>.
zhixiongdu027 closed pull request #6868: feat: improve kubernetes discovery
URL: https://github.com/apache/apisix/pull/6868


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org