You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tapestry.apache.org by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org> on 2009/06/10 14:42:07 UTC
[jira] Created: (TAP5-742) Add optional component tracing comments
to rendered output
Add optional component tracing comments to rendered output
----------------------------------------------------------
Key: TAP5-742
URL: https://issues.apache.org/jira/browse/TAP5-742
Project: Tapestry 5
Issue Type: New Feature
Components: tapestry-core
Affects Versions: 5.1.0.5
Reporter: Howard M. Lewis Ship
Priority: Minor
In complex pages, it can be hard to work backwards from a bit of output HTML in the browser, back to the component that originated the markup.
A special mode could be enabled where components would render a comment before and after rendering:
<!-- BEGIN: Index:layout.pagelink -->
<a href="dashboard">Dashboard</a>
<!-- END: Index:layout.pagelink -->
This would bloat and clutter the application (a lot!) but would be useful, on occasion. One possibility would be a special query parameter to enable this on a request-by-request basis, i.e., ?t:component-trace=true
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-742) Add optional component tracing
comments to rendered output
Posted by "Joost Schouten (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778261#action_12778261 ]
Joost Schouten commented on TAP5-742:
-------------------------------------
+1 Unit testing is where is comes in handy. With the addition of the component class to te comment It will allow you to do things like assertComponentOnPage(MyComponent.class).
> Add optional component tracing comments to rendered output
> ----------------------------------------------------------
>
> Key: TAP5-742
> URL: https://issues.apache.org/jira/browse/TAP5-742
> Project: Tapestry 5
> Issue Type: New Feature
> Components: tapestry-core
> Affects Versions: 5.1.0.5
> Reporter: Howard M. Lewis Ship
> Priority: Minor
>
> In complex pages, it can be hard to work backwards from a bit of output HTML in the browser, back to the component that originated the markup.
> A special mode could be enabled where components would render a comment before and after rendering:
> <!-- BEGIN: Index:layout.pagelink -->
> <a href="dashboard">Dashboard</a>
> <!-- END: Index:layout.pagelink -->
> This would bloat and clutter the application (a lot!) but would be useful, on occasion. One possibility would be a special query parameter to enable this on a request-by-request basis, i.e., ?t:component-trace=true
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-742) Add optional component tracing
comments to rendered output
Posted by "Thiago H. de Paula Figueiredo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12718086#action_12718086 ]
Thiago H. de Paula Figueiredo commented on TAP5-742:
----------------------------------------------------
Or an specific symbol which has a default value of tapestry.prodution-mode.
> Add optional component tracing comments to rendered output
> ----------------------------------------------------------
>
> Key: TAP5-742
> URL: https://issues.apache.org/jira/browse/TAP5-742
> Project: Tapestry 5
> Issue Type: New Feature
> Components: tapestry-core
> Affects Versions: 5.1.0.5
> Reporter: Howard M. Lewis Ship
> Priority: Minor
>
> In complex pages, it can be hard to work backwards from a bit of output HTML in the browser, back to the component that originated the markup.
> A special mode could be enabled where components would render a comment before and after rendering:
> <!-- BEGIN: Index:layout.pagelink -->
> <a href="dashboard">Dashboard</a>
> <!-- END: Index:layout.pagelink -->
> This would bloat and clutter the application (a lot!) but would be useful, on occasion. One possibility would be a special query parameter to enable this on a request-by-request basis, i.e., ?t:component-trace=true
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-742) Add optional component tracing
comments to rendered output
Posted by "Joost Schouten (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778261#action_12778261 ]
Joost Schouten commented on TAP5-742:
-------------------------------------
+1 Unit testing is where is comes in handy. With the addition of the component class to te comment It will allow you to do things like assertComponentOnPage(MyComponent.class).
> Add optional component tracing comments to rendered output
> ----------------------------------------------------------
>
> Key: TAP5-742
> URL: https://issues.apache.org/jira/browse/TAP5-742
> Project: Tapestry 5
> Issue Type: New Feature
> Components: tapestry-core
> Affects Versions: 5.1.0.5
> Reporter: Howard M. Lewis Ship
> Priority: Minor
>
> In complex pages, it can be hard to work backwards from a bit of output HTML in the browser, back to the component that originated the markup.
> A special mode could be enabled where components would render a comment before and after rendering:
> <!-- BEGIN: Index:layout.pagelink -->
> <a href="dashboard">Dashboard</a>
> <!-- END: Index:layout.pagelink -->
> This would bloat and clutter the application (a lot!) but would be useful, on occasion. One possibility would be a special query parameter to enable this on a request-by-request basis, i.e., ?t:component-trace=true
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-742) Add optional component tracing
comments to rendered output
Posted by "Massimo Lusetti (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12718084#action_12718084 ]
Massimo Lusetti commented on TAP5-742:
--------------------------------------
Yep, just a query parameter seems too much easy as Ulrich proposed a production-mode could be leveraged for this purpose.
> Add optional component tracing comments to rendered output
> ----------------------------------------------------------
>
> Key: TAP5-742
> URL: https://issues.apache.org/jira/browse/TAP5-742
> Project: Tapestry 5
> Issue Type: New Feature
> Components: tapestry-core
> Affects Versions: 5.1.0.5
> Reporter: Howard M. Lewis Ship
> Priority: Minor
>
> In complex pages, it can be hard to work backwards from a bit of output HTML in the browser, back to the component that originated the markup.
> A special mode could be enabled where components would render a comment before and after rendering:
> <!-- BEGIN: Index:layout.pagelink -->
> <a href="dashboard">Dashboard</a>
> <!-- END: Index:layout.pagelink -->
> This would bloat and clutter the application (a lot!) but would be useful, on occasion. One possibility would be a special query parameter to enable this on a request-by-request basis, i.e., ?t:component-trace=true
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-742) Add optional component tracing
comments to rendered output
Posted by "Ulrich Stärk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12718078#action_12718078 ]
Ulrich Stärk commented on TAP5-742:
-----------------------------------
I wouldn't want anyone knowing that my application is a Tapestry application to be able to see my component structure, just by adding a query parameter to the url. Why not bind this to "tapestry.production-mode==false && log.isDebugEnabled()"?
> Add optional component tracing comments to rendered output
> ----------------------------------------------------------
>
> Key: TAP5-742
> URL: https://issues.apache.org/jira/browse/TAP5-742
> Project: Tapestry 5
> Issue Type: New Feature
> Components: tapestry-core
> Affects Versions: 5.1.0.5
> Reporter: Howard M. Lewis Ship
> Priority: Minor
>
> In complex pages, it can be hard to work backwards from a bit of output HTML in the browser, back to the component that originated the markup.
> A special mode could be enabled where components would render a comment before and after rendering:
> <!-- BEGIN: Index:layout.pagelink -->
> <a href="dashboard">Dashboard</a>
> <!-- END: Index:layout.pagelink -->
> This would bloat and clutter the application (a lot!) but would be useful, on occasion. One possibility would be a special query parameter to enable this on a request-by-request basis, i.e., ?t:component-trace=true
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-742) Add optional component tracing
comments to rendered output
Posted by "Massimo Lusetti (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12718091#action_12718091 ]
Massimo Lusetti commented on TAP5-742:
--------------------------------------
Sure that would be a way to leverage tapestry.production-mode
> Add optional component tracing comments to rendered output
> ----------------------------------------------------------
>
> Key: TAP5-742
> URL: https://issues.apache.org/jira/browse/TAP5-742
> Project: Tapestry 5
> Issue Type: New Feature
> Components: tapestry-core
> Affects Versions: 5.1.0.5
> Reporter: Howard M. Lewis Ship
> Priority: Minor
>
> In complex pages, it can be hard to work backwards from a bit of output HTML in the browser, back to the component that originated the markup.
> A special mode could be enabled where components would render a comment before and after rendering:
> <!-- BEGIN: Index:layout.pagelink -->
> <a href="dashboard">Dashboard</a>
> <!-- END: Index:layout.pagelink -->
> This would bloat and clutter the application (a lot!) but would be useful, on occasion. One possibility would be a special query parameter to enable this on a request-by-request basis, i.e., ?t:component-trace=true
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-742) Add optional component tracing
comments to rendered output
Posted by "Sergey Didenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12751745#action_12751745 ]
Sergey Didenko commented on TAP5-742:
-------------------------------------
I made a temporary hackish solution for this, see http://wiki.apache.org/tapestry/Tapestry5HowToVisualizeComponentHierarchy . Hope this helps.
> Add optional component tracing comments to rendered output
> ----------------------------------------------------------
>
> Key: TAP5-742
> URL: https://issues.apache.org/jira/browse/TAP5-742
> Project: Tapestry 5
> Issue Type: New Feature
> Components: tapestry-core
> Affects Versions: 5.1.0.5
> Reporter: Howard M. Lewis Ship
> Priority: Minor
>
> In complex pages, it can be hard to work backwards from a bit of output HTML in the browser, back to the component that originated the markup.
> A special mode could be enabled where components would render a comment before and after rendering:
> <!-- BEGIN: Index:layout.pagelink -->
> <a href="dashboard">Dashboard</a>
> <!-- END: Index:layout.pagelink -->
> This would bloat and clutter the application (a lot!) but would be useful, on occasion. One possibility would be a special query parameter to enable this on a request-by-request basis, i.e., ?t:component-trace=true
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-742) Add optional component tracing
comments to rendered output
Posted by "Thiago H. de Paula Figueiredo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12718086#action_12718086 ]
Thiago H. de Paula Figueiredo commented on TAP5-742:
----------------------------------------------------
Or an specific symbol which has a default value of tapestry.prodution-mode.
> Add optional component tracing comments to rendered output
> ----------------------------------------------------------
>
> Key: TAP5-742
> URL: https://issues.apache.org/jira/browse/TAP5-742
> Project: Tapestry 5
> Issue Type: New Feature
> Components: tapestry-core
> Affects Versions: 5.1.0.5
> Reporter: Howard M. Lewis Ship
> Priority: Minor
>
> In complex pages, it can be hard to work backwards from a bit of output HTML in the browser, back to the component that originated the markup.
> A special mode could be enabled where components would render a comment before and after rendering:
> <!-- BEGIN: Index:layout.pagelink -->
> <a href="dashboard">Dashboard</a>
> <!-- END: Index:layout.pagelink -->
> This would bloat and clutter the application (a lot!) but would be useful, on occasion. One possibility would be a special query parameter to enable this on a request-by-request basis, i.e., ?t:component-trace=true
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-742) Add optional component tracing
comments to rendered output
Posted by "Sergey Didenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12751745#action_12751745 ]
Sergey Didenko commented on TAP5-742:
-------------------------------------
I made a temporary hackish solution for this, see http://wiki.apache.org/tapestry/Tapestry5HowToVisualizeComponentHierarchy . Hope this helps.
> Add optional component tracing comments to rendered output
> ----------------------------------------------------------
>
> Key: TAP5-742
> URL: https://issues.apache.org/jira/browse/TAP5-742
> Project: Tapestry 5
> Issue Type: New Feature
> Components: tapestry-core
> Affects Versions: 5.1.0.5
> Reporter: Howard M. Lewis Ship
> Priority: Minor
>
> In complex pages, it can be hard to work backwards from a bit of output HTML in the browser, back to the component that originated the markup.
> A special mode could be enabled where components would render a comment before and after rendering:
> <!-- BEGIN: Index:layout.pagelink -->
> <a href="dashboard">Dashboard</a>
> <!-- END: Index:layout.pagelink -->
> This would bloat and clutter the application (a lot!) but would be useful, on occasion. One possibility would be a special query parameter to enable this on a request-by-request basis, i.e., ?t:component-trace=true
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-742) Add optional component tracing
comments to rendered output
Posted by "Massimo Lusetti (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12718084#action_12718084 ]
Massimo Lusetti commented on TAP5-742:
--------------------------------------
Yep, just a query parameter seems too much easy as Ulrich proposed a production-mode could be leveraged for this purpose.
> Add optional component tracing comments to rendered output
> ----------------------------------------------------------
>
> Key: TAP5-742
> URL: https://issues.apache.org/jira/browse/TAP5-742
> Project: Tapestry 5
> Issue Type: New Feature
> Components: tapestry-core
> Affects Versions: 5.1.0.5
> Reporter: Howard M. Lewis Ship
> Priority: Minor
>
> In complex pages, it can be hard to work backwards from a bit of output HTML in the browser, back to the component that originated the markup.
> A special mode could be enabled where components would render a comment before and after rendering:
> <!-- BEGIN: Index:layout.pagelink -->
> <a href="dashboard">Dashboard</a>
> <!-- END: Index:layout.pagelink -->
> This would bloat and clutter the application (a lot!) but would be useful, on occasion. One possibility would be a special query parameter to enable this on a request-by-request basis, i.e., ?t:component-trace=true
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-742) Add optional component tracing
comments to rendered output
Posted by "Hugo Palma (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12721699#action_12721699 ]
Hugo Palma commented on TAP5-742:
---------------------------------
I think enabling component debugging on a request-by-request basis would be really helpful.
What about if the parameter was there but Tapestry would only actually use it's value if tapestry.prodution-mode was false ? Wouldn't that provide both ease of use and security ?
> Add optional component tracing comments to rendered output
> ----------------------------------------------------------
>
> Key: TAP5-742
> URL: https://issues.apache.org/jira/browse/TAP5-742
> Project: Tapestry 5
> Issue Type: New Feature
> Components: tapestry-core
> Affects Versions: 5.1.0.5
> Reporter: Howard M. Lewis Ship
> Priority: Minor
>
> In complex pages, it can be hard to work backwards from a bit of output HTML in the browser, back to the component that originated the markup.
> A special mode could be enabled where components would render a comment before and after rendering:
> <!-- BEGIN: Index:layout.pagelink -->
> <a href="dashboard">Dashboard</a>
> <!-- END: Index:layout.pagelink -->
> This would bloat and clutter the application (a lot!) but would be useful, on occasion. One possibility would be a special query parameter to enable this on a request-by-request basis, i.e., ?t:component-trace=true
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-742) Add optional component tracing
comments to rendered output
Posted by "Hugo Palma (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12721699#action_12721699 ]
Hugo Palma commented on TAP5-742:
---------------------------------
I think enabling component debugging on a request-by-request basis would be really helpful.
What about if the parameter was there but Tapestry would only actually use it's value if tapestry.prodution-mode was false ? Wouldn't that provide both ease of use and security ?
> Add optional component tracing comments to rendered output
> ----------------------------------------------------------
>
> Key: TAP5-742
> URL: https://issues.apache.org/jira/browse/TAP5-742
> Project: Tapestry 5
> Issue Type: New Feature
> Components: tapestry-core
> Affects Versions: 5.1.0.5
> Reporter: Howard M. Lewis Ship
> Priority: Minor
>
> In complex pages, it can be hard to work backwards from a bit of output HTML in the browser, back to the component that originated the markup.
> A special mode could be enabled where components would render a comment before and after rendering:
> <!-- BEGIN: Index:layout.pagelink -->
> <a href="dashboard">Dashboard</a>
> <!-- END: Index:layout.pagelink -->
> This would bloat and clutter the application (a lot!) but would be useful, on occasion. One possibility would be a special query parameter to enable this on a request-by-request basis, i.e., ?t:component-trace=true
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-742) Add optional component tracing
comments to rendered output
Posted by "Ulrich Stärk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12718078#action_12718078 ]
Ulrich Stärk commented on TAP5-742:
-----------------------------------
I wouldn't want anyone knowing that my application is a Tapestry application to be able to see my component structure, just by adding a query parameter to the url. Why not bind this to "tapestry.production-mode==false && log.isDebugEnabled()"?
> Add optional component tracing comments to rendered output
> ----------------------------------------------------------
>
> Key: TAP5-742
> URL: https://issues.apache.org/jira/browse/TAP5-742
> Project: Tapestry 5
> Issue Type: New Feature
> Components: tapestry-core
> Affects Versions: 5.1.0.5
> Reporter: Howard M. Lewis Ship
> Priority: Minor
>
> In complex pages, it can be hard to work backwards from a bit of output HTML in the browser, back to the component that originated the markup.
> A special mode could be enabled where components would render a comment before and after rendering:
> <!-- BEGIN: Index:layout.pagelink -->
> <a href="dashboard">Dashboard</a>
> <!-- END: Index:layout.pagelink -->
> This would bloat and clutter the application (a lot!) but would be useful, on occasion. One possibility would be a special query parameter to enable this on a request-by-request basis, i.e., ?t:component-trace=true
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TAP5-742) Add optional component tracing
comments to rendered output
Posted by "Massimo Lusetti (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12718091#action_12718091 ]
Massimo Lusetti commented on TAP5-742:
--------------------------------------
Sure that would be a way to leverage tapestry.production-mode
> Add optional component tracing comments to rendered output
> ----------------------------------------------------------
>
> Key: TAP5-742
> URL: https://issues.apache.org/jira/browse/TAP5-742
> Project: Tapestry 5
> Issue Type: New Feature
> Components: tapestry-core
> Affects Versions: 5.1.0.5
> Reporter: Howard M. Lewis Ship
> Priority: Minor
>
> In complex pages, it can be hard to work backwards from a bit of output HTML in the browser, back to the component that originated the markup.
> A special mode could be enabled where components would render a comment before and after rendering:
> <!-- BEGIN: Index:layout.pagelink -->
> <a href="dashboard">Dashboard</a>
> <!-- END: Index:layout.pagelink -->
> This would bloat and clutter the application (a lot!) but would be useful, on occasion. One possibility would be a special query parameter to enable this on a request-by-request basis, i.e., ?t:component-trace=true
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.