You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by tr...@apache.org on 2017/10/18 14:43:36 UTC
[14/15] qpid-dispatch git commit: DISPATCH-829 - Fixed delivey leak
in multicast no-path case. Removed spurious TODO.
DISPATCH-829 - Fixed delivey leak in multicast no-path case. Removed spurious TODO.
Project: http://git-wip-us.apache.org/repos/asf/qpid-dispatch/repo
Commit: http://git-wip-us.apache.org/repos/asf/qpid-dispatch/commit/956a5159
Tree: http://git-wip-us.apache.org/repos/asf/qpid-dispatch/tree/956a5159
Diff: http://git-wip-us.apache.org/repos/asf/qpid-dispatch/diff/956a5159
Branch: refs/heads/master
Commit: 956a5159942db179a4dd8325502e1287ebae1971
Parents: fea60bc
Author: Ted Ross <tr...@redhat.com>
Authored: Wed Oct 18 10:02:24 2017 -0400
Committer: Ted Ross <tr...@redhat.com>
Committed: Wed Oct 18 10:02:24 2017 -0400
----------------------------------------------------------------------
src/message.c | 2 --
src/router_core/transfer.c | 2 +-
2 files changed, 1 insertion(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/qpid-dispatch/blob/956a5159/src/message.c
----------------------------------------------------------------------
diff --git a/src/message.c b/src/message.c
index a924663..4af7619 100644
--- a/src/message.c
+++ b/src/message.c
@@ -1416,8 +1416,6 @@ void qd_message_send(qd_message_t *in_msg,
msg->send_complete = true;
// the link has an outgoing deliver. abort it.
pn_delivery_abort(pn_link_current(pnl));
-
- // TODO: Dispose of message buffers that may have accumulated
return;
}
http://git-wip-us.apache.org/repos/asf/qpid-dispatch/blob/956a5159/src/router_core/transfer.c
----------------------------------------------------------------------
diff --git a/src/router_core/transfer.c b/src/router_core/transfer.c
index fcd9061..a783693 100644
--- a/src/router_core/transfer.c
+++ b/src/router_core/transfer.c
@@ -767,7 +767,7 @@ static void qdr_link_forward_CT(qdr_core_t *core, qdr_link_t *link, qdr_delivery
if (qdr_is_addr_treatment_multicast(link->owning_addr)) {
qdr_delivery_release_CT(core, dlv);
qdr_link_issue_credit_CT(core, link, 1, false);
- // TLR: What about the action reference here?
+ qdr_delivery_decref_CT(core, dlv, "qdr_link_forward_CT - removed from action (no path)");
}
else {
DEQ_INSERT_TAIL(link->undelivered, dlv);
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org