[GitHub] knight9999 opened a new pull request #508: GH-407: remove removing certificates functions in xcode post scripts

[GitBox <gi...@apache.org>]

knight9999 opened a new pull request #508: GH-407: remove removing certificates functions in xcode post scripts
URL: https://github.com/apache/cordova-ios/pull/508
 
 
   ### Platforms affected
   ios
   
   ### What does this PR do?
   To fix #407 with automatic provioning.
   This PR fixs the issue that `ios-deploy` (`cordova run --device`) can not work with automatic provisoning. 
   
   This PR simply remove following lines 
   
   ```
   shell.rm('-rf', path.join(dstDir, '_CodeSignature'));
   shell.rm('-rf', path.join(dstDir, 'PkgInfo'));
   shell.rm('-rf', path.join(dstDir, 'embedded.mobileprovision'));
   ```
   
   in cordova/lib/copy-www-build-step.js.
   
   I am not sure why that codes are here.
   But I image that the old version of the cordova use `xcrun` for the certification after building process. In such situation, the above codes are necessary.
   
   However I found these codes blocks automatic provisioning in 
   
   ### What testing has been done on this change?
   
   I test as following on my local mac (mojave).
   
   1. `cordova run --device` with automatic provisioning using Xcode 10.1.
   2. `cordova run --device` with manual provioning using Xcode 10.1.
   3. `cordova run --device` with automatic provisioning using Xcode 9.4.1.
   4. `cordova run --device` with manual provioning using Xcode 9.4.1.
   
   All they works well.
   
   ```
   npx cordova@nightly 
   ### Checklist
   - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
   - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
   - [ ] Added automated test coverage as appropriate for this change.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org