You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildstream.apache.org by GitBox <gi...@apache.org> on 2022/02/21 07:22:07 UTC
[GitHub] [buildstream] gtristan opened a new pull request #1594: tests: Test that user specified plugins shadow core plugins
gtristan opened a new pull request #1594:
URL: https://github.com/apache/buildstream/pull/1594
Fixes #1555
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] nanonyme commented on pull request #1594: tests: Test that user specified plugins shadow core plugins
Posted by GitBox <gi...@apache.org>.
nanonyme commented on pull request #1594:
URL: https://github.com/apache/buildstream/pull/1594#issuecomment-1047154411
And it really looks like bst hangs during the tests, it's not just that there's a timeout.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] gtristan merged pull request #1594: tests: Test that user specified plugins shadow core plugins
Posted by GitBox <gi...@apache.org>.
gtristan merged pull request #1594:
URL: https://github.com/apache/buildstream/pull/1594
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] gtristan commented on pull request #1594: tests: Test that user specified plugins shadow core plugins
Posted by GitBox <gi...@apache.org>.
gtristan commented on pull request #1594:
URL: https://github.com/apache/buildstream/pull/1594#issuecomment-1047289884
> @gtristan we seriously need to debug what's wrong. The runners work just fine with bst-1 branch but not master.
The runners are timing out after 30 minutes afaics.
While bst1 takes only 15 or 20 minutes, bst2 takes around 45 minutes even locally on my laptop.
It seems the tests which involve spinning up a dummy artifact remote cache locally take a ridiculous amount of time especially (up to 45 seconds for a single test), while we *should* be able to improve the timing of the tests, I think it’s not really acceptable to live with cheap runners that simply bail out after only 30 minutes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] gtristan commented on pull request #1594: tests: Test that user specified plugins shadow core plugins
Posted by GitBox <gi...@apache.org>.
gtristan commented on pull request #1594:
URL: https://github.com/apache/buildstream/pull/1594#issuecomment-1046582681
Ran tests locally and they pass, current github runners are not working properly, timing out after only 30min...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] nanonyme commented on pull request #1594: tests: Test that user specified plugins shadow core plugins
Posted by GitBox <gi...@apache.org>.
nanonyme commented on pull request #1594:
URL: https://github.com/apache/buildstream/pull/1594#issuecomment-1047320602
I removed hardcoded 30 minute timeout and it seems that it varies when it fails https://github.com/apache/buildstream/pull/1593. But what is the alternative? They either need to get fixed or project needs some other CI infra than what Apache can provide
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] nanonyme edited a comment on pull request #1594: tests: Test that user specified plugins shadow core plugins
Posted by GitBox <gi...@apache.org>.
nanonyme edited a comment on pull request #1594:
URL: https://github.com/apache/buildstream/pull/1594#issuecomment-1047154411
And it really looks like bst/entire build hangs during the tests, it's not just that there's a timeout. Output simply ends at 58% tests done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] nanonyme edited a comment on pull request #1594: tests: Test that user specified plugins shadow core plugins
Posted by GitBox <gi...@apache.org>.
nanonyme edited a comment on pull request #1594:
URL: https://github.com/apache/buildstream/pull/1594#issuecomment-1047154411
And it really looks like bst/entire build hangs during the tests, it's not just that there's a timeout.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] nanonyme commented on pull request #1594: tests: Test that user specified plugins shadow core plugins
Posted by GitBox <gi...@apache.org>.
nanonyme commented on pull request #1594:
URL: https://github.com/apache/buildstream/pull/1594#issuecomment-1047152759
@gtristan we seriously need to debug what's wrong. The runners work just fine with bst-1 branch but not master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org