You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Harikrishna Patnala <ha...@citrix.com> on 2013/07/19 14:11:35 UTC
Review Request 12759: CLOUDSTACK-3669: Bringing down the dynamic scalable
check (for VM whether it has xstools or vmware tools in it) to the
management layer.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12759/
-----------------------------------------------------------
Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
Bugs: CLOUDSTACK-3669
Repository: cloudstack-git
Description
-------
CLOUDSTACK-3669: Bringing down the dynamic scalable check (for VM whether it has xstools or vmware tools in it) to the management layer.
Diffs
-----
core/src/com/cloud/agent/api/ScaleVmCommand.java 83cdcac
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java f80d4b6
server/src/com/cloud/vm/UserVmManagerImpl.java adcf475
server/src/com/cloud/vm/VirtualMachineManagerImpl.java 7a4bf50
server/test/com/cloud/vm/VirtualMachineManagerImplTest.java 1e6d005
Diff: https://reviews.apache.org/r/12759/diff/
Testing
-------
Thanks,
Harikrishna Patnala
Re: Review Request 12759: CLOUDSTACK-3669: Bringing down the dynamic
scalable check (for VM whether it has xstools or vmware tools in it) to the
management layer.
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12759/#review24103
-----------------------------------------------------------
Commit 8ef097ef6e73134c09b05c967ece6b795d857581 in branch refs/heads/master from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=8ef097e ]
CLOUDSTACK-3669: Bringing down the dynamic scalable check (for VM whether it has xstools or vmware tools in it) to the management layer.
Signed off by : Nitin Mehta <ni...@citrix.com>
- ASF Subversion and Git Services
On July 29, 2013, 6:38 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12759/
> -----------------------------------------------------------
>
> (Updated July 29, 2013, 6:38 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
>
>
> Bugs: CLOUDSTACK-3669
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-3669: Bringing down the dynamic scalable check (for VM whether it has xstools or vmware tools in it) to the management layer.
>
>
> Diffs
> -----
>
> core/src/com/cloud/agent/api/ScaleVmCommand.java 83cdcac
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 7173f0b
> server/src/com/cloud/vm/UserVmManagerImpl.java 34f3de2
> server/src/com/cloud/vm/VirtualMachineManagerImpl.java 1fb118f
> server/test/com/cloud/vm/VirtualMachineManagerImplTest.java 56b14cd
>
> Diff: https://reviews.apache.org/r/12759/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 12759: CLOUDSTACK-3669: Bringing down the dynamic
scalable check (for VM whether it has xstools or vmware tools in it) to the
management layer.
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12759/#review24099
-----------------------------------------------------------
Commit 2b42a271771860add43705bb64c2296179091455 in branch refs/heads/4.2 from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=2b42a27 ]
CLOUDSTACK-3669: Bringing down the dynamic scalable check (for VM whether it has xstools or vmware tools in it) to the management layer.
- ASF Subversion and Git Services
On July 29, 2013, 6:38 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12759/
> -----------------------------------------------------------
>
> (Updated July 29, 2013, 6:38 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
>
>
> Bugs: CLOUDSTACK-3669
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-3669: Bringing down the dynamic scalable check (for VM whether it has xstools or vmware tools in it) to the management layer.
>
>
> Diffs
> -----
>
> core/src/com/cloud/agent/api/ScaleVmCommand.java 83cdcac
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 7173f0b
> server/src/com/cloud/vm/UserVmManagerImpl.java 34f3de2
> server/src/com/cloud/vm/VirtualMachineManagerImpl.java 1fb118f
> server/test/com/cloud/vm/VirtualMachineManagerImplTest.java 56b14cd
>
> Diff: https://reviews.apache.org/r/12759/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 12759: CLOUDSTACK-3669: Bringing down the dynamic
scalable check (for VM whether it has xstools or vmware tools in it) to the
management layer.
Posted by Harikrishna Patnala <ha...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12759/
-----------------------------------------------------------
(Updated July 29, 2013, 6:38 a.m.)
Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
Changes
-------
resolved conflicts with master
Bugs: CLOUDSTACK-3669
Repository: cloudstack-git
Description
-------
CLOUDSTACK-3669: Bringing down the dynamic scalable check (for VM whether it has xstools or vmware tools in it) to the management layer.
Diffs (updated)
-----
core/src/com/cloud/agent/api/ScaleVmCommand.java 83cdcac
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 7173f0b
server/src/com/cloud/vm/UserVmManagerImpl.java 34f3de2
server/src/com/cloud/vm/VirtualMachineManagerImpl.java 1fb118f
server/test/com/cloud/vm/VirtualMachineManagerImplTest.java 56b14cd
Diff: https://reviews.apache.org/r/12759/diff/
Testing
-------
Thanks,
Harikrishna Patnala
Re: Review Request 12759: CLOUDSTACK-3669: Bringing down the dynamic
scalable check (for VM whether it has xstools or vmware tools in it) to the
management layer.
Posted by "Jenkins Cloudstack.org" <hu...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12759/#review23830
-----------------------------------------------------------
Review 12759 PASSED the build test
The url of build cloudstack-master-with-patch #34 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/34/
- Jenkins Cloudstack.org
On July 25, 2013, 6:05 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12759/
> -----------------------------------------------------------
>
> (Updated July 25, 2013, 6:05 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
>
>
> Bugs: CLOUDSTACK-3669
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-3669: Bringing down the dynamic scalable check (for VM whether it has xstools or vmware tools in it) to the management layer.
>
>
> Diffs
> -----
>
> core/src/com/cloud/agent/api/ScaleVmCommand.java 83cdcac
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 0fba0d9
> server/src/com/cloud/vm/UserVmManagerImpl.java ae12523
> server/src/com/cloud/vm/VirtualMachineManagerImpl.java 33dadf0
> server/test/com/cloud/vm/VirtualMachineManagerImplTest.java 44a703d
>
> Diff: https://reviews.apache.org/r/12759/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 12759: CLOUDSTACK-3669: Bringing down the dynamic
scalable check (for VM whether it has xstools or vmware tools in it) to the
management layer.
Posted by Nitin Mehta <ni...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12759/#review24080
-----------------------------------------------------------
Ship it!
Ship It!
- Nitin Mehta
On July 25, 2013, 6:05 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12759/
> -----------------------------------------------------------
>
> (Updated July 25, 2013, 6:05 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
>
>
> Bugs: CLOUDSTACK-3669
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-3669: Bringing down the dynamic scalable check (for VM whether it has xstools or vmware tools in it) to the management layer.
>
>
> Diffs
> -----
>
> core/src/com/cloud/agent/api/ScaleVmCommand.java 83cdcac
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 0fba0d9
> server/src/com/cloud/vm/UserVmManagerImpl.java ae12523
> server/src/com/cloud/vm/VirtualMachineManagerImpl.java 33dadf0
> server/test/com/cloud/vm/VirtualMachineManagerImplTest.java 44a703d
>
> Diff: https://reviews.apache.org/r/12759/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 12759: CLOUDSTACK-3669: Bringing down the dynamic
scalable check (for VM whether it has xstools or vmware tools in it) to the
management layer.
Posted by Harikrishna Patnala <ha...@citrix.com>.
> On July 26, 2013, 6:14 a.m., Nitin Mehta wrote:
> > server/src/com/cloud/vm/UserVmManagerImpl.java, line 1192
> > <https://reviews.apache.org/r/12759/diff/2/?file=327770#file327770line1192>
> >
> > You should just say tools not installed. Can be vmware as well right
Fixed this in following patch https://reviews.apache.org/r/12937/
- Harikrishna
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12759/#review23912
-----------------------------------------------------------
On July 25, 2013, 6:05 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12759/
> -----------------------------------------------------------
>
> (Updated July 25, 2013, 6:05 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
>
>
> Bugs: CLOUDSTACK-3669
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-3669: Bringing down the dynamic scalable check (for VM whether it has xstools or vmware tools in it) to the management layer.
>
>
> Diffs
> -----
>
> core/src/com/cloud/agent/api/ScaleVmCommand.java 83cdcac
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 0fba0d9
> server/src/com/cloud/vm/UserVmManagerImpl.java ae12523
> server/src/com/cloud/vm/VirtualMachineManagerImpl.java 33dadf0
> server/test/com/cloud/vm/VirtualMachineManagerImplTest.java 44a703d
>
> Diff: https://reviews.apache.org/r/12759/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 12759: CLOUDSTACK-3669: Bringing down the dynamic
scalable check (for VM whether it has xstools or vmware tools in it) to the
management layer.
Posted by Nitin Mehta <ni...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12759/#review23912
-----------------------------------------------------------
server/src/com/cloud/vm/UserVmManagerImpl.java
<https://reviews.apache.org/r/12759/#comment47756>
You should just say tools not installed. Can be vmware as well right
- Nitin Mehta
On July 25, 2013, 6:05 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12759/
> -----------------------------------------------------------
>
> (Updated July 25, 2013, 6:05 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
>
>
> Bugs: CLOUDSTACK-3669
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-3669: Bringing down the dynamic scalable check (for VM whether it has xstools or vmware tools in it) to the management layer.
>
>
> Diffs
> -----
>
> core/src/com/cloud/agent/api/ScaleVmCommand.java 83cdcac
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 0fba0d9
> server/src/com/cloud/vm/UserVmManagerImpl.java ae12523
> server/src/com/cloud/vm/VirtualMachineManagerImpl.java 33dadf0
> server/test/com/cloud/vm/VirtualMachineManagerImplTest.java 44a703d
>
> Diff: https://reviews.apache.org/r/12759/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 12759: CLOUDSTACK-3669: Bringing down the dynamic
scalable check (for VM whether it has xstools or vmware tools in it) to the
management layer.
Posted by Harikrishna Patnala <ha...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12759/
-----------------------------------------------------------
(Updated July 25, 2013, 6:05 a.m.)
Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
Changes
-------
resolved conflicts with master
Bugs: CLOUDSTACK-3669
Repository: cloudstack-git
Description
-------
CLOUDSTACK-3669: Bringing down the dynamic scalable check (for VM whether it has xstools or vmware tools in it) to the management layer.
Diffs (updated)
-----
core/src/com/cloud/agent/api/ScaleVmCommand.java 83cdcac
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 0fba0d9
server/src/com/cloud/vm/UserVmManagerImpl.java ae12523
server/src/com/cloud/vm/VirtualMachineManagerImpl.java 33dadf0
server/test/com/cloud/vm/VirtualMachineManagerImplTest.java 44a703d
Diff: https://reviews.apache.org/r/12759/diff/
Testing
-------
Thanks,
Harikrishna Patnala