You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/17 16:59:30 UTC
[GitHub] [arrow] gforsyth opened a new pull request, #13907: [MINOR] Fix docstrings for kleene boolean scalar funcs
gforsyth opened a new pull request, #13907:
URL: https://github.com/apache/arrow/pull/13907
It looks like the entries in the truth tables were copy-pasted and the
_results_ were updated to match the function, but not the operator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13907: [MINOR] Fix docstrings for kleene boolean scalar funcs
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13907:
URL: https://github.com/apache/arrow/pull/13907#issuecomment-1218285839
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW
Opening JIRAs ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #13907: MINOR: Fix docstrings for kleene boolean scalar funcs
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #13907:
URL: https://github.com/apache/arrow/pull/13907#issuecomment-1220270009
['Python', 'R'] benchmarks have high level of regressions.
[ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/edab4877b3334cb7903754f0efccb049...1dfcd406e29e4d4f857770b91d5a24f4/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] cyb70289 commented on a diff in pull request #13907: MINOR: Fix docstrings for kleene boolean scalar funcs
Posted by GitBox <gi...@apache.org>.
cyb70289 commented on code in PR #13907:
URL: https://github.com/apache/arrow/pull/13907#discussion_r948617733
##########
cpp/src/arrow/compute/kernels/scalar_boolean.cc:
##########
@@ -467,10 +467,10 @@ const FunctionDoc or_kleene_doc{
"Logical 'or' boolean values (Kleene logic)",
("This function behaves as follows with nulls:\n\n"
"- true or null = true\n"
- "- null and true = true\n"
- "- false and null = null\n"
- "- null and false = null\n"
- "- null and null = null\n"
+ "- null or true = true\n"
+ "- false or null = null\n"
+ "- null or false = null\n"
+ "- null or null = null\n"
Review Comment:
Thanks for the fix. Looks line 477 also needs update.
`see function \"and\"` --> `see function \"or\"`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] cyb70289 merged pull request #13907: MINOR: Fix docstrings for kleene boolean scalar funcs
Posted by GitBox <gi...@apache.org>.
cyb70289 merged PR #13907:
URL: https://github.com/apache/arrow/pull/13907
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] gforsyth commented on a diff in pull request #13907: MINOR: Fix docstrings for kleene boolean scalar funcs
Posted by GitBox <gi...@apache.org>.
gforsyth commented on code in PR #13907:
URL: https://github.com/apache/arrow/pull/13907#discussion_r949166452
##########
cpp/src/arrow/compute/kernels/scalar_boolean.cc:
##########
@@ -467,10 +467,10 @@ const FunctionDoc or_kleene_doc{
"Logical 'or' boolean values (Kleene logic)",
("This function behaves as follows with nulls:\n\n"
"- true or null = true\n"
- "- null and true = true\n"
- "- false and null = null\n"
- "- null and false = null\n"
- "- null and null = null\n"
+ "- null or true = true\n"
+ "- false or null = null\n"
+ "- null or false = null\n"
+ "- null or null = null\n"
Review Comment:
thanks, I updated that, too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] cyb70289 commented on pull request #13907: MINOR: Fix docstrings for kleene boolean scalar funcs
Posted by GitBox <gi...@apache.org>.
cyb70289 commented on PR #13907:
URL: https://github.com/apache/arrow/pull/13907#issuecomment-1220199446
Thanks @gforsyth !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #13907: MINOR: Fix docstrings for kleene boolean scalar funcs
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #13907:
URL: https://github.com/apache/arrow/pull/13907#issuecomment-1220269901
Benchmark runs are scheduled for baseline = a1c3d57af514d4a84e753ff51df8e563135ee55e and contender = 1a34a078b29c3f119c93de10631d26fc0d52739a. 1a34a078b29c3f119c93de10631d26fc0d52739a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/b352f37cd8dc42ff9d6ca28d29e96acb...4ecfbaf2dac04549b01d11d91f471e4d/)
[Failed :arrow_down:1.05% :arrow_up:0.14%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/d0db62a272f14257b6c7e69e4a65d67f...824efaba06254ad5b33f7afda172f236/)
[Failed :arrow_down:6.58% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/edab4877b3334cb7903754f0efccb049...1dfcd406e29e4d4f857770b91d5a24f4/)
[Finished :arrow_down:1.35% :arrow_up:0.57%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/8ba0f49167fe4f05adaa37bede89620e...0b7dd51da38c4e41b70f676a8b6ab673/)
Buildkite builds:
[Finished] [`1a34a078` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1336)
[Finished] [`1a34a078` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1352)
[Failed] [`1a34a078` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1334)
[Finished] [`1a34a078` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1351)
[Finished] [`a1c3d57a` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1335)
[Failed] [`a1c3d57a` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1351)
[Failed] [`a1c3d57a` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1333)
[Finished] [`a1c3d57a` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1350)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org