[GitHub] [airflow] ashb commented on issue #5333: [AIRFLOW-4583] Fix writing GCP keyfile to tempfile in python3

[GitBox <gi...@apache.org>]

ashb commented on issue #5333: [AIRFLOW-4583] Fix writing GCP keyfile to tempfile in python3
URL: https://github.com/apache/airflow/pull/5333#issuecomment-499405958
 
 
   This is causing a test failure:
   
   ```
   ======================================================================
   25) FAIL: test_set_env_from_extras_dict (tests.contrib.operators.test_gcp_container_operator.GKEPodOperatorTest)
   ----------------------------------------------------------------------
      Traceback (most recent call last):
       /usr/lib/python3.5/unittest/mock.py line 1576 in _inner
         return f(*args, **kw)
       /usr/lib/python3.5/unittest/mock.py line 1157 in patched
         return func(*args, **keywargs)
       tests/contrib/operators/test_gcp_container_operator.py line 254 in test_set_env_from_extras_dict
         file_mock.return_value.write.assert_called_once_with(KEYFILE_DICT_STR)
       /usr/lib/python3.5/unittest/mock.py line 803 in assert_called_once_with
         return self.assert_called_with(*args, **kwargs)
       /usr/lib/python3.5/unittest/mock.py line 792 in assert_called_with
         raise AssertionError(_error_message()) from cause
      AssertionError: Expected call: write('{ "test": "cluster" }')
      Actual call: write(b'{ "test": "cluster" }')
      -------------------- >> begin captured logging << --------------------
      airflow.task.operators: INFO: Field key_path not found in extras.
      --------------------- >> end captured logging << ---------------------
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services