You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/29 03:02:24 UTC
[GitHub] [flink] godfreyhe opened a new pull request #13832: [FLINK-19822][table-planner] Remove redundant shuffle for streaming
godfreyhe opened a new pull request #13832:
URL: https://github.com/apache/flink/pull/13832
## What is the purpose of the change
*Shuffle is one of the most heavy operation, and many shuffle operations is redundant, because the input operators have provide the required shuffle. Blink batch planner has supported removing redundant shuffle through planner rules, Blink streaming planner could also leverage similar approach to remove redundant shuffle. Different batch, stream operators require the shuffle keys and the state keys must be exactly the same, otherwise the state may be not correct. In this pr, we only support Join and regular Aggregate, other operators will be supported in the future.*
## Brief change log
- *Do some code cleanup for BatchExecCalcBase and BatchExecCorrelateBase*
- *Introduce join condition equal transfer rules to simplify join condition*
- *Remove redundant shuffle for StreamExecJoin And StreamExecGroupAggregate*
## Verifying this change
This change added tests and can be verified as follows:
- *The existing tests could cover the first two commits, e.g. batch.sql.RemoveShuffleTest, stream.sql.join.JoinReorderTest*
- *Added new test that validates the result of third commit, e.g. stream.sql.RemoveShuffleTest, RemoveShuffleITCase*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (**yes** / no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (**yes** / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13832: [FLINK-19822][table-planner] Remove redundant shuffle for streaming
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13832:
URL: https://github.com/apache/flink/pull/13832#issuecomment-718338774
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d32b02c2668093ff2745c4d124b11807f0b3f11c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8554",
"triggerID" : "d32b02c2668093ff2745c4d124b11807f0b3f11c",
"triggerType" : "PUSH"
}, {
"hash" : "2c1e73fcf0f3ce12e168b71cbe9fea1131517b0b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8599",
"triggerID" : "2c1e73fcf0f3ce12e168b71cbe9fea1131517b0b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2c1e73fcf0f3ce12e168b71cbe9fea1131517b0b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8599)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13832: [FLINK-19822][table-planner] Remove redundant shuffle for streaming
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13832:
URL: https://github.com/apache/flink/pull/13832#issuecomment-718338774
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d32b02c2668093ff2745c4d124b11807f0b3f11c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8554",
"triggerID" : "d32b02c2668093ff2745c4d124b11807f0b3f11c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d32b02c2668093ff2745c4d124b11807f0b3f11c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8554)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13832: [FLINK-19822][table-planner] Remove redundant shuffle for streaming
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13832:
URL: https://github.com/apache/flink/pull/13832#issuecomment-718338774
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d32b02c2668093ff2745c4d124b11807f0b3f11c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8554",
"triggerID" : "d32b02c2668093ff2745c4d124b11807f0b3f11c",
"triggerType" : "PUSH"
}, {
"hash" : "2c1e73fcf0f3ce12e168b71cbe9fea1131517b0b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8599",
"triggerID" : "2c1e73fcf0f3ce12e168b71cbe9fea1131517b0b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d32b02c2668093ff2745c4d124b11807f0b3f11c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8554)
* 2c1e73fcf0f3ce12e168b71cbe9fea1131517b0b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8599)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13832: [FLINK-19822][table-planner] Remove redundant shuffle for streaming
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13832:
URL: https://github.com/apache/flink/pull/13832#issuecomment-718338774
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d32b02c2668093ff2745c4d124b11807f0b3f11c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8554",
"triggerID" : "d32b02c2668093ff2745c4d124b11807f0b3f11c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d32b02c2668093ff2745c4d124b11807f0b3f11c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8554)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13832: [FLINK-19822][table-planner] Remove redundant shuffle for streaming
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13832:
URL: https://github.com/apache/flink/pull/13832#issuecomment-718338774
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d32b02c2668093ff2745c4d124b11807f0b3f11c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8554",
"triggerID" : "d32b02c2668093ff2745c4d124b11807f0b3f11c",
"triggerType" : "PUSH"
}, {
"hash" : "2c1e73fcf0f3ce12e168b71cbe9fea1131517b0b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2c1e73fcf0f3ce12e168b71cbe9fea1131517b0b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d32b02c2668093ff2745c4d124b11807f0b3f11c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8554)
* 2c1e73fcf0f3ce12e168b71cbe9fea1131517b0b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13832: [FLINK-19822][table-planner] Remove redundant shuffle for streaming
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13832:
URL: https://github.com/apache/flink/pull/13832#issuecomment-718338774
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d32b02c2668093ff2745c4d124b11807f0b3f11c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8554",
"triggerID" : "d32b02c2668093ff2745c4d124b11807f0b3f11c",
"triggerType" : "PUSH"
}, {
"hash" : "2c1e73fcf0f3ce12e168b71cbe9fea1131517b0b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8599",
"triggerID" : "2c1e73fcf0f3ce12e168b71cbe9fea1131517b0b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2c1e73fcf0f3ce12e168b71cbe9fea1131517b0b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8599)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13832: [FLINK-19822][table-planner] Remove redundant shuffle for streaming
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13832:
URL: https://github.com/apache/flink/pull/13832#issuecomment-718338774
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d32b02c2668093ff2745c4d124b11807f0b3f11c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d32b02c2668093ff2745c4d124b11807f0b3f11c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d32b02c2668093ff2745c4d124b11807f0b3f11c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13832: [FLINK-19822][table-planner] Remove redundant shuffle for streaming
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13832:
URL: https://github.com/apache/flink/pull/13832#issuecomment-718329744
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit d32b02c2668093ff2745c4d124b11807f0b3f11c (Thu Oct 29 03:05:22 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org