[jira] [Comment Edited] (BEAM-517) Check versions of pip and cython

["Marco Buccini (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15522607#comment-15522607 ] 

Marco Buccini edited comment on BEAM-517 at 9/26/16 9:51 AM:
-------------------------------------------------------------

So, from my understanding we could specify the requirements for PIP in setup.py with the following:

{code:none}
import pkg_resources
assert str(pkg_resources.get_distribution('pip').version) >= '7.0.0', "This SDK requires 'pip' >= 7.0.0"
{code}

while mentioning it in the README file. 
(it seems that the --no-binary flag was introduced in version 7.0.0: https://pip.pypa.io/en/stable/news/ )

Regarding cython, I am not quite sure about the version needed to run the code, so probably someone else might be able to tell more about it.


was (Author: makronized):
So, from my understanding we could specify the requirements for PIP in setup.py with the following:

import pkg_resources
assert str(pkg_resources.get_distribution('pip').version) >= '7.0.0', "This SDK requires 'pip' >= 7.0.0"

while mentioning it in the README file. 
(it seems that the --no-binary flag was introduced in version 7.0.0: https://pip.pypa.io/en/stable/news/ )

Regarding cython, I am not quite sure about the version needed to run the code, so probably someone else might be able to tell more about it.

> Check versions of pip and cython
> --------------------------------
>
>                 Key: BEAM-517
>                 URL: https://issues.apache.org/jira/browse/BEAM-517
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-py
>            Reporter: Ahmet Altay
>            Priority: Minor
>              Labels: starter
>
> Python SDK depends on pip and cython however it does not check the versions of these.
> Some of the pip flags does not exist in older versions:
> https://github.com/GoogleCloudPlatform/DataflowPythonSDK/issues/28#issuecomment-236382953
> (Note: Even though the above issue was reported by the user in a different repo it is related to the apache beam sdk)
> Similarly with cython, SDK supports running with or without Cython. Because of that reason it is not list it as a requirement in the setup.py file. However, with an old version of cython SDK might fail.
> To avoid the above problem: In the SDK check the version of these packages and show a warning to upgrade.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)