You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2018/06/25 18:07:59 UTC

Review Request 67724: Validate principal in `Create[Volume|Disk]` operations.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67724/
-----------------------------------------------------------

Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.


Repository: mesos


Description
-------

This patch adds validation for the principal supplied in
`Create[Volume|Disk]` operations. If the framework has a principal we
expect a set operation principal to match the framework's, but allow
the operation principal to be unset for backwards compatibility in
which case the master would fill in the framework's principal before
forwarding the operation.


Diffs
-----

  src/master/master.cpp 4ade16f044f8a4fdafd5afaba4e6a23232f83a5a 
  src/master/validation.hpp 1ba6d6530d916b5c06762ee2b0bc91b819cd10e5 
  src/master/validation.cpp 798fc7975cf0f0b8b029a33137faa1737d47df66 
  src/tests/master_validation_tests.cpp 6f2a78e394c1251016ce8ce4c0f89b35c76d6ecd 


Diff: https://reviews.apache.org/r/67724/diff/1/


Testing
-------

`sudo make check`


Thanks,

Benjamin Bannier