You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@netbeans.apache.org by matthiasblaesing <gi...@git.apache.org> on 2017/09/26 17:24:33 UTC
[GitHub] incubator-netbeans pull request #16: [NETBEANS-54] Module Review db.dataview
GitHub user matthiasblaesing opened a pull request:
https://github.com/apache/incubator-netbeans/pull/16
[NETBEANS-54] Module Review db.dataview
- no external libraries
- fix Rat files:
- add missing ALv2 headers for .sql files
- move dbdata.txt to dbdata.properties and add header
- fix missing header adjustments (all file copyright Sun/Oracle)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/matthiasblaesing/incubator-netbeans db.dataview-review
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-netbeans/pull/16.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #16
----
commit 3c33090c4d42a2f1ffa959594b6905c6b60b87da
Author: Matthias Bläsing <mb...@doppel-helix.eu>
Date: 2017-09-25T15:56:19Z
[NETBEANS-54] Module Review db.dataview
- no external libraries
- fix Rat files:
- add missing ALv2 headers for .sql files
- move dbdata.txt to dbdata.properties and add header
- fix missing header adjustments (all file copyright Sun/Oracle)
----
---
[GitHub] incubator-netbeans pull request #16: [NETBEANS-54] Module Review db.dataview
Posted by matthiasblaesing <gi...@git.apache.org>.
Github user matthiasblaesing commented on a diff in the pull request:
https://github.com/apache/incubator-netbeans/pull/16#discussion_r142002680
--- Diff: db.dataview/test/unit/src/org/netbeans/modules/db/dataview/util/TestCaseDataFactory.java ---
@@ -39,11 +39,11 @@
public static String DB_SQLINSERT="dbinsert.sql";
public static String DB_SQLSELECT="dbselect.sql";
public static String DB_SQLUPDATE="dbupdate.sql";
- public static String DB_TEXT= "dbdata.txt";
+ public static String DB_DATA= "dbdata.properties";
--- End diff --
It was necessary to make it clear, that dbdata is not a plain text file, but a properties file. Else the next reader wonders why the comment header work correctly or where it gets stipped out. For a properties file this is correct by definition.
---
[GitHub] incubator-netbeans pull request #16: [NETBEANS-54] Module Review db.dataview
Posted by emilianbold <gi...@git.apache.org>.
Github user emilianbold commented on a diff in the pull request:
https://github.com/apache/incubator-netbeans/pull/16#discussion_r141999524
--- Diff: db.dataview/test/unit/src/org/netbeans/modules/db/dataview/util/TestCaseDataFactory.java ---
@@ -39,11 +39,11 @@
public static String DB_SQLINSERT="dbinsert.sql";
public static String DB_SQLSELECT="dbselect.sql";
public static String DB_SQLUPDATE="dbupdate.sql";
- public static String DB_TEXT= "dbdata.txt";
+ public static String DB_DATA= "dbdata.properties";
--- End diff --
I don't understand why this was necessary. Just so we can add comments?
---
[GitHub] incubator-netbeans pull request #16: [NETBEANS-54] Module Review db.dataview
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-netbeans/pull/16
---