[jira] Commented: (WICKET-540) ServletWebRequest.getContextPath() ignores ContextPath as set by user (accesses HttpServletRequest directly)

["Alastair Maw (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12495437 ] 

Alastair Maw commented on WICKET-540:
-------------------------------------

I'm afraid we're unlikely to fix this in the 1.2.x branch, due to limited time and pressure to get 1.3 final out. If you can provide a patch, I'll review and commit it, however.

The 1.3.x branch uses relative URLs, which overcome this issue (you don't need to set a contextpath setting at all).

>  ServletWebRequest.getContextPath() ignores ContextPath as set by user (accesses HttpServletRequest directly)
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-540
>                 URL: https://issues.apache.org/jira/browse/WICKET-540
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.2.5
>            Reporter: Seth Green
>            Priority: Critical
>
> I'm running Wicket behind a front-end proxy. To fix certain issues with this I have set the ContextPath value in my application settings (and/or in Web.xml),  However, when using functions that attempt to get at the context path (e.g. continueToOriginalDestination()) the app does not respect my setting.
> This is because in ServletWebRequest, getContextPath() directly accesses HttpServletRequest without checking the application settings.
> I believe it should first check the application settings, and only if ContextPath is /not/ set, then access the HttpServletRequest.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.