You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/25 12:41:23 UTC
[GitHub] [flink] wuchong opened a new pull request #12320: [FLINK-17887][table][connector] Improve interface of ScanFormatFactory and SinkFormatFactory
wuchong opened a new pull request #12320:
URL: https://github.com/apache/flink/pull/12320
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](https://flink.apache.org/contributing/contribute-code.html#open-a-pull-request).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
This pull request is for improving current ScanForamtFactory and SinkFormatFactory interfaces with the following problems:
1) ScanFormat#createScanFormat only accepts ScanTableSource.Context, which means it can’t work in lookup source.
2) The naming of ScanFormat also indicates it is only used in scan source. But a lookup source should be able to work with format too.
3) It’s confusing that ScanFormatFactory#createScanFormat and ScanFormat#createScanFormat (create itself?)
## Brief change log
1. Have a common interface `DynamicTableSource.Context`, and make Context of ScanTableSource and LookupTableSource extend it, and rename them to LookupContext and ScanContext
2. Change parameter of ScanFormat.createScanFormat from ScanTableSource.Context to DynamicTableSource.Context
3. Rename ScanFormat.createScanFormat to DeserializationSchemaProvider.createDeserializationSchema
4. Rename SinkFormat.createSinkFormat to SerializationSchemaProvider.createSerializationSchema
5. Rename DeserializationFormatFactory.createScanFormat to createDeserializationProvider
6. Rename SerializationFormatFactory.createSinkFormat to createSerializationProvider
## Verifying this change
This change is a trivial rework and is covered by existing tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12320: [FLINK-17887][table][connector] Improve interface of ScanFormatFactory and SinkFormatFactory
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12320:
URL: https://github.com/apache/flink/pull/12320#issuecomment-633558182
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ea7a259ecdae60ff7b30932ac3821fdb91e5b674",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2142",
"triggerID" : "ea7a259ecdae60ff7b30932ac3821fdb91e5b674",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ea7a259ecdae60ff7b30932ac3821fdb91e5b674 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2142)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12320: [FLINK-17887][table][connector] Improve interface of ScanFormatFactory and SinkFormatFactory
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12320:
URL: https://github.com/apache/flink/pull/12320#issuecomment-633558182
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ea7a259ecdae60ff7b30932ac3821fdb91e5b674",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2142",
"triggerID" : "ea7a259ecdae60ff7b30932ac3821fdb91e5b674",
"triggerType" : "PUSH"
}, {
"hash" : "d84692ef913a138cbfad12411686451add6f38e5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2151",
"triggerID" : "d84692ef913a138cbfad12411686451add6f38e5",
"triggerType" : "PUSH"
}, {
"hash" : "0a3e2f91f950aa23d2b4421fab0418fb618ab55e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2157",
"triggerID" : "0a3e2f91f950aa23d2b4421fab0418fb618ab55e",
"triggerType" : "PUSH"
}, {
"hash" : "3153508b46fd876ac1ffd0710e54b7ec3756007f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2169",
"triggerID" : "3153508b46fd876ac1ffd0710e54b7ec3756007f",
"triggerType" : "PUSH"
}, {
"hash" : "1ad6eea2421dd2c9950f19ff2fd5ee54bb66c6f0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1ad6eea2421dd2c9950f19ff2fd5ee54bb66c6f0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3153508b46fd876ac1ffd0710e54b7ec3756007f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2169)
* 1ad6eea2421dd2c9950f19ff2fd5ee54bb66c6f0 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12320: [FLINK-17887][table][connector] Improve interface of ScanFormatFactory and SinkFormatFactory
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12320:
URL: https://github.com/apache/flink/pull/12320#issuecomment-633558182
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ea7a259ecdae60ff7b30932ac3821fdb91e5b674",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2142",
"triggerID" : "ea7a259ecdae60ff7b30932ac3821fdb91e5b674",
"triggerType" : "PUSH"
}, {
"hash" : "d84692ef913a138cbfad12411686451add6f38e5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2151",
"triggerID" : "d84692ef913a138cbfad12411686451add6f38e5",
"triggerType" : "PUSH"
}, {
"hash" : "0a3e2f91f950aa23d2b4421fab0418fb618ab55e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2157",
"triggerID" : "0a3e2f91f950aa23d2b4421fab0418fb618ab55e",
"triggerType" : "PUSH"
}, {
"hash" : "3153508b46fd876ac1ffd0710e54b7ec3756007f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2169",
"triggerID" : "3153508b46fd876ac1ffd0710e54b7ec3756007f",
"triggerType" : "PUSH"
}, {
"hash" : "1ad6eea2421dd2c9950f19ff2fd5ee54bb66c6f0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2327",
"triggerID" : "1ad6eea2421dd2c9950f19ff2fd5ee54bb66c6f0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1ad6eea2421dd2c9950f19ff2fd5ee54bb66c6f0 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2327)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12320: [FLINK-17887][table][connector] Improve interface of ScanFormatFactory and SinkFormatFactory
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12320:
URL: https://github.com/apache/flink/pull/12320#issuecomment-633558182
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ea7a259ecdae60ff7b30932ac3821fdb91e5b674",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2142",
"triggerID" : "ea7a259ecdae60ff7b30932ac3821fdb91e5b674",
"triggerType" : "PUSH"
}, {
"hash" : "d84692ef913a138cbfad12411686451add6f38e5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2151",
"triggerID" : "d84692ef913a138cbfad12411686451add6f38e5",
"triggerType" : "PUSH"
}, {
"hash" : "0a3e2f91f950aa23d2b4421fab0418fb618ab55e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2157",
"triggerID" : "0a3e2f91f950aa23d2b4421fab0418fb618ab55e",
"triggerType" : "PUSH"
}, {
"hash" : "3153508b46fd876ac1ffd0710e54b7ec3756007f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2169",
"triggerID" : "3153508b46fd876ac1ffd0710e54b7ec3756007f",
"triggerType" : "PUSH"
}, {
"hash" : "1ad6eea2421dd2c9950f19ff2fd5ee54bb66c6f0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2327",
"triggerID" : "1ad6eea2421dd2c9950f19ff2fd5ee54bb66c6f0",
"triggerType" : "PUSH"
}, {
"hash" : "6023f5f43cffbe959b1c35092e2ed4a79f2ed09c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6023f5f43cffbe959b1c35092e2ed4a79f2ed09c",
"triggerType" : "PUSH"
}, {
"hash" : "80bfdeac6274c0cfa3218da26c88f7e05d517f86",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2338",
"triggerID" : "80bfdeac6274c0cfa3218da26c88f7e05d517f86",
"triggerType" : "PUSH"
}, {
"hash" : "29cda133f6e006742e1518916128bb19b6cd6518",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2492",
"triggerID" : "29cda133f6e006742e1518916128bb19b6cd6518",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6023f5f43cffbe959b1c35092e2ed4a79f2ed09c UNKNOWN
* 80bfdeac6274c0cfa3218da26c88f7e05d517f86 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2338)
* 29cda133f6e006742e1518916128bb19b6cd6518 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2492)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12320: [FLINK-17887][table][connector] Improve interface of ScanFormatFactory and SinkFormatFactory
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12320:
URL: https://github.com/apache/flink/pull/12320#issuecomment-633558182
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ea7a259ecdae60ff7b30932ac3821fdb91e5b674",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2142",
"triggerID" : "ea7a259ecdae60ff7b30932ac3821fdb91e5b674",
"triggerType" : "PUSH"
}, {
"hash" : "d84692ef913a138cbfad12411686451add6f38e5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2151",
"triggerID" : "d84692ef913a138cbfad12411686451add6f38e5",
"triggerType" : "PUSH"
}, {
"hash" : "0a3e2f91f950aa23d2b4421fab0418fb618ab55e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2157",
"triggerID" : "0a3e2f91f950aa23d2b4421fab0418fb618ab55e",
"triggerType" : "PUSH"
}, {
"hash" : "3153508b46fd876ac1ffd0710e54b7ec3756007f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2169",
"triggerID" : "3153508b46fd876ac1ffd0710e54b7ec3756007f",
"triggerType" : "PUSH"
}, {
"hash" : "1ad6eea2421dd2c9950f19ff2fd5ee54bb66c6f0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2327",
"triggerID" : "1ad6eea2421dd2c9950f19ff2fd5ee54bb66c6f0",
"triggerType" : "PUSH"
}, {
"hash" : "6023f5f43cffbe959b1c35092e2ed4a79f2ed09c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6023f5f43cffbe959b1c35092e2ed4a79f2ed09c",
"triggerType" : "PUSH"
}, {
"hash" : "80bfdeac6274c0cfa3218da26c88f7e05d517f86",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "80bfdeac6274c0cfa3218da26c88f7e05d517f86",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1ad6eea2421dd2c9950f19ff2fd5ee54bb66c6f0 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2327)
* 6023f5f43cffbe959b1c35092e2ed4a79f2ed09c UNKNOWN
* 80bfdeac6274c0cfa3218da26c88f7e05d517f86 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12320: [FLINK-17887][table][connector] Improve interface of ScanFormatFactory and SinkFormatFactory
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12320:
URL: https://github.com/apache/flink/pull/12320#issuecomment-633558182
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ea7a259ecdae60ff7b30932ac3821fdb91e5b674",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ea7a259ecdae60ff7b30932ac3821fdb91e5b674",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ea7a259ecdae60ff7b30932ac3821fdb91e5b674 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr commented on pull request #12320: [FLINK-17887][table][connector] Improve interface of ScanFormatFactory and SinkFormatFactory
Posted by GitBox <gi...@apache.org>.
twalthr commented on pull request #12320:
URL: https://github.com/apache/flink/pull/12320#issuecomment-634585462
+1 for `Encoding` / `DecodingFormat`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #12320: [FLINK-17887][table][connector] Improve interface of ScanFormatFactory and SinkFormatFactory
Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #12320:
URL: https://github.com/apache/flink/pull/12320#issuecomment-634421914
Hi @twalthr , I can see the benefit to have a hierarchy in the format interfaces. What do you think about to use the first proposal in our offline discussion? That `DecodingFormat#createRuntimeDecoder()` and `EncodingFormat#createRuntimeEncoder()`. I don't have a clear idea how to give a suitable method name for `SourceFormat#createXxxx`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12320: [FLINK-17887][table][connector] Improve interface of ScanFormatFactory and SinkFormatFactory
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12320:
URL: https://github.com/apache/flink/pull/12320#issuecomment-633554289
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit ea7a259ecdae60ff7b30932ac3821fdb91e5b674 (Mon May 25 12:44:15 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong edited a comment on pull request #12320: [FLINK-17887][table][connector] Improve interface of ScanFormatFactory and SinkFormatFactory
Posted by GitBox <gi...@apache.org>.
wuchong edited a comment on pull request #12320:
URL: https://github.com/apache/flink/pull/12320#issuecomment-633558842
When I writing the code, I have a feeling that maybe `DeserializationFormat` is a better name than `DeserializationSchemaProvider` , because it is created from `DeserializationFormatFactory` and is more intuitive in the `FactoryUtil#discoverXxxxFormat` than `FactoryUtil#discoverXxxxProvider`. But I’m not sure what’s your opinion here @twalthr @KurtYoung , as we’re swinging in the new names again…
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12320: [FLINK-17887][table][connector] Improve interface of ScanFormatFactory and SinkFormatFactory
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12320:
URL: https://github.com/apache/flink/pull/12320#issuecomment-633558182
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ea7a259ecdae60ff7b30932ac3821fdb91e5b674",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2142",
"triggerID" : "ea7a259ecdae60ff7b30932ac3821fdb91e5b674",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ea7a259ecdae60ff7b30932ac3821fdb91e5b674 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2142)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12320: [FLINK-17887][table][connector] Improve interface of ScanFormatFactory and SinkFormatFactory
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12320:
URL: https://github.com/apache/flink/pull/12320#issuecomment-633558182
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ea7a259ecdae60ff7b30932ac3821fdb91e5b674",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2142",
"triggerID" : "ea7a259ecdae60ff7b30932ac3821fdb91e5b674",
"triggerType" : "PUSH"
}, {
"hash" : "d84692ef913a138cbfad12411686451add6f38e5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2151",
"triggerID" : "d84692ef913a138cbfad12411686451add6f38e5",
"triggerType" : "PUSH"
}, {
"hash" : "0a3e2f91f950aa23d2b4421fab0418fb618ab55e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2157",
"triggerID" : "0a3e2f91f950aa23d2b4421fab0418fb618ab55e",
"triggerType" : "PUSH"
}, {
"hash" : "3153508b46fd876ac1ffd0710e54b7ec3756007f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2169",
"triggerID" : "3153508b46fd876ac1ffd0710e54b7ec3756007f",
"triggerType" : "PUSH"
}, {
"hash" : "1ad6eea2421dd2c9950f19ff2fd5ee54bb66c6f0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2327",
"triggerID" : "1ad6eea2421dd2c9950f19ff2fd5ee54bb66c6f0",
"triggerType" : "PUSH"
}, {
"hash" : "6023f5f43cffbe959b1c35092e2ed4a79f2ed09c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6023f5f43cffbe959b1c35092e2ed4a79f2ed09c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1ad6eea2421dd2c9950f19ff2fd5ee54bb66c6f0 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2327)
* 6023f5f43cffbe959b1c35092e2ed4a79f2ed09c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12320: [FLINK-17887][table][connector] Improve interface of ScanFormatFactory and SinkFormatFactory
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12320:
URL: https://github.com/apache/flink/pull/12320#issuecomment-633558182
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ea7a259ecdae60ff7b30932ac3821fdb91e5b674",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2142",
"triggerID" : "ea7a259ecdae60ff7b30932ac3821fdb91e5b674",
"triggerType" : "PUSH"
}, {
"hash" : "d84692ef913a138cbfad12411686451add6f38e5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2151",
"triggerID" : "d84692ef913a138cbfad12411686451add6f38e5",
"triggerType" : "PUSH"
}, {
"hash" : "0a3e2f91f950aa23d2b4421fab0418fb618ab55e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2157",
"triggerID" : "0a3e2f91f950aa23d2b4421fab0418fb618ab55e",
"triggerType" : "PUSH"
}, {
"hash" : "3153508b46fd876ac1ffd0710e54b7ec3756007f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2169",
"triggerID" : "3153508b46fd876ac1ffd0710e54b7ec3756007f",
"triggerType" : "PUSH"
}, {
"hash" : "1ad6eea2421dd2c9950f19ff2fd5ee54bb66c6f0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2327",
"triggerID" : "1ad6eea2421dd2c9950f19ff2fd5ee54bb66c6f0",
"triggerType" : "PUSH"
}, {
"hash" : "6023f5f43cffbe959b1c35092e2ed4a79f2ed09c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6023f5f43cffbe959b1c35092e2ed4a79f2ed09c",
"triggerType" : "PUSH"
}, {
"hash" : "80bfdeac6274c0cfa3218da26c88f7e05d517f86",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2338",
"triggerID" : "80bfdeac6274c0cfa3218da26c88f7e05d517f86",
"triggerType" : "PUSH"
}, {
"hash" : "29cda133f6e006742e1518916128bb19b6cd6518",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "29cda133f6e006742e1518916128bb19b6cd6518",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6023f5f43cffbe959b1c35092e2ed4a79f2ed09c UNKNOWN
* 80bfdeac6274c0cfa3218da26c88f7e05d517f86 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2338)
* 29cda133f6e006742e1518916128bb19b6cd6518 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12320: [FLINK-17887][table][connector] Improve interface of ScanFormatFactory and SinkFormatFactory
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12320:
URL: https://github.com/apache/flink/pull/12320#issuecomment-633558182
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ea7a259ecdae60ff7b30932ac3821fdb91e5b674",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2142",
"triggerID" : "ea7a259ecdae60ff7b30932ac3821fdb91e5b674",
"triggerType" : "PUSH"
}, {
"hash" : "d84692ef913a138cbfad12411686451add6f38e5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2151",
"triggerID" : "d84692ef913a138cbfad12411686451add6f38e5",
"triggerType" : "PUSH"
}, {
"hash" : "0a3e2f91f950aa23d2b4421fab0418fb618ab55e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2157",
"triggerID" : "0a3e2f91f950aa23d2b4421fab0418fb618ab55e",
"triggerType" : "PUSH"
}, {
"hash" : "3153508b46fd876ac1ffd0710e54b7ec3756007f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2169",
"triggerID" : "3153508b46fd876ac1ffd0710e54b7ec3756007f",
"triggerType" : "PUSH"
}, {
"hash" : "1ad6eea2421dd2c9950f19ff2fd5ee54bb66c6f0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2327",
"triggerID" : "1ad6eea2421dd2c9950f19ff2fd5ee54bb66c6f0",
"triggerType" : "PUSH"
}, {
"hash" : "6023f5f43cffbe959b1c35092e2ed4a79f2ed09c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6023f5f43cffbe959b1c35092e2ed4a79f2ed09c",
"triggerType" : "PUSH"
}, {
"hash" : "80bfdeac6274c0cfa3218da26c88f7e05d517f86",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2338",
"triggerID" : "80bfdeac6274c0cfa3218da26c88f7e05d517f86",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1ad6eea2421dd2c9950f19ff2fd5ee54bb66c6f0 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2327)
* 6023f5f43cffbe959b1c35092e2ed4a79f2ed09c UNKNOWN
* 80bfdeac6274c0cfa3218da26c88f7e05d517f86 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2338)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12320: [FLINK-17887][table][connector] Improve interface of ScanFormatFactory and SinkFormatFactory
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12320:
URL: https://github.com/apache/flink/pull/12320#issuecomment-633558182
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12320: [FLINK-17887][table][connector] Improve interface of ScanFormatFactory and SinkFormatFactory
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12320:
URL: https://github.com/apache/flink/pull/12320#issuecomment-633558182
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ea7a259ecdae60ff7b30932ac3821fdb91e5b674",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2142",
"triggerID" : "ea7a259ecdae60ff7b30932ac3821fdb91e5b674",
"triggerType" : "PUSH"
}, {
"hash" : "d84692ef913a138cbfad12411686451add6f38e5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2151",
"triggerID" : "d84692ef913a138cbfad12411686451add6f38e5",
"triggerType" : "PUSH"
}, {
"hash" : "0a3e2f91f950aa23d2b4421fab0418fb618ab55e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2157",
"triggerID" : "0a3e2f91f950aa23d2b4421fab0418fb618ab55e",
"triggerType" : "PUSH"
}, {
"hash" : "3153508b46fd876ac1ffd0710e54b7ec3756007f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2169",
"triggerID" : "3153508b46fd876ac1ffd0710e54b7ec3756007f",
"triggerType" : "PUSH"
}, {
"hash" : "1ad6eea2421dd2c9950f19ff2fd5ee54bb66c6f0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2327",
"triggerID" : "1ad6eea2421dd2c9950f19ff2fd5ee54bb66c6f0",
"triggerType" : "PUSH"
}, {
"hash" : "6023f5f43cffbe959b1c35092e2ed4a79f2ed09c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6023f5f43cffbe959b1c35092e2ed4a79f2ed09c",
"triggerType" : "PUSH"
}, {
"hash" : "80bfdeac6274c0cfa3218da26c88f7e05d517f86",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2338",
"triggerID" : "80bfdeac6274c0cfa3218da26c88f7e05d517f86",
"triggerType" : "PUSH"
}, {
"hash" : "29cda133f6e006742e1518916128bb19b6cd6518",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2492",
"triggerID" : "29cda133f6e006742e1518916128bb19b6cd6518",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6023f5f43cffbe959b1c35092e2ed4a79f2ed09c UNKNOWN
* 29cda133f6e006742e1518916128bb19b6cd6518 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2492)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong merged pull request #12320: [FLINK-17887][table][connector] Improve interface of ScanFormatFactory and SinkFormatFactory
Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #12320:
URL: https://github.com/apache/flink/pull/12320
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr commented on a change in pull request #12320: [FLINK-17887][table][connector] Improve interface of ScanFormatFactory and SinkFormatFactory
Posted by GitBox <gi...@apache.org>.
twalthr commented on a change in pull request #12320:
URL: https://github.com/apache/flink/pull/12320#discussion_r432912683
##########
File path: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/table/KafkaDynamicSourceBase.java
##########
@@ -85,7 +85,7 @@
* @param outputDataType Source produced data type
* @param topic Kafka topic to consume.
* @param properties Properties for the Kafka consumer.
- * @param scanFormat Scan format for decoding records from Kafka.
+ * @param decodingFormat Scan format for decoding records from Kafka.
Review comment:
fix wrong indention and remove "Scan" from Javadoc?
##########
File path: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/table/KafkaDynamicSinkBase.java
##########
@@ -63,23 +63,23 @@ protected KafkaDynamicSinkBase(
String topic,
Properties properties,
Optional<FlinkKafkaPartitioner<RowData>> partitioner,
- SinkFormat<SerializationSchema<RowData>> sinkFormat) {
+ EncodingFormat<SerializationSchema<RowData>> encodingFormat) {
this.consumedDataType = Preconditions.checkNotNull(consumedDataType, "Consumed data type must not be null.");
this.topic = Preconditions.checkNotNull(topic, "Topic must not be null.");
this.properties = Preconditions.checkNotNull(properties, "Properties must not be null.");
this.partitioner = Preconditions.checkNotNull(partitioner, "Partitioner must not be null.");
- this.sinkFormat = Preconditions.checkNotNull(sinkFormat, "Sink format must not be null.");
+ this.encodingFormat = Preconditions.checkNotNull(encodingFormat, "Sink format must not be null.");
Review comment:
update error message?
##########
File path: flink-connectors/flink-connector-kafka-0.11/src/test/java/org/apache/flink/streaming/connectors/kafka/table/Kafka011DynamicTableFactoryTest.java
##########
@@ -82,12 +82,12 @@ protected KafkaDynamicSinkBase getExpectedSink(
String topic,
Properties properties,
Optional<FlinkKafkaPartitioner<RowData>> partitioner,
- SinkFormat<SerializationSchema<RowData>> sinkFormat) {
+ EncodingFormat<SerializationSchema<RowData>> encodingFormat) {
return new Kafka011DynamicSink(
consumedDataType,
topic,
properties,
partitioner,
- sinkFormat);
+ encodingFormat);
Review comment:
fix wrong indention here and at other locations
##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/connector/format/Format.java
##########
@@ -34,15 +34,15 @@
*
* <p>Formats can be distinguished along two dimensions:
* <ul>
- * <li>Context in which the format is applied (e.g. {@link ScanTableSource} or {@link DynamicTableSink}).
+ * <li>Context in which the format is applied (e.g. {@link DynamicTableSource} or {@link DynamicTableSink}).
Review comment:
we can remove the `e.g.` it is only for those two locations now
##########
File path: flink-table/flink-table-common/src/test/java/org/apache/flink/table/factories/TestDynamicTableFactory.java
##########
@@ -134,13 +134,14 @@ public String factoryIdentifier() {
public static class DynamicTableSourceMock implements ScanTableSource {
public final String target;
- public final @Nullable ScanFormat<DeserializationSchema<RowData>> sourceKeyFormat;
- public final ScanFormat<DeserializationSchema<RowData>> sourceValueFormat;
+ public final @Nullable
+ DecodingFormat<DeserializationSchema<RowData>> sourceKeyFormat;
Review comment:
fix formatting here and below
##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/connector/format/DecodingFormat.java
##########
@@ -19,19 +19,19 @@
package org.apache.flink.table.connector.format;
import org.apache.flink.annotation.PublicEvolving;
-import org.apache.flink.table.connector.source.ScanTableSource;
+import org.apache.flink.table.connector.source.DynamicTableSource;
import org.apache.flink.table.types.DataType;
/**
- * A {@link Format} for a {@link ScanTableSource}.
+ * A {@link Format} for a {@link DynamicTableSource} to reading rows.
Review comment:
nit: `for reading rows`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #12320: [FLINK-17887][table][connector] Improve interface of ScanFormatFactory and SinkFormatFactory
Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #12320:
URL: https://github.com/apache/flink/pull/12320#issuecomment-633558842
When I writing the code, I have a feeling that maybe `DeserializationFormat` is a better name than `DeserializationSchemaProvider` , because it is created from `DeserializationFormatFactory` and is more intuitive in the `FactoryUtil#discoverXxxxFormat`. But I’m not sure what’s your opinion here @twalthr @KurtYoung , as we’re swinging in the new names again…
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org